All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Mezin <mezin.alexander@gmail.com>
To: linux-acpi@vger.kernel.org
Cc: tianyu.lan@intel.com, Alexander Mezin <mezin.alexander@gmail.com>
Subject: [PATCH] ACPI / AC: change notification handler type to ACPI_ALL_NOTIFY
Date: Sat,  4 Jan 2014 09:07:59 +0700	[thread overview]
Message-ID: <1388801279-15502-1-git-send-email-mezin.alexander@gmail.com> (raw)

With kernel 3.13rc5 there are no AC adapter notifications on my laptop.

Commit cc8ef52707341e67a12067d6ead991d56ea017ca
"ACPI / AC: convert ACPI ac driver to platform bus" changed the driver
to listen only to device notifications. However, aml code on my laptop
notifies the driver with zero event.

This patch changes the driver to listen to all events again.

References: https://bugzilla.kernel.org/show_bug.cgi?id=67821

Signed-off-by: Alexander Mezin <mezin.alexander@gmail.com>
---
 drivers/acpi/ac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
index 8711e37..3c2e4aa 100644
--- a/drivers/acpi/ac.c
+++ b/drivers/acpi/ac.c
@@ -207,7 +207,7 @@ static int acpi_ac_probe(struct platform_device *pdev)
 		goto end;
 
 	result = acpi_install_notify_handler(ACPI_HANDLE(&pdev->dev),
-			ACPI_DEVICE_NOTIFY, acpi_ac_notify_handler, ac);
+			ACPI_ALL_NOTIFY, acpi_ac_notify_handler, ac);
 	if (result) {
 		power_supply_unregister(&ac->charger);
 		goto end;
@@ -255,7 +255,7 @@ static int acpi_ac_remove(struct platform_device *pdev)
 		return -EINVAL;
 
 	acpi_remove_notify_handler(ACPI_HANDLE(&pdev->dev),
-			ACPI_DEVICE_NOTIFY, acpi_ac_notify_handler);
+			ACPI_ALL_NOTIFY, acpi_ac_notify_handler);
 
 	ac = platform_get_drvdata(pdev);
 	if (ac->charger.dev)
-- 
1.8.5.2


             reply	other threads:[~2014-01-04  2:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-04  2:07 Alexander Mezin [this message]
2014-01-05 22:11 ` [PATCH] ACPI / AC: change notification handler type to ACPI_ALL_NOTIFY Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388801279-15502-1-git-send-email-mezin.alexander@gmail.com \
    --to=mezin.alexander@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=tianyu.lan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.