All of lore.kernel.org
 help / color / mirror / Atom feed
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/8] clk: sunxi: choose correct name for multiple output factor clocks
Date: Mon,  6 Jan 2014 13:58:06 +0800	[thread overview]
Message-ID: <1388987892-23733-3-git-send-email-wens@csie.org> (raw)
In-Reply-To: <1388987892-23733-1-git-send-email-wens@csie.org>

Some factor clocks, such as the parent clock of pll5 and pll6, have
multiple output names. Use the last name as the name for the clock
itself.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/clk/sunxi/clk-sunxi.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index 14a3774..7ce7e1c 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -484,7 +484,7 @@ static struct clk * __init sunxi_factors_clk_setup(struct device_node *node,
 	const char *clk_name = node->name;
 	const char *parents[SUNXI_MAX_PARENTS];
 	void *reg;
-	int i = 0;
+	int j, i = 0;
 
 	reg = of_iomap(node, 0);
 
@@ -493,14 +493,14 @@ static struct clk * __init sunxi_factors_clk_setup(struct device_node *node,
 	       (parents[i] = of_clk_get_parent_name(node, i)) != NULL)
 		i++;
 
-	/* Nodes should be providing the name via clock-output-names
-	 * but originally our dts didn't, and so we used node->name.
-	 * The new, better nodes look like clk at deadbeef, so we pull the
-	 * name just in this case */
-	if (!strcmp("clk", clk_name)) {
-		of_property_read_string_index(node, "clock-output-names",
-					      0, &clk_name);
-	}
+	/*
+	 * factor clocks, such as pll5 and pll6, may have multiple outputs
+	 * Use the last clock output name as this clock's name.
+	 * This matches the behavior of of_clk_get_parent_name()
+	 */
+	j = of_property_count_strings(node, "clock-output-names");
+	of_property_read_string_index(node, "clock-output-names", j - 1,
+				      &clk_name);
 
 	factors = kzalloc(sizeof(struct clk_factors), GFP_KERNEL);
 	if (!factors)
-- 
1.8.5.2

  parent reply	other threads:[~2014-01-06  5:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06  5:58 [PATCH v2 0/8] arm: sunxi: rename DT clock node names to clk@N Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 1/8] clk: sunxi: add clock-output-names dt property support Chen-Yu Tsai
2014-01-07 22:14   ` Maxime Ripard
2014-01-08  1:44     ` [linux-sunxi] " Chen-Yu Tsai
2014-01-06  5:58 ` Chen-Yu Tsai [this message]
2014-01-07 22:16   ` [PATCH v2 2/8] clk: sunxi: choose correct name for multiple output factor clocks Maxime Ripard
2014-01-07 22:41     ` Maxime Ripard
2014-01-06  5:58 ` [PATCH v2 3/8] clk: sunxi: get divs parent clock name from parent factor clock Chen-Yu Tsai
2014-01-07 22:17   ` Maxime Ripard
2014-01-06  5:58 ` [PATCH v2 4/8] arm: dts: sun4i: rename clock node names to clk@N Chen-Yu Tsai
2014-01-07 22:38   ` Maxime Ripard
2014-01-08  1:38     ` Chen-Yu Tsai
2014-01-09  8:53       ` Maxime Ripard
2014-01-09 15:47         ` Emilio López
2014-01-09 16:02           ` [linux-sunxi] " Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 5/8] arm: dts: sun5i: " Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 6/8] arm: dts: sun6i: " Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 7/8] arm: dts: sun7i: " Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 8/8] arm: sun7i: cubietruck: Enable the i2c controllers Chen-Yu Tsai
2014-01-07 22:40   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388987892-23733-3-git-send-email-wens@csie.org \
    --to=wens@csie.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.