All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Diamand <chris@diamand.org>
To: dmitry.torokhov@gmail.com, cernekee@gmail.com,
	yunkang.tang@cn.alps.com, dturvene@dahetral.com
Cc: linux-input@vger.kernel.org, Chris Diamand <chris@diamand.org>
Subject: [PATCH] Input: ALPS - Recognise "Dolphin V2" touchpads
Date: Mon,  6 Jan 2014 20:10:34 +0000	[thread overview]
Message-ID: <1389039034-14040-1-git-send-email-chris@diamand.org> (raw)

This is the touchpad used on the Dell Vostro 3360. Without
this change, the driver reports this as follows:

psmouse serio1: alps: Unknown ALPS touchpad: E7=73 03 50, EC=73 02 02

It seems to use the ALPS V5 protocol, so identify it
as such by allowing ec[1] == 0x02.

This is based on src/alps.c from the DKMS driver here:
http://www.dahetral.com/public-download/alps-psmouse-dlkm-for-3-2-and-3-5/

Signed-off-by: Chris Diamand <chris@diamand.org>
---
 drivers/input/mouse/alps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index 5cf62e3..d5d15eb 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -1845,7 +1845,7 @@ static int alps_identify(struct psmouse *psmouse, struct alps_data *priv)
 	if (alps_match_table(psmouse, priv, e7, ec) == 0) {
 		return 0;
 	} else if (e7[0] == 0x73 && e7[1] == 0x03 && e7[2] == 0x50 &&
-		   ec[0] == 0x73 && ec[1] == 0x01) {
+		   ec[0] == 0x73 && (ec[1] == 0x01 || ec[1] == 0x02)) {
 		priv->proto_version = ALPS_PROTO_V5;
 		alps_set_defaults(priv);
 
-- 
1.8.5.2


             reply	other threads:[~2014-01-06 20:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 20:10 Chris Diamand [this message]
     [not found] ` <CAKvfdtK18rQ4TOqwKCj1P3oQs-BQZr2h3db5NH18WdtNjjnH=g@mail.gmail.com>
2014-01-07 16:24   ` [PATCH] Input: ALPS - Recognise "Dolphin V2" touchpads Tommy Will
2014-01-07 18:30     ` Chris Diamand
2014-01-07 18:59       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389039034-14040-1-git-send-email-chris@diamand.org \
    --to=chris@diamand.org \
    --cc=cernekee@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dturvene@dahetral.com \
    --cc=linux-input@vger.kernel.org \
    --cc=yunkang.tang@cn.alps.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.