All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Gleb Natapov <gleb@minantech.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	agraf@suse.de, Christian Borntraeger <borntraeger@de.ibm.com>
Subject: [PATCH] kvm/irqchip: Speed up KVM_SET_GSI_ROUTING
Date: Thu, 16 Jan 2014 10:23:39 +0100	[thread overview]
Message-ID: <1389864219-47412-1-git-send-email-borntraeger@de.ibm.com> (raw)

When starting lots of dataplane devices the bootup takes very long on my
s390 system(prototype irqfd code). With larger setups we are even able to
trigger some timeouts in some components.
Turns out that the KVM_SET_GSI_ROUTING ioctl takes very
long (strace claims up to 0.1 sec) when having multiple CPUs.
This is caused by the  synchronize_rcu and the HZ=100 of s390.
We can defer the freeing outside of the ioctl path by using kfree_rcu.

Please note that we now have to check for a NULL pointer, since
the underlying call_rcu in kfree_rcu cannot handle broken rcu
callbacks.

This patch reduces the boot time till mounting root from 8 to 2 seconds
on my s390 guest with 100 disks.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 include/linux/kvm_host.h | 1 +
 virt/kvm/irqchip.c       | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 3d1b0e6..2f19079 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -327,6 +327,7 @@ struct kvm_kernel_irq_routing_entry {
 #ifdef CONFIG_HAVE_KVM_IRQ_ROUTING
 
 struct kvm_irq_routing_table {
+	struct rcu_head	rcu;
 	int chip[KVM_NR_IRQCHIPS][KVM_IRQCHIP_NUM_PINS];
 	struct kvm_kernel_irq_routing_entry *rt_entries;
 	u32 nr_rt_entries;
diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c
index 20dc9e4..3e2ebed 100644
--- a/virt/kvm/irqchip.c
+++ b/virt/kvm/irqchip.c
@@ -226,12 +226,11 @@ int kvm_set_irq_routing(struct kvm *kvm,
 	kvm_irq_routing_update(kvm, new);
 	mutex_unlock(&kvm->irq_lock);
 
-	synchronize_rcu();
-
 	new = old;
 	r = 0;
 
 out:
-	kfree(new);
+	if (new)
+		kfree_rcu(new, rcu);
 	return r;
 }
-- 
1.8.4.2

             reply	other threads:[~2014-01-16  9:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16  9:23 Christian Borntraeger [this message]
2014-01-16 11:24 ` [PATCH] kvm/irqchip: Speed up KVM_SET_GSI_ROUTING Paolo Bonzini
2014-01-16 12:44   ` [PATCHv2/RFC] " Christian Borntraeger
2014-01-16 12:59     ` Paolo Bonzini
2014-01-16 13:06       ` Christian Borntraeger
2014-01-16 13:07         ` Paolo Bonzini
2014-01-16 18:56           ` Michael S. Tsirkin
2014-01-17  8:29             ` Christian Borntraeger
2014-01-17  9:19               ` Paolo Bonzini
2014-02-19 22:23               ` Paolo Bonzini
2014-02-21  4:59                 ` Andrew Theurer
2014-01-16 18:55     ` Michael S. Tsirkin
2014-01-16 20:07       ` [PATCHv3] " Christian Borntraeger
2014-01-16 20:22         ` Michael S. Tsirkin
2014-01-17 14:03           ` Paolo Bonzini
2014-01-17 15:03             ` Christian Borntraeger
2014-01-17 15:26               ` Paolo Bonzini
2014-02-21 17:35     ` [PATCHv2/RFC] " Paolo Bonzini
2014-02-24 11:58       ` [PATCHv2] " Christian Borntraeger
2014-02-24 12:02         ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389864219-47412-1-git-send-email-borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=cornelia.huck@de.ibm.com \
    --cc=gleb@minantech.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.