All of lore.kernel.org
 help / color / mirror / Atom feed
From: jeff.mcgee@intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/4] pm_rps: New subtest min-max-config-idle
Date: Tue, 28 Jan 2014 18:25:03 -0600	[thread overview]
Message-ID: <1390955106-29853-2-git-send-email-jeff.mcgee@intel.com> (raw)
In-Reply-To: <1390955106-29853-1-git-send-email-jeff.mcgee@intel.com>

From: Jeff McGee <jeff.mcgee@intel.com>

Like subtest basic-api, but additionally requires that current
frequency is settling to the configured minimum within reasonable
time since we are idle.

Signed-off-by: Jeff McGee <jeff.mcgee@intel.com>
---
 tests/pm_rps.c | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/tests/pm_rps.c b/tests/pm_rps.c
index 7d9069a..dabc2ba 100644
--- a/tests/pm_rps.c
+++ b/tests/pm_rps.c
@@ -204,9 +204,12 @@ static void min_max_config(void (*check)(void))
 	log("\nIncrease max above RP0 (invalid)...\n");
 	writeval_inval(stuff[MAX].filp, origfreqs[RP0] + 1000);
 	check();
+
+	writeval(stuff[MIN].filp, origfreqs[MIN]);
+	writeval(stuff[MAX].filp, origfreqs[MAX]);
 }
 
-static void idle_check(void)
+static void basic_check(void)
 {
 	int freqs[NUMFREQ];
 
@@ -215,6 +218,29 @@ static void idle_check(void)
 	checkit(freqs);
 }
 
+#define IDLE_WAIT_TIMESTEP_MSEC 100
+#define IDLE_WAIT_TIMEOUT_MSEC 3000
+static void idle_check(void)
+{
+	int freqs[NUMFREQ];
+	int wait = 0;
+
+	/* Monitor frequencies until cur settles down to min, which should
+	 * happen within the allotted time */
+	do {
+		read_freqs(freqs);
+		dump(freqs);
+		checkit(freqs);
+		if (freqs[CUR] == freqs[MIN])
+			break;
+		usleep(1000 * IDLE_WAIT_TIMESTEP_MSEC);
+		wait += IDLE_WAIT_TIMESTEP_MSEC;
+	} while (wait < IDLE_WAIT_TIMEOUT_MSEC);
+
+	igt_assert(freqs[CUR] == freqs[MIN]);
+	log("Required %d msec to reach cur=min\n", wait);
+}
+
 static void pm_rps_exit_handler(int sig)
 {
 	if (origfreqs[MIN] > readval(stuff[MAX].filp)) {
@@ -291,6 +317,9 @@ int main(int argc, char **argv)
 	}
 
 	igt_subtest("basic-api")
+		min_max_config(basic_check);
+
+	igt_subtest("min-max-config-idle")
 		min_max_config(idle_check);
 
 	igt_exit();
-- 
1.8.5.2

  reply	other threads:[~2014-01-29  0:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29  0:25 Add two new subtests to pm_rps jeff.mcgee
2014-01-29  0:25 ` jeff.mcgee [this message]
2014-01-29  0:25 ` [PATCH 2/4] lib/drmtest: Add igt_wait_helper jeff.mcgee
2014-01-29  0:25 ` [PATCH 3/4] pm_rps: Add load helper for loading gpu jeff.mcgee
2014-01-29  0:25 ` [PATCH 4/4] pm_rps: New subtest min-max-config-loaded jeff.mcgee
2014-02-05 19:20 ` Add two new subtests to pm_rps Jeff McGee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390955106-29853-2-git-send-email-jeff.mcgee@intel.com \
    --to=jeff.mcgee@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.