All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: <linux-btrfs@vger.kernel.org>, <xfs@oss.sgi.com>
Subject: [PATCH] xfstests: generic/299 can have truncate fail
Date: Thu, 30 Jan 2014 17:01:23 -0500	[thread overview]
Message-ID: <1391119283-11116-1-git-send-email-jbacik@fb.com> (raw)

So this test does lots of fallocate/truncate noise while doing aio overwrites to
try and exercise a deadlock found in ext4.  Because it runs so hard with ENOSPC
it can sometimes cause truncate to fail on btrfs.  This is ok and doesn't affect
the validity of the test, we just need to catch the output so it doesn't cause
the test to fail.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
---
 tests/generic/299 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/299 b/tests/generic/299
index 14cce96..bf02c94 100755
--- a/tests/generic/299
+++ b/tests/generic/299
@@ -130,7 +130,7 @@ _workout()
 	    done
 	    for ((k=1; k <= NUM_JOBS; k++))
 	    do
-		truncate -s 0 $SCRATCH_MNT/direct_aio.$k.0
+		truncate -s 0 $SCRATCH_MNT/direct_aio.$k.0 >> $seqres.full 2>&1
 	    done
 	    # Following like will check that pid is still run.
 	    # Once fio exit we can stop fallocate/truncate loop
-- 
1.8.3.1


WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <jbacik@fb.com>
To: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: [PATCH] xfstests: generic/299 can have truncate fail
Date: Thu, 30 Jan 2014 17:01:23 -0500	[thread overview]
Message-ID: <1391119283-11116-1-git-send-email-jbacik@fb.com> (raw)

So this test does lots of fallocate/truncate noise while doing aio overwrites to
try and exercise a deadlock found in ext4.  Because it runs so hard with ENOSPC
it can sometimes cause truncate to fail on btrfs.  This is ok and doesn't affect
the validity of the test, we just need to catch the output so it doesn't cause
the test to fail.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
---
 tests/generic/299 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/299 b/tests/generic/299
index 14cce96..bf02c94 100755
--- a/tests/generic/299
+++ b/tests/generic/299
@@ -130,7 +130,7 @@ _workout()
 	    done
 	    for ((k=1; k <= NUM_JOBS; k++))
 	    do
-		truncate -s 0 $SCRATCH_MNT/direct_aio.$k.0
+		truncate -s 0 $SCRATCH_MNT/direct_aio.$k.0 >> $seqres.full 2>&1
 	    done
 	    # Following like will check that pid is still run.
 	    # Once fio exit we can stop fallocate/truncate loop
-- 
1.8.3.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2014-01-30 22:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 22:01 Josef Bacik [this message]
2014-01-30 22:01 ` [PATCH] xfstests: generic/299 can have truncate fail Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391119283-11116-1-git-send-email-jbacik@fb.com \
    --to=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.