All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/23] ARM: Kirkwood: Convert mv88f6281gtw_ge switch setup to DT
Date: Sat, 15 Feb 2014 11:20:01 +0100	[thread overview]
Message-ID: <1392459621-24003-4-git-send-email-andrew@lunn.ch> (raw)
In-Reply-To: <1392459621-24003-1-git-send-email-andrew@lunn.ch>

The mv88f6281gtw_ge has a ethernet switch connected to the ethernet
port of the SoC. Convert the platform device instantiation to a DT
instantiation.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Cc: florian at openwrt.org
---
v2
Remove the spurius Module.symvers
Really do describe the switch in DT.
---
 arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 62 ++++++++++++++++++++++++++
 arch/arm/mach-kirkwood/Kconfig                 |  7 ---
 arch/arm/mach-kirkwood/Makefile                |  1 -
 arch/arm/mach-kirkwood/board-dt.c              |  3 --
 arch/arm/mach-kirkwood/board-mv88f6281gtw_ge.c | 50 ---------------------
 arch/arm/mach-kirkwood/common.h                |  7 ---
 6 files changed, 62 insertions(+), 68 deletions(-)
 delete mode 100644 arch/arm/mach-kirkwood/board-mv88f6281gtw_ge.c

diff --git a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
index dc86429756d7..2cb0dc529165 100644
--- a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
+++ b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
@@ -122,4 +122,66 @@
 			gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
 		};
 	};
+
+	dsa at 0 {
+		compatible = "marvell,dsa";
+		#address-cells = <2>;
+		#size-cells = <0>;
+
+		dsa,ethernet = <&eth0>;
+		dsa,mii-bus = <&ethphy0>;
+
+		switch at 0 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0 0>;	/* MDIO address 0, switch 0 in tree */
+
+			port at 0 {
+				reg = <0>;
+				label = "lan1";
+			};
+
+			port at 1 {
+				reg = <1>;
+				label = "lan2";
+			};
+
+			port at 2 {
+				reg = <2>;
+				label = "lan3";
+			};
+
+			port at 3 {
+				reg = <3>;
+				label = "lan4";
+			};
+
+			port at 4 {
+				reg = <4>;
+				label = "wan";
+			};
+
+			port at 5 {
+				reg = <5>;
+				label = "cpu";
+			};
+		};
+	};
+};
+
+&mdio {
+	status = "okay";
+
+	ethphy0: ethernet-phy at ff {
+		reg = <0xff>; 	/* No phy attached */
+		speed = <1000>;
+		duplex = <1>;
+	};
+};
+
+&eth0 {
+	status = "okay";
+	ethernet0-port at 0 {
+		phy-handle = <&ethphy0>;
+	};
 };
diff --git a/arch/arm/mach-kirkwood/Kconfig b/arch/arm/mach-kirkwood/Kconfig
index fe8319ad3158..df4b26340ae4 100644
--- a/arch/arm/mach-kirkwood/Kconfig
+++ b/arch/arm/mach-kirkwood/Kconfig
@@ -106,13 +106,6 @@ config ARCH_KIRKWOOD_DT
 	  Say 'Y' here if you want your kernel to support the
 	  Marvell Kirkwood using flattened device tree.
 
-config MACH_MV88F6281GTW_GE_DT
-	bool "Marvell 88F6281 GTW GE Board (Flattened Device Tree)"
-	depends on ARCH_KIRKWOOD_DT
-	help
-	  Say 'Y' here if you want your kernel to support the
-	  Marvell 88F6281 GTW GE Board (Flattened Device Tree).
-
 endmenu
 
 endif
diff --git a/arch/arm/mach-kirkwood/Makefile b/arch/arm/mach-kirkwood/Makefile
index 144b51102939..dc22bf5b21ed 100644
--- a/arch/arm/mach-kirkwood/Makefile
+++ b/arch/arm/mach-kirkwood/Makefile
@@ -13,4 +13,3 @@ obj-$(CONFIG_MACH_TS219)		+= ts219-setup.o tsx1x-common.o
 obj-$(CONFIG_MACH_TS41X)		+= ts41x-setup.o tsx1x-common.o
 
 obj-$(CONFIG_ARCH_KIRKWOOD_DT)		+= board-dt.o
-obj-$(CONFIG_MACH_MV88F6281GTW_GE_DT)	+= board-mv88f6281gtw_ge.o
diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c
index ceffdc8ffbbd..e74b31aa9736 100644
--- a/arch/arm/mach-kirkwood/board-dt.c
+++ b/arch/arm/mach-kirkwood/board-dt.c
@@ -131,9 +131,6 @@ static void __init kirkwood_dt_init(void)
 	kexec_reinit = kirkwood_enable_pcie;
 #endif
 
-	if (of_machine_is_compatible("marvell,mv88f6281gtw-ge"))
-		mv88f6281gtw_ge_init();
-
 	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
diff --git a/arch/arm/mach-kirkwood/board-mv88f6281gtw_ge.c b/arch/arm/mach-kirkwood/board-mv88f6281gtw_ge.c
deleted file mode 100644
index ee5eea678c11..000000000000
--- a/arch/arm/mach-kirkwood/board-mv88f6281gtw_ge.c
+++ /dev/null
@@ -1,50 +0,0 @@
-/*
- * arch/arm/mach-kirkwood/board-mv88f6281gtw_ge.c
- *
- * Marvell 88F6281 GTW GE Board Setup
- *
- * This file is licensed under the terms of the GNU General Public
- * License version 2.  This program is licensed "as is" without any
- * warranty of any kind, whether express or implied.
- */
-
-#include <linux/kernel.h>
-#include <linux/init.h>
-#include <linux/platform_device.h>
-#include <linux/irq.h>
-#include <linux/timer.h>
-#include <linux/mv643xx_eth.h>
-#include <linux/ethtool.h>
-#include <linux/gpio.h>
-#include <net/dsa.h>
-#include <asm/mach-types.h>
-#include <asm/mach/arch.h>
-#include <asm/mach/pci.h>
-#include <mach/kirkwood.h>
-#include "common.h"
-
-static struct mv643xx_eth_platform_data mv88f6281gtw_ge_ge00_data = {
-	.phy_addr	= MV643XX_ETH_PHY_NONE,
-	.speed		= SPEED_1000,
-	.duplex		= DUPLEX_FULL,
-};
-
-static struct dsa_chip_data mv88f6281gtw_ge_switch_chip_data = {
-	.port_names[0]	= "lan1",
-	.port_names[1]	= "lan2",
-	.port_names[2]	= "lan3",
-	.port_names[3]	= "lan4",
-	.port_names[4]	= "wan",
-	.port_names[5]	= "cpu",
-};
-
-static struct dsa_platform_data mv88f6281gtw_ge_switch_plat_data = {
-	.nr_chips	= 1,
-	.chip		= &mv88f6281gtw_ge_switch_chip_data,
-};
-
-void __init mv88f6281gtw_ge_init(void)
-{
-	kirkwood_ge00_init(&mv88f6281gtw_ge_ge00_data);
-	kirkwood_ge00_switch_init(&mv88f6281gtw_ge_switch_plat_data, NO_IRQ);
-}
diff --git a/arch/arm/mach-kirkwood/common.h b/arch/arm/mach-kirkwood/common.h
index 1296de94febf..832a4e2ab8d7 100644
--- a/arch/arm/mach-kirkwood/common.h
+++ b/arch/arm/mach-kirkwood/common.h
@@ -58,13 +58,6 @@ void kirkwood_cpufreq_init(void);
 void kirkwood_restart(enum reboot_mode, const char *);
 void kirkwood_clk_init(void);
 
-/* board init functions for boards not fully converted to fdt */
-#ifdef CONFIG_MACH_MV88F6281GTW_GE_DT
-void mv88f6281gtw_ge_init(void);
-#else
-static inline void mv88f6281gtw_ge_init(void) {};
-#endif
-
 /* early init functions not converted to fdt yet */
 char *kirkwood_id(void);
 void kirkwood_l2_init(void);
-- 
1.8.5.3

  parent reply	other threads:[~2014-02-15 10:20 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15 10:19 [PATCH v2 00/23] Move DT kirkwood into mach-mvebu Andrew Lunn
2014-02-15 10:19 ` [PATCH v2 01/23] ARM: Kirkwood: Give pm.c its own header file Andrew Lunn
2014-02-16  2:34   ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 02/23] IRQ: Orion: Fix getting generic chip pointer Andrew Lunn
2014-02-15 10:20 ` Andrew Lunn [this message]
2014-02-15 10:20 ` [PATCH v2 04/23] ARM: Kirkwood: Drop printing the SoC type and revision Andrew Lunn
2014-02-16  2:22   ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 05/23] ARM: Kirkwood: Seperate board-dt from common and pcie code Andrew Lunn
2014-02-15 13:18   ` Arnd Bergmann
2014-02-15 14:05     ` Andrew Lunn
2014-02-18 18:37       ` Jason Gunthorpe
2014-02-18 18:42         ` Andrew Lunn
2014-02-18 18:43         ` Arnd Bergmann
2014-02-15 10:20 ` [PATCH v2 06/23] ARM: Kirkwood: ioremap the cpu_config register before using it Andrew Lunn
2014-02-16  2:17   ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 07/23] ARM: Kirkwood: ioremap memory control register Andrew Lunn
2014-02-16  2:35   ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 08/23] ARM: MVEBU: Add ARCH_MULTI_V7 to SoCs Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 09/23] ARM: Orion: Move cache-feroceon-l2.h out of plat-orion Andrew Lunn
     [not found] ` <1392459621-24003-1-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2014-02-15 10:20   ` [PATCH v2 10/23] ARM: MM: Add DT binding for Feroceon L2 cache Andrew Lunn
2014-02-15 10:20     ` Andrew Lunn
     [not found]     ` <1392459621-24003-11-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2014-02-15 13:23       ` Arnd Bergmann
2014-02-15 13:23         ` Arnd Bergmann
2014-02-15 13:59         ` Andrew Lunn
2014-02-15 13:59           ` Andrew Lunn
     [not found]           ` <20140215135930.GA26088-g2DYL2Zd6BY@public.gmane.org>
2014-02-15 21:12             ` Arnd Bergmann
2014-02-15 21:12               ` Arnd Bergmann
     [not found]               ` <201402152212.02580.arnd-r2nGTMty4D4@public.gmane.org>
2014-02-15 22:39                 ` Nicolas Pitre
2014-02-15 22:39                   ` Nicolas Pitre
2014-02-17 23:38       ` Jason Cooper
2014-02-17 23:38         ` Jason Cooper
     [not found]         ` <20140217233855.GI7862-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-02-18  9:31           ` Andrew Lunn
2014-02-18  9:31             ` Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 11/23] ARM: Kirkwood: Instantiate L2 cache from DT Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 12/23] ARM: Fix default CPU selection for ARCH_MULTI_V5 Andrew Lunn
2014-02-15 20:14   ` Arnd Bergmann
2014-02-17 23:57   ` Jason Cooper
2014-02-15 10:20 ` [PATCH v2 13/23] ARM: Fix MULTI_TLB for feroceon Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 14/23] ARM: MM Enable building Feroceon L2 cache controller with ARCH_MVEBU Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 15/23] ARM: Move kirkwood DT boards into mach-mvebu Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 16/23] ARM: MVEBU: Let kirkwood use the system controller for restart Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 17/23] ARM: MVEBU: Instantiate system controller in kirkwood.dtsi Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 18/23] drivers: Enable building of Kirkwood drivers for mach-mvebu Andrew Lunn
2014-02-17 23:43   ` Jason Cooper
2014-02-15 10:20 ` [PATCH v2 19/23] ARM: MVEBU: Enable mvebu-soc-id on Kirkwood Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 20/23] ARM: config: Add a multi_v5_defconfig Andrew Lunn
2014-02-15 14:03   ` Arnd Bergmann
2014-02-17 23:46     ` Jason Cooper
2014-02-15 10:20 ` [PATCH v2 21/23] ARM: MVEBU: Simplifiy headers and make local Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 22/23] ARM: config: Add mvebu_v5_defconfig Andrew Lunn
2014-02-21  1:19   ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 23/23] ARM: Kirkwood: Remove DT support Andrew Lunn
2014-02-15 10:22 ` [PATCH v2 00/23] Move DT kirkwood into mach-mvebu Andrew Lunn
2014-02-15 14:06 ` Arnd Bergmann
2014-02-18 18:57 ` Jason Gunthorpe
2014-02-18 19:02   ` Jason Cooper
2014-02-19 22:21     ` Jason Gunthorpe
2014-02-20  9:45       ` Andrew Lunn
2014-02-20 18:18         ` Jason Gunthorpe
2014-02-20 15:04       ` Ezequiel Garcia
2014-02-21  3:19       ` Ezequiel Garcia
2014-02-21  9:37         ` Andrew Lunn
2014-02-21 17:57         ` Jason Gunthorpe
2014-02-22  1:51           ` Ezequiel Garcia
2014-02-22  3:47             ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392459621-24003-4-git-send-email-andrew@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.