All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Praznik <frank.praznik@oh.rr.com>
To: linux-input@vger.kernel.org
Cc: dh.herrmann@gmail.com, jkosina@suse.cz,
	Frank Praznik <frank.praznik@oh.rr.com>
Subject: [PATCH v2 5/5] HID: hidp: Add a comment that some devices depend on the current behavior of uniq
Date: Thu, 20 Feb 2014 11:36:04 -0500	[thread overview]
Message-ID: <1392914164-31899-6-git-send-email-frank.praznik@oh.rr.com> (raw)
In-Reply-To: <1392914164-31899-1-git-send-email-frank.praznik@oh.rr.com>

Add a comment noting that some devices depend on the destination address being
stored in uniq.

Signed-off-by: Frank Praznik <frank.praznik@oh.rr.com>
---
 net/bluetooth/hidp/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 77c4bad..98e4840 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -767,6 +767,9 @@ static int hidp_setup_hid(struct hidp_session *session,
 	snprintf(hid->phys, sizeof(hid->phys), "%pMR",
 		 &l2cap_pi(session->ctrl_sock->sk)->chan->src);
 
+	/* NOTE: Some device modules depend on the dst address being stored in
+	 * uniq. Please be aware of this before making changes to this behavior.
+	 */
 	snprintf(hid->uniq, sizeof(hid->uniq), "%pMR",
 		 &l2cap_pi(session->ctrl_sock->sk)->chan->dst);
 
-- 
1.8.5.3


  parent reply	other threads:[~2014-02-20 16:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-20 16:35 [PATCH v2 0/5] HID: sony: Various fixes and improvements for the Sony driver Frank Praznik
2014-02-20 16:36 ` [PATCH v2 1/5] HID: sony: Fix multi-line comment styling Frank Praznik
2014-02-20 16:36 ` [PATCH v2 2/5] HID: sony: Fix work queue issues Frank Praznik
2014-02-20 16:36 ` [PATCH v2 3/5] HID: sony: Perform a boundry check on the sixaxis battery level index Frank Praznik
2014-02-24 10:23   ` David Herrmann
2014-02-20 16:36 ` [PATCH v2 4/5] HID: sony: Prevent duplicate controller connections Frank Praznik
2014-02-20 16:36 ` Frank Praznik [this message]
2014-02-24 10:25 ` [PATCH v2 0/5] HID: sony: Various fixes and improvements for the Sony driver David Herrmann
2014-02-24 22:31 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392914164-31899-6-git-send-email-frank.praznik@oh.rr.com \
    --to=frank.praznik@oh.rr.com \
    --cc=dh.herrmann@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.