From: Sylwester Nawrocki <s.nawrocki@samsung.com> To: linux-media@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, mark.rutland@arm.com, galak@codeaurora.org, kyungmin.park@samsung.com, kgene.kim@samsung.com, a.hajda@samsung.com, Sylwester Nawrocki <s.nawrocki@samsung.com> Subject: [PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding Date: Thu, 20 Feb 2014 20:40:30 +0100 [thread overview] Message-ID: <1392925237-31394-5-git-send-email-s.nawrocki@samsung.com> (raw) In-Reply-To: <1392925237-31394-1-git-send-email-s.nawrocki@samsung.com> This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells property to 'camera' node - the #clock-cells property is needed when the sensor sub-devices use clock provided by the camera host interface; - addition of an optional clock-output-names property; - change of the clock-frequency at image sensor node from mandatory to an optional property - there should be no need to require this property by the camera host device binding, a default frequency value can ofen be used; - addition of a requirement of specific order of values in clocks/ clock-names properties, so the first two entry in the clock-names property can be used as parent clock names for the camera master clock provider. It happens all in-kernel dts files list the clock in such order, thus there should be no regression as far as in-kernel dts files are concerned. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> --- .../devicetree/bindings/media/samsung-fimc.txt | 36 +++++++++++++++----- 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt index 96312f6..1a5820d 100644 --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt @@ -20,6 +20,7 @@ Required properties: the clock-names property; - clock-names : must contain "sclk_cam0", "sclk_cam1", "pxl_async0", "pxl_async1" entries, matching entries in the clocks property. + First two entries must be "sclk_cam0", "sclk_cam1". The pinctrl bindings defined in ../pinctrl/pinctrl-bindings.txt must be used to define a required pinctrl state named "default" and optional pinctrl states: @@ -32,6 +33,22 @@ way around. The 'camera' node must include at least one 'fimc' child node. +Optional properties (*: + +- #clock-cells: from the common clock bindings (../clock/clock-bindings.txt), + must be 1. A clock provider is associated with the 'camera' node and it should + be referenced by external sensors that use clocks provided by the SoC on + CAM_*_CLKOUT pins. The clock specifier cell stores an index of a clock. + The indices are 0, 1 for CAM_A_CLKOUT, CAM_B_CLKOUT clocks respectively. + +- clock-output-names: from the common clock bindings, should contain names of + clocks registered by the camera subsystem corresponding to CAM_A_CLKOUT, + CAM_B_CLKOUT output clocks, in this order. Parent clock of these clocks are + specified be first two entries of the clock-names property. + +(* #clock-cells and clock-output-names are mandatory properties if external +image sensor devices reference 'camera' device node as a clock provider. + 'fimc' device nodes ------------------- @@ -97,8 +114,8 @@ Image sensor nodes The sensor device nodes should be added to their control bus controller (e.g. I2C0) nodes and linked to a port node in the csis or the parallel-ports node, using the common video interfaces bindings, defined in video-interfaces.txt. -The implementation of this bindings requires clock-frequency property to be -present in the sensor device nodes. +An optional clock-frequency property needs to be present in the sensor device +nodes. Default value when this property is not present is 24 MHz. Example: @@ -114,7 +131,7 @@ Example: vddio-supply = <...>; clock-frequency = <24000000>; - clocks = <...>; + clocks = <&camera 1>; clock-names = "mclk"; port { @@ -135,7 +152,7 @@ Example: vddio-supply = <...>; clock-frequency = <24000000>; - clocks = <...>; + clocks = <&camera 0>; clock-names = "mclk"; port { @@ -149,12 +166,15 @@ Example: camera { compatible = "samsung,fimc", "simple-bus"; - #address-cells = <1>; - #size-cells = <1>; - status = "okay"; - + clocks = <&clock 132>, <&clock 133>; + clock-names = "sclk_cam0", "sclk_cam1"; + #clock-cells = <1>; + clock-output-names = "cam_mclk_a", "cam_mclk_b"; pinctrl-names = "default"; pinctrl-0 = <&cam_port_a_clk_active>; + status = "okay"; + #address-cells = <1>; + #size-cells = <1>; /* parallel camera ports */ parallel-ports { -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding Date: Thu, 20 Feb 2014 20:40:30 +0100 [thread overview] Message-ID: <1392925237-31394-5-git-send-email-s.nawrocki@samsung.com> (raw) In-Reply-To: <1392925237-31394-1-git-send-email-s.nawrocki@samsung.com> This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells property to 'camera' node - the #clock-cells property is needed when the sensor sub-devices use clock provided by the camera host interface; - addition of an optional clock-output-names property; - change of the clock-frequency at image sensor node from mandatory to an optional property - there should be no need to require this property by the camera host device binding, a default frequency value can ofen be used; - addition of a requirement of specific order of values in clocks/ clock-names properties, so the first two entry in the clock-names property can be used as parent clock names for the camera master clock provider. It happens all in-kernel dts files list the clock in such order, thus there should be no regression as far as in-kernel dts files are concerned. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> --- .../devicetree/bindings/media/samsung-fimc.txt | 36 +++++++++++++++----- 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt index 96312f6..1a5820d 100644 --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt @@ -20,6 +20,7 @@ Required properties: the clock-names property; - clock-names : must contain "sclk_cam0", "sclk_cam1", "pxl_async0", "pxl_async1" entries, matching entries in the clocks property. + First two entries must be "sclk_cam0", "sclk_cam1". The pinctrl bindings defined in ../pinctrl/pinctrl-bindings.txt must be used to define a required pinctrl state named "default" and optional pinctrl states: @@ -32,6 +33,22 @@ way around. The 'camera' node must include at least one 'fimc' child node. +Optional properties (*: + +- #clock-cells: from the common clock bindings (../clock/clock-bindings.txt), + must be 1. A clock provider is associated with the 'camera' node and it should + be referenced by external sensors that use clocks provided by the SoC on + CAM_*_CLKOUT pins. The clock specifier cell stores an index of a clock. + The indices are 0, 1 for CAM_A_CLKOUT, CAM_B_CLKOUT clocks respectively. + +- clock-output-names: from the common clock bindings, should contain names of + clocks registered by the camera subsystem corresponding to CAM_A_CLKOUT, + CAM_B_CLKOUT output clocks, in this order. Parent clock of these clocks are + specified be first two entries of the clock-names property. + +(* #clock-cells and clock-output-names are mandatory properties if external +image sensor devices reference 'camera' device node as a clock provider. + 'fimc' device nodes ------------------- @@ -97,8 +114,8 @@ Image sensor nodes The sensor device nodes should be added to their control bus controller (e.g. I2C0) nodes and linked to a port node in the csis or the parallel-ports node, using the common video interfaces bindings, defined in video-interfaces.txt. -The implementation of this bindings requires clock-frequency property to be -present in the sensor device nodes. +An optional clock-frequency property needs to be present in the sensor device +nodes. Default value when this property is not present is 24 MHz. Example: @@ -114,7 +131,7 @@ Example: vddio-supply = <...>; clock-frequency = <24000000>; - clocks = <...>; + clocks = <&camera 1>; clock-names = "mclk"; port { @@ -135,7 +152,7 @@ Example: vddio-supply = <...>; clock-frequency = <24000000>; - clocks = <...>; + clocks = <&camera 0>; clock-names = "mclk"; port { @@ -149,12 +166,15 @@ Example: camera { compatible = "samsung,fimc", "simple-bus"; - #address-cells = <1>; - #size-cells = <1>; - status = "okay"; - + clocks = <&clock 132>, <&clock 133>; + clock-names = "sclk_cam0", "sclk_cam1"; + #clock-cells = <1>; + clock-output-names = "cam_mclk_a", "cam_mclk_b"; pinctrl-names = "default"; pinctrl-0 = <&cam_port_a_clk_active>; + status = "okay"; + #address-cells = <1>; + #size-cells = <1>; /* parallel camera ports */ parallel-ports { -- 1.7.9.5
next prev parent reply other threads:[~2014-02-20 19:40 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-20 19:40 [PATCH v4 00/10] Add device tree support for Exynos4 SoC camera subsystem Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` [PATCH v4 01/10] Documentation: dt: Add DT binding documentation for S5K6A3 image sensor Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` [PATCH v4 02/10] Documentation: dt: Add DT binding documentation for S5C73M3 camera Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-21 15:42 ` Mark Rutland 2014-02-21 15:42 ` Mark Rutland 2014-02-21 17:52 ` Sylwester Nawrocki 2014-02-21 17:52 ` Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki [this message] 2014-02-20 19:40 ` [PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding Sylwester Nawrocki 2014-02-21 15:50 ` Mark Rutland 2014-02-21 15:50 ` Mark Rutland 2014-02-22 22:02 ` Sylwester Nawrocki 2014-02-22 22:02 ` Sylwester Nawrocki 2014-02-22 22:26 ` Tomasz Figa 2014-02-22 22:26 ` Tomasz Figa 2014-02-22 22:26 ` Tomasz Figa 2014-02-22 22:52 ` Sylwester Nawrocki 2014-02-22 22:52 ` Sylwester Nawrocki [not found] ` <1392925237-31394-1-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2014-02-20 19:40 ` [PATCH v4 04/10] V4L: Add driver for s5k6a3 image sensor Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` [PATCH v4 05/10] V4L: s5c73m3: Add device tree support Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` [PATCH v4 06/10] exynos4-is: Use external s5k6a3 sensor driver Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` [PATCH v4 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-21 16:05 ` Mark Rutland 2014-02-21 16:05 ` Mark Rutland [not found] ` <20140221160504.GG20449-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> 2014-02-22 22:18 ` Sylwester Nawrocki 2014-02-22 22:18 ` Sylwester Nawrocki 2014-02-22 22:18 ` Sylwester Nawrocki 2014-02-20 19:40 ` [PATCH v4 08/10] exynos4-is: Add support for asynchronous subdevices registration Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` [PATCH v4 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki 2014-02-20 19:40 ` [PATCH v4 10/10] ARM: dts: exynos4: Update clk provider part of the camera subsystem Sylwester Nawrocki 2014-02-20 19:40 ` Sylwester Nawrocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1392925237-31394-5-git-send-email-s.nawrocki@samsung.com \ --to=s.nawrocki@samsung.com \ --cc=a.hajda@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=kgene.kim@samsung.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.