All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
	viro@zeniv.linux.org.uk
Cc: linux-nfs@vger.kernel.org, trond.myklebust@primarydata.com,
	ceph-devel@vger.kernel.org, sage@inktank.com
Subject: [PATCH][RESEND] vfs: Make __d_materialise_dentry() set the materialised dentry name correctly
Date: Thu,  6 Mar 2014 22:16:16 +0800	[thread overview]
Message-ID: <1394115376-17109-1-git-send-email-zheng.z.yan@intel.com> (raw)

From: David Howells <dhowells@redhat.com>

Make __d_materialise_dentry() set the materialised dentry name correctly by
flipping the arguments to switch_names().

switch_names() is lazy: if both names are internal to their dentries, it'll
overwrite that of the first dentry with that of the second, and won't update
that of the second.

In the case of __d_materialise_dentry(), the second is an already extant
anonymous dentry that we want to insert into the tree in place of the dentry we
just looked up[*].  However, the dentry we just looked up carries the name we
actually want to use.

[*] This is used by NFS to join a mount of a subtree into a mount of a tree
nearer the root when the two meet, where both mounts share a superblock and
thus a set of dentries.

Signed-off-by: David Howells <dhowells@redhat.com>
---
 fs/dcache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index 265e0ce..ff779d4 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2698,7 +2698,7 @@ static void __d_materialise_dentry(struct dentry *dentry, struct dentry *anon)
 
 	dparent = dentry->d_parent;
 
-	switch_names(dentry, anon);
+	switch_names(anon, dentry);
 	swap(dentry->d_name.hash, anon->d_name.hash);
 
 	dentry->d_parent = dentry;
-- 
1.8.5.3


             reply	other threads:[~2014-03-06 14:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06 14:16 Yan, Zheng [this message]
2014-03-06 14:35 ` [PATCH][RESEND] vfs: Make __d_materialise_dentry() set the materialised dentry name correctly Trond Myklebust
2014-03-06 14:35   ` Trond Myklebust
2014-03-07 18:55   ` J. Bruce Fields
2014-03-07 18:55     ` J. Bruce Fields
     [not found]     ` <20140307185552.GA30256-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2014-03-07 19:01       ` J. Bruce Fields
2014-03-07 19:01         ` J. Bruce Fields
2014-03-31  9:01   ` Yan, Zheng
2014-03-31  9:01     ` Yan, Zheng
     [not found]     ` <53392EDA.7000904-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-07 13:56       ` Sage Weil
2014-04-07 13:56         ` Sage Weil
2014-04-07 20:51         ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394115376-17109-1-git-send-email-zheng.z.yan@intel.com \
    --to=zheng.z.yan@intel.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=dhowells@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=sage@inktank.com \
    --cc=trond.myklebust@primarydata.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.