All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 02/20] drm/i915: also use GEN5_IRQ_INIT with south display interrupts
Date: Fri,  7 Mar 2014 20:10:18 -0300	[thread overview]
Message-ID: <1394233836-3827-3-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1394233836-3827-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

This interrupt gets initialized with a different IER value, so it was
not using the macro. The problem is that we plan to modify the macro
to make it do additional things, and we want the SDE interrupts
updated too. So let's make sure we call the macro, then, after it, we
do the necessary SDE-specific changes.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 30c44fb..852844d 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2771,8 +2771,7 @@ static void ibx_irq_preinstall(struct drm_device *dev)
 	if (HAS_PCH_NOP(dev))
 		return;
 
-	/* south display irq */
-	I915_WRITE(SDEIMR, 0xffffffff);
+	GEN5_IRQ_INIT(SDE);
 	/*
 	 * SDEIER is also touched by the interrupt handler to work around missed
 	 * PCH interrupts. Hence we can't update it after the interrupt handler
-- 
1.8.5.3

  parent reply	other threads:[~2014-03-07 23:11 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 23:10 [PATCH 00/20] ILK+ interrupt improvements, v2 Paulo Zanoni
2014-03-07 23:10 ` [PATCH 01/20] drm/i915: add GEN5_IRQ_INIT macro Paulo Zanoni
2014-03-07 23:10 ` Paulo Zanoni [this message]
2014-03-07 23:10 ` [PATCH 03/20] drm/i915: use GEN8_IRQ_INIT on GEN5 Paulo Zanoni
2014-03-18 17:11   ` Ben Widawsky
2014-03-18 17:41     ` Daniel Vetter
2014-03-26 20:00     ` Paulo Zanoni
2014-03-26 21:37       ` Daniel Vetter
2014-03-27 12:06         ` Paulo Zanoni
2014-03-07 23:10 ` [PATCH 04/20] drm/i915: add GEN5_IRQ_FINI Paulo Zanoni
2014-03-07 23:10 ` [PATCH 05/20] drm/i915: don't forget to uninstall the PM IRQs Paulo Zanoni
2014-03-18 17:59   ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 06/20] drm/i915: properly clear IIR at irq_uninstall on Gen5+ Paulo Zanoni
2014-03-11  8:25   ` Chris Wilson
2014-03-18 17:20   ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 07/20] drm/i915: add GEN5_IRQ_INIT Paulo Zanoni
2014-03-18 18:16   ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 08/20] drm/i915: check if IIR is still zero at postinstall on Gen5+ Paulo Zanoni
2014-03-18 18:20   ` Ben Widawsky
2014-03-19  8:28     ` Daniel Vetter
2014-03-19 17:50       ` Ben Widawsky
2014-03-27 13:34         ` Paulo Zanoni
2014-03-07 23:10 ` [PATCH 09/20] drm/i915: fix SERR_INT init/reset code Paulo Zanoni
2014-03-18 18:24   ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 10/20] drm/i915: fix GEN7_ERR_INT " Paulo Zanoni
2014-03-18 19:42   ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 11/20] drm/i915: fix open coded gen5_gt_irq_preinstall Paulo Zanoni
2014-03-07 23:10 ` [PATCH 12/20] drm/i915: extract ibx_irq_uninstall Paulo Zanoni
2014-03-07 23:10 ` [PATCH 13/20] drm/i915: call ibx_irq_uninstall from gen8_irq_uninstall Paulo Zanoni
2014-03-07 23:10 ` [PATCH 14/20] drm/i915: enable SDEIER later Paulo Zanoni
2014-03-18 20:29   ` Ben Widawsky
2014-03-27 14:39     ` Paulo Zanoni
2014-03-28  6:20       ` Ben Widawsky
2014-03-28  7:41         ` Daniel Vetter
2014-03-07 23:10 ` [PATCH 15/20] drm/i915: remove ibx_irq_uninstall Paulo Zanoni
2014-03-07 23:10 ` [PATCH 16/20] drm/i915: add missing intel_hpd_irq_uninstall Paulo Zanoni
2014-03-18 20:38   ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 17/20] drm/i915: add ironlake_irq_reset Paulo Zanoni
2014-03-07 23:10 ` [PATCH 18/20] drm/i915: add gen8_irq_reset Paulo Zanoni
2014-03-18 20:43   ` Ben Widawsky
2014-03-27 14:48     ` Paulo Zanoni
2014-03-07 23:10 ` [PATCH 19/20] drm/i915: only enable HWSTAM interrupts on postinstall on ILK+ Paulo Zanoni
2014-03-07 23:10 ` [PATCH 20/20] drm/i915: add POSTING_READs to the IRQ init/reset macros Paulo Zanoni
2014-03-18 20:45   ` Ben Widawsky
2014-03-18 20:53 ` [PATCH 00/20] ILK+ interrupt improvements, v2 Ben Widawsky
2014-03-19  8:36   ` Daniel Vetter
2014-03-19 17:25     ` Ben Widawsky
2014-03-26 20:33       ` Paulo Zanoni
2014-03-26 20:54         ` Ben Widawsky
2014-03-26 21:35           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394233836-3827-3-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.