All of lore.kernel.org
 help / color / mirror / Atom feed
From: Min Chen <minchen@ubuntukylin.com>
To: ceph-devel@vger.kernel.org
Cc: josh.durgin@inktank.com,
	Yunchuan Wen <yunchuanwen@ubuntukylin.com>,
	Li Wang <liwang@ubuntukylin.com>
Subject: [PATCH 0/2] rbd: copy-on-read for clones, add an option for copy-on-read
Date: Thu, 27 Mar 2014 08:38:16 +0800	[thread overview]
Message-ID: <1395880698-20479-1-git-send-email-minchen@ubuntukylin.com> (raw)

Add an option rbd_clone_cor to enable copy-on-read

Signed-off-by: Min Chen <minchen@ubuntukylin.com>
Signed-off-by: Yunchuan Wen <yunchuanwen@ubuntukylin.com>
Signed-off-by: Li Wang <liwang@ubuntukylin.com>
---
 src/common/config_opts.h |    1 +
 src/librbd/AioRequest.cc |    1 +
 2 files changed, 2 insertions(+)

diff --git a/src/common/config_opts.h b/src/common/config_opts.h
index 0d03809..99167b0 100644
--- a/src/common/config_opts.h
+++ b/src/common/config_opts.h
@@ -620,6 +620,7 @@ OPTION(rbd_cache_block_writes_upfront, OPT_BOOL, false) // whether to block writ
 OPTION(rbd_concurrent_management_ops, OPT_INT, 10) // how many operations can be in flight for a management operation like deleting or resizing an image
 OPTION(rbd_balance_snap_reads, OPT_BOOL, false)
 OPTION(rbd_localize_snap_reads, OPT_BOOL, false)
+OPTION(rbd_clone_cor, OPT_BOOL, false)//copy-on-read option for rbd clones
 
 /*
  * The following options change the behavior for librbd's image creation methods that
diff --git a/src/librbd/AioRequest.cc b/src/librbd/AioRequest.cc
index 11e111f..e8fb657 100644
--- a/src/librbd/AioRequest.cc
+++ b/src/librbd/AioRequest.cc
@@ -59,6 +59,7 @@ namespace librbd {
     ldout(m_ictx->cct, 20) << "should_complete " << this << " " << m_oid << " " << m_object_off << "~" << m_object_len
 			   << " r = " << r << dendl;
 
+    bool COR = m_ictx->cct->_conf->rbd_clone_cor;
     if (!m_tried_parent && r == -ENOENT) {
       RWLock::RLocker l(m_ictx->snap_lock);
       RWLock::RLocker l2(m_ictx->parent_lock);
-- 
1.7.10.4


             reply	other threads:[~2014-03-27  0:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27  0:38 Min Chen [this message]
2014-03-27  0:38 ` [PATCH 1/2] rbd: copy-on-read for clones, read entire object from parent Min Chen
2014-03-27  0:38 ` [PATCH 2/2] rbd: copy-on-read for clones, write entire object into child by cls_rbd copyup Min Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395880698-20479-1-git-send-email-minchen@ubuntukylin.com \
    --to=minchen@ubuntukylin.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=josh.durgin@inktank.com \
    --cc=liwang@ubuntukylin.com \
    --cc=yunchuanwen@ubuntukylin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.