All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <dan.j.williams@intel.com>, <vinod.koul@intel.com>, <nsekhar@ti.com>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<joelf@ti.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-omap@vger.kernel.org>,
	<davinci-linux-open-source@linux.davincidsp.com>,
	<mporter@linaro.org>
Subject: [PATCH v2 12/14] dma: edma: Prefix debug prints where the text were identical in prep callbacks
Date: Tue, 1 Apr 2014 16:06:13 +0300	[thread overview]
Message-ID: <1396357575-30585-13-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1396357575-30585-1-git-send-email-peter.ujfalusi@ti.com>

prep_slave_sg and prep_dma_cyclic callbacks have mostly same failure cases
with the same texts printed in case we hit them. It helps when debugging if
we know exactly which callback generated the errors.
At the same time change the debug level for descriptor allocation failure
from dbg to err since all other error cases are dev_err and this failure is
similarly fatal as the other ones.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/dma/edma.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index e8de2e84a60a..7feb6231276e 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -434,14 +434,14 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
 	}
 
 	if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
-		dev_err(dev, "Undefined slave buswidth\n");
+		dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
 		return NULL;
 	}
 
 	edesc = kzalloc(sizeof(*edesc) + sg_len *
 		sizeof(edesc->pset[0]), GFP_ATOMIC);
 	if (!edesc) {
-		dev_dbg(dev, "Failed to allocate a descriptor\n");
+		dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
 		return NULL;
 	}
 
@@ -457,7 +457,8 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
 						EDMA_SLOT_ANY);
 			if (echan->slot[i] < 0) {
 				kfree(edesc);
-				dev_err(dev, "Failed to allocate slot\n");
+				dev_err(dev, "%s: Failed to allocate slot\n",
+					__func__);
 				return NULL;
 			}
 		}
@@ -526,7 +527,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
 	}
 
 	if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
-		dev_err(dev, "Undefined slave buswidth\n");
+		dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
 		return NULL;
 	}
 
@@ -551,7 +552,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
 	edesc = kzalloc(sizeof(*edesc) + nslots *
 		sizeof(edesc->pset[0]), GFP_ATOMIC);
 	if (!edesc) {
-		dev_dbg(dev, "Failed to allocate a descriptor\n");
+		dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
 		return NULL;
 	}
 
@@ -569,7 +570,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
 						EDMA_SLOT_ANY);
 			if (echan->slot[i] < 0) {
 				kfree(edesc);
-				dev_err(dev, "Failed to allocate slot\n");
+				dev_err(dev, "%s: Failed to allocate slot\n",
+					__func__);
 				return NULL;
 			}
 		}
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: dan.j.williams@intel.com, vinod.koul@intel.com, nsekhar@ti.com
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	joelf@ti.com, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org,
	davinci-linux-open-source@linux.davincidsp.com,
	mporter@linaro.org
Subject: [PATCH v2 12/14] dma: edma: Prefix debug prints where the text were identical in prep callbacks
Date: Tue, 1 Apr 2014 16:06:13 +0300	[thread overview]
Message-ID: <1396357575-30585-13-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1396357575-30585-1-git-send-email-peter.ujfalusi@ti.com>

prep_slave_sg and prep_dma_cyclic callbacks have mostly same failure cases
with the same texts printed in case we hit them. It helps when debugging if
we know exactly which callback generated the errors.
At the same time change the debug level for descriptor allocation failure
from dbg to err since all other error cases are dev_err and this failure is
similarly fatal as the other ones.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/dma/edma.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index e8de2e84a60a..7feb6231276e 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -434,14 +434,14 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
 	}
 
 	if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
-		dev_err(dev, "Undefined slave buswidth\n");
+		dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
 		return NULL;
 	}
 
 	edesc = kzalloc(sizeof(*edesc) + sg_len *
 		sizeof(edesc->pset[0]), GFP_ATOMIC);
 	if (!edesc) {
-		dev_dbg(dev, "Failed to allocate a descriptor\n");
+		dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
 		return NULL;
 	}
 
@@ -457,7 +457,8 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
 						EDMA_SLOT_ANY);
 			if (echan->slot[i] < 0) {
 				kfree(edesc);
-				dev_err(dev, "Failed to allocate slot\n");
+				dev_err(dev, "%s: Failed to allocate slot\n",
+					__func__);
 				return NULL;
 			}
 		}
@@ -526,7 +527,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
 	}
 
 	if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
-		dev_err(dev, "Undefined slave buswidth\n");
+		dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
 		return NULL;
 	}
 
@@ -551,7 +552,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
 	edesc = kzalloc(sizeof(*edesc) + nslots *
 		sizeof(edesc->pset[0]), GFP_ATOMIC);
 	if (!edesc) {
-		dev_dbg(dev, "Failed to allocate a descriptor\n");
+		dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
 		return NULL;
 	}
 
@@ -569,7 +570,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
 						EDMA_SLOT_ANY);
 			if (echan->slot[i] < 0) {
 				kfree(edesc);
-				dev_err(dev, "Failed to allocate slot\n");
+				dev_err(dev, "%s: Failed to allocate slot\n",
+					__func__);
 				return NULL;
 			}
 		}
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 12/14] dma: edma: Prefix debug prints where the text were identical in prep callbacks
Date: Tue, 1 Apr 2014 16:06:13 +0300	[thread overview]
Message-ID: <1396357575-30585-13-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1396357575-30585-1-git-send-email-peter.ujfalusi@ti.com>

prep_slave_sg and prep_dma_cyclic callbacks have mostly same failure cases
with the same texts printed in case we hit them. It helps when debugging if
we know exactly which callback generated the errors.
At the same time change the debug level for descriptor allocation failure
from dbg to err since all other error cases are dev_err and this failure is
similarly fatal as the other ones.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/dma/edma.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index e8de2e84a60a..7feb6231276e 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -434,14 +434,14 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
 	}
 
 	if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
-		dev_err(dev, "Undefined slave buswidth\n");
+		dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
 		return NULL;
 	}
 
 	edesc = kzalloc(sizeof(*edesc) + sg_len *
 		sizeof(edesc->pset[0]), GFP_ATOMIC);
 	if (!edesc) {
-		dev_dbg(dev, "Failed to allocate a descriptor\n");
+		dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
 		return NULL;
 	}
 
@@ -457,7 +457,8 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
 						EDMA_SLOT_ANY);
 			if (echan->slot[i] < 0) {
 				kfree(edesc);
-				dev_err(dev, "Failed to allocate slot\n");
+				dev_err(dev, "%s: Failed to allocate slot\n",
+					__func__);
 				return NULL;
 			}
 		}
@@ -526,7 +527,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
 	}
 
 	if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
-		dev_err(dev, "Undefined slave buswidth\n");
+		dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
 		return NULL;
 	}
 
@@ -551,7 +552,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
 	edesc = kzalloc(sizeof(*edesc) + nslots *
 		sizeof(edesc->pset[0]), GFP_ATOMIC);
 	if (!edesc) {
-		dev_dbg(dev, "Failed to allocate a descriptor\n");
+		dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
 		return NULL;
 	}
 
@@ -569,7 +570,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
 						EDMA_SLOT_ANY);
 			if (echan->slot[i] < 0) {
 				kfree(edesc);
-				dev_err(dev, "Failed to allocate slot\n");
+				dev_err(dev, "%s: Failed to allocate slot\n",
+					__func__);
 				return NULL;
 			}
 		}
-- 
1.9.1

  parent reply	other threads:[~2014-04-01 13:07 UTC|newest]

Thread overview: 132+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 13:06 [PATCH v2 00/14] dma: edma: Fixes for cyclic (audio) operation Peter Ujfalusi
2014-04-01 13:06 ` Peter Ujfalusi
2014-04-01 13:06 ` Peter Ujfalusi
2014-04-01 13:06 ` [PATCH v2 01/14] platform_data: edma: Be precise with the paRAM struct Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06 ` [PATCH v2 02/14] dma: edma: Correct the handling of src/dst_maxburst == 0 Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06 ` [PATCH v2 03/14] dma: edma: Add support for DMA_PAUSE/RESUME operation Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-11 16:43   ` Vinod Koul
2014-04-11 16:43     ` Vinod Koul
2014-04-11 20:51     ` Joel Fernandes
2014-04-11 20:51       ` Joel Fernandes
2014-04-11 20:51       ` Joel Fernandes
2014-04-01 13:06 ` [PATCH v2 04/14] dma: edma: Set DMA_CYCLIC capability flag Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06 ` [PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-10 16:23   ` Joel Fernandes
2014-04-10 16:23     ` Joel Fernandes
2014-04-10 16:23     ` Joel Fernandes
2014-04-11  8:17   ` Sekhar Nori
2014-04-11  8:17     ` Sekhar Nori
2014-04-11  8:17     ` Sekhar Nori
2014-04-11  8:50     ` Peter Ujfalusi
2014-04-11  8:50       ` Peter Ujfalusi
2014-04-11  8:50       ` Peter Ujfalusi
2014-04-11  8:56       ` Sekhar Nori
2014-04-11  8:56         ` Sekhar Nori
2014-04-11  8:56         ` Sekhar Nori
2014-04-11  9:38         ` Peter Ujfalusi
2014-04-11  9:38           ` Peter Ujfalusi
2014-04-11  9:38           ` Peter Ujfalusi
2014-04-11  9:42           ` Vinod Koul
2014-04-11  9:42             ` Vinod Koul
2014-04-11  9:42             ` Vinod Koul
2014-04-11 10:19             ` Sekhar Nori
2014-04-11 10:19               ` Sekhar Nori
2014-04-11 10:19               ` Sekhar Nori
2014-04-11 11:32             ` Peter Ujfalusi
2014-04-11 11:32               ` Peter Ujfalusi
2014-04-11 11:32               ` Peter Ujfalusi
2014-04-11 11:31               ` Vinod Koul
2014-04-11 11:31                 ` Vinod Koul
2014-04-11 12:23                 ` Peter Ujfalusi
2014-04-11 12:23                   ` Peter Ujfalusi
2014-04-11 12:23                   ` Peter Ujfalusi
2014-04-11 12:46                   ` Vinod Koul
2014-04-11 12:46                     ` Vinod Koul
2014-04-11 12:46                     ` Vinod Koul
2014-04-14 11:56                     ` Peter Ujfalusi
2014-04-14 11:56                       ` Peter Ujfalusi
2014-04-14 11:56                       ` Peter Ujfalusi
2014-04-14 12:12                       ` Sekhar Nori
2014-04-14 12:12                         ` Sekhar Nori
2014-04-14 12:12                         ` Sekhar Nori
2014-04-14 12:41                         ` Peter Ujfalusi
2014-04-14 12:41                           ` Peter Ujfalusi
2014-04-14 12:41                           ` Peter Ujfalusi
2014-04-14 14:32                           ` Sekhar Nori
2014-04-14 14:32                             ` Sekhar Nori
2014-04-14 14:32                             ` Sekhar Nori
2014-04-16 12:59                             ` Peter Ujfalusi
2014-04-16 12:59                               ` Peter Ujfalusi
2014-04-16 12:59                               ` Peter Ujfalusi
2014-04-16 16:05                               ` Joel Fernandes
2014-04-16 16:05                                 ` Joel Fernandes
2014-04-16 16:05                                 ` Joel Fernandes
2014-04-24  9:07                                 ` Peter Ujfalusi
2014-04-24  9:07                                   ` Peter Ujfalusi
2014-04-24  9:07                                   ` Peter Ujfalusi
2014-04-11 20:16             ` Joel Fernandes
2014-04-11 20:16               ` Joel Fernandes
2014-04-11 20:16               ` Joel Fernandes
2014-04-01 13:06 ` [PATCH v2 06/14] arm: common: edma: Save the number of event queues/TCs Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06 ` [PATCH v2 07/14] arm: common: edma: API to request non default queue for a channel Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-11  8:43   ` Sekhar Nori
2014-04-11  8:43     ` Sekhar Nori
2014-04-11  8:43     ` Sekhar Nori
2014-04-01 13:06 ` [PATCH v2 08/14] DMA: edma: Use different eventq for cyclic channels Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-10 16:36   ` Joel Fernandes
2014-04-10 16:36     ` Joel Fernandes
2014-04-10 16:36     ` Joel Fernandes
2014-04-11 16:47     ` Vinod Koul
2014-04-11 16:47       ` Vinod Koul
2014-04-11 16:47       ` Vinod Koul
2014-04-11 20:56       ` Joel Fernandes
2014-04-11 20:56         ` Joel Fernandes
2014-04-11 20:56         ` Joel Fernandes
2014-04-01 13:06 ` [PATCH v2 09/14] dma: edma: Implement device_slave_caps callback Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06 ` [PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset() Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-10 22:40   ` Joel Fernandes
2014-04-10 22:40     ` Joel Fernandes
2014-04-10 22:40     ` Joel Fernandes
2014-04-11  6:39     ` Peter Ujfalusi
2014-04-11  6:39       ` Peter Ujfalusi
2014-04-11  6:39       ` Peter Ujfalusi
2014-04-11 19:57       ` Joel Fernandes
2014-04-11 19:57         ` Joel Fernandes
2014-04-11 19:57         ` Joel Fernandes
2014-04-01 13:06 ` [PATCH v2 11/14] dma: edma: Reduce debug print verbosity for non verbose debugging Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06 ` Peter Ujfalusi [this message]
2014-04-01 13:06   ` [PATCH v2 12/14] dma: edma: Prefix debug prints where the text were identical in prep callbacks Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06 ` [PATCH v2 13/14] dma: edma: Add channel number to debug prints Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06 ` [PATCH v2 14/14] dma: edma: Print the direction value as well when it is not supported Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-01 13:06   ` Peter Ujfalusi
2014-04-10 22:52 ` [PATCH v2 00/14] dma: edma: Fixes for cyclic (audio) operation Joel Fernandes
2014-04-10 22:52   ` Joel Fernandes
2014-04-10 22:52   ` Joel Fernandes
2014-04-11 16:52 ` Vinod Koul
2014-04-11 16:52   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396357575-30585-13-git-send-email-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=dan.j.williams@intel.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=joelf@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mporter@linaro.org \
    --cc=nsekhar@ti.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.