All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rahul Sharma <rahul.sharma@samsung.com>
To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org
Cc: inki.dae@samsung.com, r.sh.open@gmail.com, joshi@samsung.com,
	Rahul Sharma <rahul.sharma@samsung.com>
Subject: [PATCH 3/5] drm/exynos: remove unnecessary read for phy configuration values
Date: Wed, 02 Apr 2014 22:43:44 +0530	[thread overview]
Message-ID: <1396458826-3051-4-git-send-email-rahul.sharma@samsung.com> (raw)
In-Reply-To: <1396458826-3051-1-git-send-email-rahul.sharma@samsung.com>

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Cleaning up unnecessary i2c read call after hdmiphy configuration.
This check is redundant since check for hdmiphy pll lock status
confirms the correct settings for phy.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
---
 drivers/gpu/drm/exynos/exynos_hdmi.c |   10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 47b8c06..5b2cfe7 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -1518,7 +1518,6 @@ static void hdmiphy_conf_apply(struct hdmi_context *hdata)
 	const u8 *hdmiphy_data;
 	u8 buffer[32];
 	u8 operation[2];
-	u8 read_buffer[32] = {0, };
 	int ret;
 	int i;
 
@@ -1558,15 +1557,6 @@ static void hdmiphy_conf_apply(struct hdmi_context *hdata)
 		return;
 	}
 
-	ret = i2c_master_recv(hdata->hdmiphy_port, read_buffer, 32);
-	if (ret < 0) {
-		DRM_ERROR("failed to read hdmiphy config\n");
-		return;
-	}
-
-	for (i = 0; i < ret; i++)
-		DRM_DEBUG_KMS("hdmiphy[0x%02x] write[0x%02x] - "
-			"recv [0x%02x]\n", i, buffer[i], read_buffer[i]);
 }
 
 static void hdmi_conf_apply(struct hdmi_context *hdata)
-- 
1.7.9.5

  parent reply	other threads:[~2014-04-02 17:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02 17:13 [PATCH 0/5] drm/exynos: enable support for exynos5420 hdmi Rahul Sharma
2014-04-02 17:13 ` [PATCH 1/5] drm/exynos: remove dummy hdmiphy clock from hdmi driver Rahul Sharma
2014-04-10 15:32   ` Tomasz Figa
2014-04-11  1:49     ` Rahul Sharma
2014-04-02 17:13 ` [PATCH 2/5] drm/exynos: use regmap interface to set hdmiphy control bit in pmu Rahul Sharma
2014-04-03 15:53   ` Inki Dae
2014-04-04  2:21     ` Rahul Sharma
2014-04-10 17:00   ` Tomasz Figa
2014-04-11  1:52     ` Rahul Sharma
2014-05-19  7:29       ` Rahul Sharma
2014-04-02 17:13 ` Rahul Sharma [this message]
2014-04-10 17:02   ` [PATCH 3/5] drm/exynos: remove unnecessary read for phy configuration values Tomasz Figa
2014-04-02 17:13 ` [PATCH 4/5] drm/exynos: add support for apb mapped phys in hdmi driver Rahul Sharma
2014-04-10 17:17   ` Tomasz Figa
2014-04-11  2:36     ` Rahul Sharma
2014-04-02 17:13 ` [PATCH 5/5] drm/exynos: enable support for exynos5420 hdmi device Rahul Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396458826-3051-4-git-send-email-rahul.sharma@samsung.com \
    --to=rahul.sharma@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=joshi@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=r.sh.open@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.