From: <hongbo.zhang@freescale.com> To: <vkoul@infradead.org>, <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org> Cc: <scottwood@freescale.com>, <leo.li@freescale.com>, <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>, Hongbo Zhang <hongbo.zhang@freescale.com> Subject: [PATCH v3 1/8] DMA: Freescale: remove the unnecessary FSL_DMA_LD_DEBUG Date: Thu, 10 Apr 2014 15:09:58 +0800 [thread overview] Message-ID: <1397113805-24171-2-git-send-email-hongbo.zhang@freescale.com> (raw) In-Reply-To: <1397113805-24171-1-git-send-email-hongbo.zhang@freescale.com> From: Hongbo Zhang <hongbo.zhang@freescale.com> Some codes are calling chan_dbg with FSL_DMA_LD_DEBUG surrounded, it is really unnecessary to use such a macro because chan_dbg is a wrapper of dev_dbg, we do have corresponding DEBUG macro to switch on/off dev_dbg, and most of the other codes are also calling chan_dbg directly without using FSL_DMA_LD_DEBUG. Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com> --- drivers/dma/fsldma.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index f157c6f..ec50420 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -426,9 +426,7 @@ static struct fsl_desc_sw *fsl_dma_alloc_descriptor(struct fsldma_chan *chan) desc->async_tx.tx_submit = fsl_dma_tx_submit; desc->async_tx.phys = pdesc; -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p allocated\n", desc); -#endif return desc; } @@ -479,9 +477,7 @@ static void fsldma_free_desc_list(struct fsldma_chan *chan, list_for_each_entry_safe(desc, _desc, list, node) { list_del(&desc->node); -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p free\n", desc); -#endif dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys); } } @@ -493,9 +489,7 @@ static void fsldma_free_desc_list_reverse(struct fsldma_chan *chan, list_for_each_entry_safe_reverse(desc, _desc, list, node) { list_del(&desc->node); -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p free\n", desc); -#endif dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys); } } @@ -832,9 +826,7 @@ static void fsldma_cleanup_descriptor(struct fsldma_chan *chan, /* Run the link descriptor callback function */ if (txd->callback) { -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p callback\n", desc); -#endif txd->callback(txd->callback_param); } @@ -842,9 +834,7 @@ static void fsldma_cleanup_descriptor(struct fsldma_chan *chan, dma_run_dependencies(txd); dma_descriptor_unmap(txd); -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p free\n", desc); -#endif dma_pool_free(chan->desc_pool, desc, txd->phys); } -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: <hongbo.zhang@freescale.com> To: <vkoul@infradead.org>, <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org> Cc: scottwood@freescale.com, Hongbo Zhang <hongbo.zhang@freescale.com>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, leo.li@freescale.com Subject: [PATCH v3 1/8] DMA: Freescale: remove the unnecessary FSL_DMA_LD_DEBUG Date: Thu, 10 Apr 2014 15:09:58 +0800 [thread overview] Message-ID: <1397113805-24171-2-git-send-email-hongbo.zhang@freescale.com> (raw) In-Reply-To: <1397113805-24171-1-git-send-email-hongbo.zhang@freescale.com> From: Hongbo Zhang <hongbo.zhang@freescale.com> Some codes are calling chan_dbg with FSL_DMA_LD_DEBUG surrounded, it is really unnecessary to use such a macro because chan_dbg is a wrapper of dev_dbg, we do have corresponding DEBUG macro to switch on/off dev_dbg, and most of the other codes are also calling chan_dbg directly without using FSL_DMA_LD_DEBUG. Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com> --- drivers/dma/fsldma.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index f157c6f..ec50420 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -426,9 +426,7 @@ static struct fsl_desc_sw *fsl_dma_alloc_descriptor(struct fsldma_chan *chan) desc->async_tx.tx_submit = fsl_dma_tx_submit; desc->async_tx.phys = pdesc; -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p allocated\n", desc); -#endif return desc; } @@ -479,9 +477,7 @@ static void fsldma_free_desc_list(struct fsldma_chan *chan, list_for_each_entry_safe(desc, _desc, list, node) { list_del(&desc->node); -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p free\n", desc); -#endif dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys); } } @@ -493,9 +489,7 @@ static void fsldma_free_desc_list_reverse(struct fsldma_chan *chan, list_for_each_entry_safe_reverse(desc, _desc, list, node) { list_del(&desc->node); -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p free\n", desc); -#endif dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys); } } @@ -832,9 +826,7 @@ static void fsldma_cleanup_descriptor(struct fsldma_chan *chan, /* Run the link descriptor callback function */ if (txd->callback) { -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p callback\n", desc); -#endif txd->callback(txd->callback_param); } @@ -842,9 +834,7 @@ static void fsldma_cleanup_descriptor(struct fsldma_chan *chan, dma_run_dependencies(txd); dma_descriptor_unmap(txd); -#ifdef FSL_DMA_LD_DEBUG chan_dbg(chan, "LD %p free\n", desc); -#endif dma_pool_free(chan->desc_pool, desc, txd->phys); } -- 1.7.9.5
next prev parent reply other threads:[~2014-04-10 7:10 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-10 7:09 [PATCH v3 0/8] DMA: Freescale: driver cleanups and enhancements hongbo.zhang 2014-04-10 7:09 ` hongbo.zhang 2014-04-10 7:09 ` hongbo.zhang [this message] 2014-04-10 7:09 ` [PATCH v3 1/8] DMA: Freescale: remove the unnecessary FSL_DMA_LD_DEBUG hongbo.zhang 2014-04-10 7:20 ` [PATCH v3 0/8] DMA: Freescale: driver cleanups and enhancements Hongbo Zhang 2014-04-10 7:20 ` Hongbo Zhang 2014-04-10 7:09 ` [PATCH v3 2/8] DMA: Freescale: unify register access methods hongbo.zhang 2014-04-10 7:09 ` hongbo.zhang 2014-04-10 8:46 ` David Laight 2014-04-10 8:46 ` David Laight 2014-04-10 9:33 ` Hongbo Zhang 2014-04-10 7:10 ` [PATCH v3 3/8] DMA: Freescale: remove attribute DMA_INTERRUPT of dmaengine hongbo.zhang 2014-04-10 7:10 ` hongbo.zhang 2014-04-10 7:10 ` [PATCH v3 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication hongbo.zhang 2014-04-10 7:10 ` hongbo.zhang 2014-04-10 11:29 ` Andy Shevchenko 2014-04-10 11:29 ` Andy Shevchenko 2014-04-11 8:14 ` Hongbo Zhang 2014-04-11 8:14 ` Hongbo Zhang 2014-04-14 13:40 ` Andy Shevchenko 2014-04-14 13:40 ` Andy Shevchenko 2014-04-18 4:09 ` Hongbo Zhang 2014-04-18 4:09 ` Hongbo Zhang 2014-04-10 7:10 ` [PATCH v3 5/8] DMA: Freescale: move functions to avoid forward declarations hongbo.zhang 2014-04-10 7:10 ` hongbo.zhang 2014-04-10 7:10 ` [PATCH v3 6/8] DMA: Freescale: change descriptor release process for supporting async_tx hongbo.zhang 2014-04-10 7:10 ` hongbo.zhang 2014-04-10 11:56 ` Andy Shevchenko 2014-04-10 11:56 ` Andy Shevchenko 2014-04-11 8:00 ` Hongbo Zhang 2014-04-11 8:00 ` Hongbo Zhang 2014-04-11 8:33 ` Hongbo Zhang 2014-04-11 8:33 ` Hongbo Zhang 2014-04-14 13:41 ` Andy Shevchenko 2014-04-14 13:41 ` Andy Shevchenko 2014-04-10 7:10 ` [PATCH v3 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave hongbo.zhang 2014-04-10 7:10 ` hongbo.zhang 2014-04-10 7:10 ` [PATCH v3 8/8] DMA: Freescale: add suspend resume functions for DMA driver hongbo.zhang 2014-04-10 7:10 ` hongbo.zhang 2014-04-10 12:05 ` Andy Shevchenko 2014-04-10 12:05 ` Andy Shevchenko 2014-04-11 7:42 ` Hongbo Zhang 2014-04-11 7:42 ` Hongbo Zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1397113805-24171-2-git-send-email-hongbo.zhang@freescale.com \ --to=hongbo.zhang@freescale.com \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=leo.li@freescale.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=scottwood@freescale.com \ --cc=vkoul@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.