All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	"John W. Linville" <linville@tuxdriver.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Arnd Bergmann <arnd@arndb.de>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	linux-gpio@vger.kernel.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sunxi@googlegroups.com
Subject: [PATCH 6/7] net: rfkill: gpio: add clock-frequency device tree property
Date: Tue, 15 Apr 2014 14:41:40 +0800	[thread overview]
Message-ID: <1397544101-18135-7-git-send-email-wens@csie.org> (raw)
In-Reply-To: <1397544101-18135-1-git-send-email-wens@csie.org>

Some devices, such as Broadcom Bluetooth devices, require a specific
clock rate for the clock tied to the rfkill device. Add a clock-frequency
property so we can specify this from the device tree.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt | 2 ++
 net/rfkill/rfkill-gpio.c                                 | 5 +++++
 2 files changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
index a23da65..67b5edb 100644
--- a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
+++ b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
@@ -11,6 +11,7 @@ Required properties:
 
 Optional properties:
 - clocks		: phandle to clock to enable/disable
+- clock-frequency	: desired clock rate for the given clock
 
 Example:
 
@@ -21,4 +22,5 @@ Example:
 		gpios = <&pio 7 18 0>;
 		gpio-names = "reset";
 		clocks = <&clk_out_a>;
+		clock-frequency = <32678>;
 	};
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index a174359..14ac8c1 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -38,6 +38,7 @@ struct rfkill_gpio_data {
 
 	struct rfkill		*rfkill_dev;
 	struct clk		*clk;
+	uint32_t		clk_frequency;
 
 	bool			clk_enabled;
 };
@@ -90,6 +91,7 @@ static int rfkill_gpio_dt_probe(struct device *dev,
 	rfkill->name = np->name;
 	of_property_read_string(np, "rfkill-name", &rfkill->name);
 	of_property_read_u32(np, "rfkill-type", &rfkill->type);
+	of_property_read_u32(np, "clock-frequency", &rfkill->clk_frequency);
 
 	return 0;
 }
@@ -122,6 +124,9 @@ static int rfkill_gpio_probe(struct platform_device *pdev)
 
 	rfkill->clk = devm_clk_get(&pdev->dev, NULL);
 
+	if (!IS_ERR(rfkill->clk) && rfkill->clk_frequency > 0)
+		clk_set_rate(rfkill->clk, rfkill->clk_frequency);
+
 	gpio = devm_gpiod_get_index(&pdev->dev, "reset", 0);
 	if (!IS_ERR(gpio)) {
 		ret = gpiod_direction_output(gpio, 0);
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	"John W. Linville"
	<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Heikki Krogerus
	<heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Mika Westerberg
	<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Alexandre Courbot
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: [PATCH 6/7] net: rfkill: gpio: add clock-frequency device tree property
Date: Tue, 15 Apr 2014 14:41:40 +0800	[thread overview]
Message-ID: <1397544101-18135-7-git-send-email-wens@csie.org> (raw)
In-Reply-To: <1397544101-18135-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>

Some devices, such as Broadcom Bluetooth devices, require a specific
clock rate for the clock tied to the rfkill device. Add a clock-frequency
property so we can specify this from the device tree.

Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
---
 Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt | 2 ++
 net/rfkill/rfkill-gpio.c                                 | 5 +++++
 2 files changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
index a23da65..67b5edb 100644
--- a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
+++ b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
@@ -11,6 +11,7 @@ Required properties:
 
 Optional properties:
 - clocks		: phandle to clock to enable/disable
+- clock-frequency	: desired clock rate for the given clock
 
 Example:
 
@@ -21,4 +22,5 @@ Example:
 		gpios = <&pio 7 18 0>;
 		gpio-names = "reset";
 		clocks = <&clk_out_a>;
+		clock-frequency = <32678>;
 	};
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index a174359..14ac8c1 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -38,6 +38,7 @@ struct rfkill_gpio_data {
 
 	struct rfkill		*rfkill_dev;
 	struct clk		*clk;
+	uint32_t		clk_frequency;
 
 	bool			clk_enabled;
 };
@@ -90,6 +91,7 @@ static int rfkill_gpio_dt_probe(struct device *dev,
 	rfkill->name = np->name;
 	of_property_read_string(np, "rfkill-name", &rfkill->name);
 	of_property_read_u32(np, "rfkill-type", &rfkill->type);
+	of_property_read_u32(np, "clock-frequency", &rfkill->clk_frequency);
 
 	return 0;
 }
@@ -122,6 +124,9 @@ static int rfkill_gpio_probe(struct platform_device *pdev)
 
 	rfkill->clk = devm_clk_get(&pdev->dev, NULL);
 
+	if (!IS_ERR(rfkill->clk) && rfkill->clk_frequency > 0)
+		clk_set_rate(rfkill->clk, rfkill->clk_frequency);
+
 	gpio = devm_gpiod_get_index(&pdev->dev, "reset", 0);
 	if (!IS_ERR(gpio)) {
 		ret = gpiod_direction_output(gpio, 0);
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] net: rfkill: gpio: add clock-frequency device tree property
Date: Tue, 15 Apr 2014 14:41:40 +0800	[thread overview]
Message-ID: <1397544101-18135-7-git-send-email-wens@csie.org> (raw)
In-Reply-To: <1397544101-18135-1-git-send-email-wens@csie.org>

Some devices, such as Broadcom Bluetooth devices, require a specific
clock rate for the clock tied to the rfkill device. Add a clock-frequency
property so we can specify this from the device tree.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt | 2 ++
 net/rfkill/rfkill-gpio.c                                 | 5 +++++
 2 files changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
index a23da65..67b5edb 100644
--- a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
+++ b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
@@ -11,6 +11,7 @@ Required properties:
 
 Optional properties:
 - clocks		: phandle to clock to enable/disable
+- clock-frequency	: desired clock rate for the given clock
 
 Example:
 
@@ -21,4 +22,5 @@ Example:
 		gpios = <&pio 7 18 0>;
 		gpio-names = "reset";
 		clocks = <&clk_out_a>;
+		clock-frequency = <32678>;
 	};
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index a174359..14ac8c1 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -38,6 +38,7 @@ struct rfkill_gpio_data {
 
 	struct rfkill		*rfkill_dev;
 	struct clk		*clk;
+	uint32_t		clk_frequency;
 
 	bool			clk_enabled;
 };
@@ -90,6 +91,7 @@ static int rfkill_gpio_dt_probe(struct device *dev,
 	rfkill->name = np->name;
 	of_property_read_string(np, "rfkill-name", &rfkill->name);
 	of_property_read_u32(np, "rfkill-type", &rfkill->type);
+	of_property_read_u32(np, "clock-frequency", &rfkill->clk_frequency);
 
 	return 0;
 }
@@ -122,6 +124,9 @@ static int rfkill_gpio_probe(struct platform_device *pdev)
 
 	rfkill->clk = devm_clk_get(&pdev->dev, NULL);
 
+	if (!IS_ERR(rfkill->clk) && rfkill->clk_frequency > 0)
+		clk_set_rate(rfkill->clk, rfkill->clk_frequency);
+
 	gpio = devm_gpiod_get_index(&pdev->dev, "reset", 0);
 	if (!IS_ERR(gpio)) {
 		ret = gpiod_direction_output(gpio, 0);
-- 
1.9.1

  parent reply	other threads:[~2014-04-15  7:22 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15  6:41 [PATCH 0/7] net: rfkill: gpio: Add device tree support Chen-Yu Tsai
2014-04-15  6:41 ` Chen-Yu Tsai
2014-04-15  6:41 ` Chen-Yu Tsai
2014-04-15  6:41 ` [PATCH 1/7] gpiolib: gpiolib-of: Implement device tree gpio-names based lookup Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15 14:20   ` Maxime Ripard
2014-04-15 14:20     ` Maxime Ripard
2014-04-15 14:20     ` Maxime Ripard
2014-04-16  6:12     ` Alexandre Courbot
2014-04-16  6:12       ` Alexandre Courbot
2014-04-16  6:12       ` Alexandre Courbot
2014-04-16  6:12       ` Alexandre Courbot
2014-04-16  7:06       ` Alexandre Courbot
2014-04-16  7:06         ` Alexandre Courbot
2014-04-16  7:06         ` Alexandre Courbot
2014-04-16  7:06         ` Alexandre Courbot
2014-04-16  9:56         ` Chen-Yu Tsai
2014-04-16  9:56           ` Chen-Yu Tsai
2014-04-16  9:56           ` Chen-Yu Tsai
2014-04-16  9:56           ` Chen-Yu Tsai
2014-04-22 15:02   ` Linus Walleij
2014-04-22 15:02     ` Linus Walleij
2014-04-22 15:02     ` Linus Walleij
2014-04-22 15:02     ` Linus Walleij
2014-04-23  1:49     ` Alexandre Courbot
2014-04-23  1:49       ` Alexandre Courbot
2014-04-23  1:49       ` Alexandre Courbot
2014-04-23  1:49       ` Alexandre Courbot
2014-04-28 16:19       ` [linux-sunxi] " Chen-Yu Tsai
2014-04-28 16:19         ` Chen-Yu Tsai
2014-04-28 16:19         ` Chen-Yu Tsai
2014-04-28 16:19         ` Chen-Yu Tsai
2014-04-15  6:41 ` [PATCH 2/7] gpiolib: Support purely name based gpiod lookup in device trees Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-22 15:00   ` Linus Walleij
2014-04-22 15:00     ` Linus Walleij
2014-04-22 15:00     ` Linus Walleij
2014-04-22 15:00     ` Linus Walleij
2014-04-22 15:18     ` Maxime Ripard
2014-04-22 15:18       ` Maxime Ripard
2014-04-22 15:18       ` Maxime Ripard
2014-04-22 15:18       ` Maxime Ripard
2014-04-23 13:55       ` Linus Walleij
2014-04-23 13:55         ` Linus Walleij
2014-04-23 13:55         ` Linus Walleij
2014-04-23 13:55         ` Linus Walleij
2014-04-15  6:41 ` [PATCH 3/7] net: rfkill: gpio: use clk_prepare_enable/clk_disable_unprepare Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15 14:26   ` Maxime Ripard
2014-04-15 14:26     ` Maxime Ripard
2014-04-15  6:41 ` [PATCH 4/7] net: rfkill: gpio: fix reversed clock enable state Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15 14:27   ` Maxime Ripard
2014-04-15 14:27     ` Maxime Ripard
2014-04-15 14:27     ` Maxime Ripard
2014-04-15  6:41 ` [PATCH 5/7] net: rfkill: gpio: add device tree support Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15 21:00   ` Stephen Warren
2014-04-15 21:00     ` Stephen Warren
2014-04-15 21:01   ` Stephen Warren
2014-04-15 21:01     ` Stephen Warren
2014-04-15  6:41 ` Chen-Yu Tsai [this message]
2014-04-15  6:41   ` [PATCH 6/7] net: rfkill: gpio: add clock-frequency device tree property Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15 14:44   ` Maxime Ripard
2014-04-15 14:44     ` Maxime Ripard
2014-04-15 14:44     ` Maxime Ripard
2014-04-15  6:41 ` [PATCH 7/7] ARM: sun7i: cubietruck: enable bluetooth module Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15  6:41   ` Chen-Yu Tsai
2014-04-15 14:42   ` Maxime Ripard
2014-04-15 14:42     ` Maxime Ripard
2014-04-15 14:42     ` Maxime Ripard
2014-04-15 16:06     ` [linux-sunxi] " Chen-Yu Tsai
2014-04-15 16:06       ` Chen-Yu Tsai
2014-04-15 16:06       ` Chen-Yu Tsai
2014-04-15 16:18       ` [linux-sunxi] " One Thousand Gnomes
2014-04-15 16:18         ` One Thousand Gnomes
2014-04-16  9:44       ` Maxime Ripard
2014-04-16  9:44         ` Maxime Ripard
2014-04-16  9:44         ` Maxime Ripard
2014-04-16 10:39         ` [linux-sunxi] " Chen-Yu Tsai
2014-04-16 10:39           ` Chen-Yu Tsai
2014-04-16 10:39           ` Chen-Yu Tsai
     [not found]           ` <CAGb2v67HzB22a3huRRZyufXkdTFE410MhXqAHyC-MmVo0-GCFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-16 13:09             ` Hans de Goede
2014-04-16 13:09               ` [linux-sunxi] " Hans de Goede
2014-04-16 13:09               ` Hans de Goede
     [not found]               ` <534E8102.4070404-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-17  7:43                 ` Arend van Spriel
2014-04-17  7:43                   ` [linux-sunxi] " Arend van Spriel
2014-04-17  7:43                   ` Arend van Spriel
2014-04-18 17:49                   ` [linux-sunxi] " maxime.ripard
2014-04-18 17:49                     ` maxime.ripard
2014-04-18 17:49                     ` maxime.ripard
2014-04-18 17:49                     ` maxime.ripard
2014-04-18 17:47           ` [linux-sunxi] " maxime.ripard
2014-04-18 17:47             ` maxime.ripard
2014-04-18 17:47             ` maxime.ripard
2014-04-16 13:08         ` [linux-sunxi] " Hans de Goede
2014-04-16 13:08           ` Hans de Goede
2014-04-16 13:08           ` Hans de Goede
2014-04-22 15:06 ` [PATCH 0/7] net: rfkill: gpio: Add device tree support Johannes Berg
2014-04-22 15:06   ` Johannes Berg
2014-04-22 15:06   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397544101-18135-7-git-send-email-wens@csie.org \
    --to=wens@csie.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.