All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Yang <liyang.fnst@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Cc: Li Yang <liyang.fnst@cn.fujitsu.com>
Subject: [PATCH] Btrfs-progs: mkfs: Remove 'zero_end =1' since it has been set to a value
Date: Mon, 21 Apr 2014 05:38:08 -0400	[thread overview]
Message-ID: <1398073088-40489-1-git-send-email-liyang.fnst@cn.fujitsu.com> (raw)

In utils.c, zero_end is used as a parameter, should not force it to 1.
In mkfs.c, zero_end is set to 1 or 0(-b) at the beginning, should not
force it to 1 unconditionally.

Signed-off-by: Li Yang <liyang.fnst@cn.fujitsu.com>
---
 mkfs.c  |    1 -
 utils.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mkfs.c b/mkfs.c
index dbd83f5..f2b5779 100644
--- a/mkfs.c
+++ b/mkfs.c
@@ -1543,7 +1543,6 @@ int main(int ac, char **av)
 
 	btrfs_register_one_device(file);
 
-	zero_end = 1;
 	while (dev_cnt-- > 0) {
 		int old_mixed = mixed;
 
diff --git a/utils.c b/utils.c
index 0bfb9d9..db5fdb3 100644
--- a/utils.c
+++ b/utils.c
@@ -616,7 +616,6 @@ int btrfs_prepare_device(int fd, char *file, int zero_end, u64 *block_count_ret,
 	}
 	if (max_block_count)
 		block_count = min(block_count, max_block_count);
-	zero_end = 1;
 
 	if (block_count < 1024 * 1024 * 1024 && !(*mixed)) {
 		printf("SMALL VOLUME: forcing mixed metadata/data groups\n");
-- 
1.7.1


                 reply	other threads:[~2014-04-21  9:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398073088-40489-1-git-send-email-liyang.fnst@cn.fujitsu.com \
    --to=liyang.fnst@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.