All of lore.kernel.org
 help / color / mirror / Atom feed
From: srinivas.kandagatla@linaro.org
To: Russell King <linux@arm.linux.org.uk>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org
Cc: Chris Ball <chris@printf.net>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linus.walleij@linaro.org,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH v4 10/13] mmc: mmci: Add support to data commands via variant structure.
Date: Wed, 28 May 2014 14:47:33 +0100	[thread overview]
Message-ID: <1401284853-16853-1-git-send-email-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <1401284608-16428-1-git-send-email-srinivas.kandagatla@linaro.org>

From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

On some SOCs like Qcom there are explicit bits in the command register
to specify if its a data transfer command or not. So this patch adds
support to such bits in variant data, giving more flexibility to the
driver.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/mmc/host/mmci.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index dbcb952..fd40f9a 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -59,6 +59,7 @@ static unsigned int fmax = 515633;
  *	      is asserted (likewise for RX)
  * @fifohalfsize: number of bytes that can be written when MCI_TXFIFOHALFEMPTY
  *		  is asserted (likewise for RX)
+ * @data_cmd_enable: enable value for data commands.
  * @sdio: variant supports SDIO
  * @st_clkdiv: true if using a ST-specific clock divider algorithm
  * @datactrl_mask_ddrmode: ddr mode mask in datactrl register.
@@ -79,6 +80,7 @@ struct variant_data {
 	unsigned int		datalength_bits;
 	unsigned int		fifosize;
 	unsigned int		fifohalfsize;
+	unsigned int		data_cmd_enable;
 	unsigned int		datactrl_mask_ddrmode;
 	bool			sdio;
 	bool			st_clkdiv;
@@ -183,6 +185,7 @@ static struct variant_data variant_qcom = {
 				  MCI_QCOM_CLK_SELECT_IN_FBCLK,
 	.clkreg_8bit_bus_enable = MCI_QCOM_CLK_WIDEBUS_8,
 	.datactrl_mask_ddrmode	= MCI_QCOM_CLK_SELECT_IN_DDR_MODE,
+	.data_cmd_enable	= MCI_QCOM_CSPM_DATCMD,
 	.blksz_datactrl4	= true,
 	.datalength_bits	= 24,
 	.pwrreg_powerup		= MCI_PWR_UP,
@@ -852,6 +855,9 @@ mmci_start_command(struct mmci_host *host, struct mmc_command *cmd, u32 c)
 	if (/*interrupt*/0)
 		c |= MCI_CPSM_INTERRUPT;
 
+	if (mmc_cmd_type(cmd) == MMC_CMD_ADTC)
+		c |= host->variant->data_cmd_enable;
+
 	host->cmd = cmd;
 
 	writel(cmd->arg, base + MMCIARGUMENT);
-- 
1.9.1

  parent reply	other threads:[~2014-05-28 13:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-28 13:43 [PATCH v4 00/13] Add Qualcomm SD Card Controller support srinivas.kandagatla
2014-05-28 13:45 ` [PATCH v4 01/13] mmc: mmci: use NSEC_PER_SEC macro srinivas.kandagatla
2014-05-28 13:46 ` [PATCH v4 02/13] mmc: mmci: convert register bits to use BIT() macro srinivas.kandagatla
2014-05-28 13:46 ` [PATCH v4 03/13] mmc: mmci: Add Qualcomm Id to amba id table srinivas.kandagatla
2014-05-30  9:39   ` Ulf Hansson
2014-05-30  9:49     ` Srinivas Kandagatla
2014-05-28 13:46 ` [PATCH v4 04/13] mmc: mmci: Add enough delay between writes to CMD register srinivas.kandagatla
2014-05-28 13:46 ` [PATCH v4 05/13] mmc: mmci: Add Qcom datactrl register variant srinivas.kandagatla
2014-05-28 13:46 ` [PATCH v4 06/13] mmc: mmci: add ddrmode mask to variant data srinivas.kandagatla
2014-05-30  9:35   ` Ulf Hansson
2014-05-30  9:50     ` Srinivas Kandagatla
2014-05-28 13:47 ` [PATCH v4 07/13] mmc: mmci: add 8bit bus support in " srinivas.kandagatla
2014-05-28 13:47 ` [PATCH v4 08/13] mmc: mmci: add edge support to data and command out " srinivas.kandagatla
2014-05-28 13:47 ` [PATCH v4 09/13] mmc: mmci: add Qcom specifics of clk and datactrl registers srinivas.kandagatla
2014-05-30  9:55   ` Ulf Hansson
2014-05-30  9:59     ` Srinivas Kandagatla
2014-05-28 13:47 ` srinivas.kandagatla [this message]
2014-05-28 13:47 ` [PATCH v4 11/13] mmc: mmci: add f_max to variant structure srinivas.kandagatla
2014-05-30 10:28   ` Ulf Hansson
2014-05-30 10:29     ` Srinivas Kandagatla
2014-05-28 13:47 ` [PATCH v4 12/13] mmc: mmci: add explicit clk control srinivas.kandagatla
2014-05-30 10:25   ` Ulf Hansson
2014-05-30 10:39     ` Srinivas Kandagatla
2014-05-28 13:48 ` [PATCH v4 13/13] mmc: mmci: Add Qcom specific pio_read function srinivas.kandagatla
2014-05-30 11:27   ` Ulf Hansson
2014-05-30 11:44     ` Srinivas Kandagatla
2014-05-30 16:20       ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401284853-16853-1-git-send-email-srinivas.kandagatla@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=chris@printf.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.