All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
To: linux-arm-kernel@lists.infradead.org,
	spi-devel-general@lists.sourceforge.net,
	linux-samsung-soc@vger.kernel.org
Cc: naveenkrishna.ch@gmail.com, broonie@kernel.org,
	grant.likely@secretlab.ca, jaswinder.singh@linaro.org,
	kgene.kim@samsung.com, cpgs@samsung.com,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Doug Anderson <dianders@chromium.org>
Subject: [PATCH 2/3] spi: s3c64xx: remove a compilation warning with an assignment
Date: Tue, 10 Jun 2014 14:30:58 +0530	[thread overview]
Message-ID: <1402390859-28287-3-git-send-email-ch.naveen@samsung.com> (raw)
In-Reply-To: <1402390859-28287-1-git-send-email-ch.naveen@samsung.com>

This patch returns an integer error value instead of the
pointer.

"warning: return makes integer from pointer without a cast"

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Doug Anderson <dianders@chromium.org>
---
 drivers/spi/spi-s3c64xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 0c6013f..4594dde 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -817,7 +817,7 @@ static int s3c64xx_spi_setup(struct spi_device *spi)
 
 	if (!spi->dev.of_node) {
 		dev_err(&spi->dev, "device node not found\n");
-		return ERR_PTR(-EINVAL);
+		return -EINVAL;
 	}
 
 	sdd = spi_master_get_devdata(spi->master);
-- 
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: ch.naveen@samsung.com (Naveen Krishna Chatradhi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] spi: s3c64xx: remove a compilation warning with an assignment
Date: Tue, 10 Jun 2014 14:30:58 +0530	[thread overview]
Message-ID: <1402390859-28287-3-git-send-email-ch.naveen@samsung.com> (raw)
In-Reply-To: <1402390859-28287-1-git-send-email-ch.naveen@samsung.com>

This patch returns an integer error value instead of the
pointer.

"warning: return makes integer from pointer without a cast"

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Doug Anderson <dianders@chromium.org>
---
 drivers/spi/spi-s3c64xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 0c6013f..4594dde 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -817,7 +817,7 @@ static int s3c64xx_spi_setup(struct spi_device *spi)
 
 	if (!spi->dev.of_node) {
 		dev_err(&spi->dev, "device node not found\n");
-		return ERR_PTR(-EINVAL);
+		return -EINVAL;
 	}
 
 	sdd = spi_master_get_devdata(spi->master);
-- 
1.7.9.5

  parent reply	other threads:[~2014-06-10  9:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10  9:00 [PATCH 0/3] spi: s3c64xx: use "cs-gpios" in spi node instead of "cs-gpio" Naveen Krishna Chatradhi
2014-06-10  9:00 ` Naveen Krishna Chatradhi
2014-06-10  9:00 ` [PATCH 1/3] spi: s3c64xx: use "cs-gpios" from " Naveen Krishna Chatradhi
2014-06-10  9:00   ` Naveen Krishna Chatradhi
2014-06-10  9:48   ` Naveen Krishna Ch
2014-06-10  9:48     ` Naveen Krishna Ch
2014-06-10  9:00 ` Naveen Krishna Chatradhi [this message]
2014-06-10  9:00   ` [PATCH 2/3] spi: s3c64xx: remove a compilation warning with an assignment Naveen Krishna Chatradhi
2014-06-10  9:45   ` Sachin Kamat
2014-06-10  9:45     ` Sachin Kamat
2014-06-10  9:53     ` Naveen Krishna Ch
2014-06-10  9:53       ` Naveen Krishna Ch
2014-06-10  9:00 ` [PATCH 3/3] ARM: DTS: move "cs-gpio" from "controller-data" to under spi node Naveen Krishna Chatradhi
2014-06-10  9:00   ` Naveen Krishna Chatradhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402390859-28287-3-git-send-email-ch.naveen@samsung.com \
    --to=ch.naveen@samsung.com \
    --cc=broonie@kernel.org \
    --cc=cpgs@samsung.com \
    --cc=dianders@chromium.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jaswinder.singh@linaro.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=naveenkrishna.ch@gmail.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.