All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: alsa-devel@alsa-project.org
Cc: vinod.koul@intel.com, broonie@kernel.org,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
	lgirdwood@gmail.com, Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH v2 04/13] ASoC: intel: mfld-pcm: don't call trigger ops to DSP for internal streams
Date: Thu, 10 Jul 2014 10:14:48 +0530	[thread overview]
Message-ID: <1404967497-22537-5-git-send-email-subhransu.s.prusty@intel.com> (raw)
In-Reply-To: <1404967497-22537-1-git-send-email-subhransu.s.prusty@intel.com>

From: Vinod Koul <vinod.koul@intel.com>

For internal stream i.e. BE we have don't need trigger ops as that would be
handled by DAPM for us in subsequent patches

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
---
 sound/soc/intel/sst-mfld-platform-pcm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/intel/sst-mfld-platform-pcm.c b/sound/soc/intel/sst-mfld-platform-pcm.c
index f0923561226e..e5607cf198dc 100644
--- a/sound/soc/intel/sst-mfld-platform-pcm.c
+++ b/sound/soc/intel/sst-mfld-platform-pcm.c
@@ -527,6 +527,8 @@ static int sst_platform_pcm_trigger(struct snd_pcm_substream *substream,
 	int str_cmd, status;
 
 	pr_debug("sst_platform_pcm_trigger called\n");
+	if (substream->pcm->internal)
+		return 0;
 	stream = substream->runtime->private_data;
 	str_id = stream->stream_info.str_id;
 	switch (cmd) {
-- 
1.9.0

  parent reply	other threads:[~2014-07-10  5:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10  4:44 [PATCH v2 00/13] add mrfld DSP support Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 01/13] ASoC: Export dapm_kcontrol_get_value Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 02/13] ASoC: Intel: mfld-pcm: add FE and BE ops Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 03/13] ASoC: Intel: mrfld: set private data for cpu-dai Subhransu S. Prusty
2014-07-10  4:44 ` Subhransu S. Prusty [this message]
2014-07-10  4:44 ` [PATCH v2 05/13] ASoC: Intel: add generic parameter set interface Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 06/13] ASoC: Intel: add mrfld DSP defines Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 07/13] ASoC: Intel: mrfld: add bytes control for modules Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 08/13] ASoC: Intel: mrfld: add the gain controls Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 09/13] ASoC: Intel: mfld-pcm: add control for powering up/down dsp Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 10/13] ASoC: Intel: mrfld: add DSP core controls Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 11/13] ASoC: Intel: mrfld: add the DSP DAPM widgets Subhransu S. Prusty
2014-07-18 12:19   ` Mark Brown
2014-07-18 14:26     ` Vinod Koul
2014-07-24  6:18       ` Vinod Koul
2014-07-24 11:50         ` Mark Brown
2014-07-25  5:46           ` Vinod Koul
2014-07-10  4:44 ` [PATCH v2 12/13] ASoC: Intel: mfld-pcm: add the fe & be dai ops Subhransu S. Prusty
2014-07-10  4:44 ` [PATCH v2 13/13] ASoC: Intel: mrfld: add the DSP mixers Subhransu S. Prusty
2014-07-14 18:50 ` [PATCH v2 00/13] add mrfld DSP support Mark Brown
2014-07-15  5:24   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404967497-22537-5-git-send-email-subhransu.s.prusty@intel.com \
    --to=subhransu.s.prusty@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.