All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: alsa-devel@alsa-project.org
Cc: broonie@kernel.org, Arnd Bergmann <arnd@arndb.de>,
	lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org,
	Jianqun Xu <xjq@rock-chips.com>
Subject: [PATCH] ASoC: rockchips: fix build error
Date: Fri, 11 Jul 2014 15:07:08 +0200	[thread overview]
Message-ID: <1405084028-1209898-1-git-send-email-arnd@arndb.de> (raw)

The newly added rockchip_i2s driver is lacking an include of
linux/module.h, causing a build error in some cases:

../sound/soc/rockchip/rockchip_i2s.c:526:20: error: expected declaration specifiers or '...' before string constant
 MODULE_DESCRIPTION("ROCKCHIP IIS ASoC Interface");

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Jianqun Xu <xjq@rock-chips.com>
---
 sound/soc/rockchip/rockchip_i2s.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index af1d8eb94f04..c3e53feba5b9 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -13,6 +13,7 @@
 #include <linux/delay.h>
 #include <linux/of_gpio.h>
 #include <linux/clk.h>
+#include <linux/module.h>
 #include <linux/pm_runtime.h>
 #include <linux/regmap.h>
 #include <sound/pcm_params.h>
-- 
1.8.3.2

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: rockchips: fix build error
Date: Fri, 11 Jul 2014 15:07:08 +0200	[thread overview]
Message-ID: <1405084028-1209898-1-git-send-email-arnd@arndb.de> (raw)

The newly added rockchip_i2s driver is lacking an include of
linux/module.h, causing a build error in some cases:

../sound/soc/rockchip/rockchip_i2s.c:526:20: error: expected declaration specifiers or '...' before string constant
 MODULE_DESCRIPTION("ROCKCHIP IIS ASoC Interface");

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Jianqun Xu <xjq@rock-chips.com>
---
 sound/soc/rockchip/rockchip_i2s.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index af1d8eb94f04..c3e53feba5b9 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -13,6 +13,7 @@
 #include <linux/delay.h>
 #include <linux/of_gpio.h>
 #include <linux/clk.h>
+#include <linux/module.h>
 #include <linux/pm_runtime.h>
 #include <linux/regmap.h>
 #include <sound/pcm_params.h>
-- 
1.8.3.2

             reply	other threads:[~2014-07-11 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 13:07 Arnd Bergmann [this message]
2014-07-11 13:07 ` [PATCH] ASoC: rockchips: fix build error Arnd Bergmann
2014-07-11 13:48 ` Mark Brown
2014-07-11 13:48   ` Mark Brown
2014-07-12  0:59   ` Jianqun
2014-07-12  0:59     ` Jianqun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405084028-1209898-1-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=xjq@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.