All of lore.kernel.org
 help / color / mirror / Atom feed
From: clinton.a.taylor@intel.com
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH 02/11] CHROMIUM: drm/i915: do not explicitly disable backlight in panel_off
Date: Wed, 16 Jul 2014 14:49:38 -0700	[thread overview]
Message-ID: <1405547387-14051-3-git-send-email-clinton.a.taylor@intel.com> (raw)
In-Reply-To: <1405547387-14051-1-git-send-email-clinton.a.taylor@intel.com>

From: Jesse Barnes <jbarnes@virtuousgeek.org>

Per eDP spec, we must disable the backlight in order to power down the
panel. However, in our code, we have always disabled the backlight
before we try to turn off the panel. The assertions from the previous
patch make sure this is the case.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Wayne Boyer <wayne.boyer@intel.com>

Change-Id: I68ae4ee80cee40aa4745697ce7acf3883ffb721d
Reviewed-on: https://chromium-review.googlesource.com/194250
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: Wayne Boyer <wayne.boyer@intel.com>
Commit-Queue: Wayne Boyer <wayne.boyer@intel.com>

Conflicts:
	drivers/gpu/drm/i915/intel_dp.c
---
 drivers/gpu/drm/i915/intel_dp.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 90b24f6..9242499 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1371,8 +1371,7 @@ void intel_edp_panel_off(struct intel_dp *intel_dp)
 	pp = ironlake_get_pp_control(intel_dp);
 	/* We need to switch off panel power _and_ force vdd, for otherwise some
 	 * panels get very unhappy and cease to work. */
-	pp &= ~(POWER_TARGET_ON | PANEL_POWER_RESET | EDP_FORCE_VDD |
-		EDP_BLC_ENABLE);
+	pp &= ~(POWER_TARGET_ON | EDP_FORCE_VDD | PANEL_POWER_RESET);
 
 	pp_ctrl_reg = _pp_ctrl_reg(intel_dp);
 
-- 
1.7.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2014-07-16 21:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 21:49 [PATCH 00/11] drm/i915: backlight scaling and timing changes from chromium clinton.a.taylor
2014-07-16 21:49 ` [PATCH 01/11] CHROMIUM: drm/i915: add backlight assertion funcs for PWM status clinton.a.taylor
2014-07-16 21:49 ` clinton.a.taylor [this message]
2014-07-16 21:49 ` [PATCH 03/11] CHROMIUM: drm/i915: use backlight wrapper functions instead of direct calls clinton.a.taylor
2014-07-16 21:49 ` [PATCH 04/11] CHROMIUM: drm/i915/vlv: Initialize pipe B backlight to A's value clinton.a.taylor
2014-07-16 21:49 ` [PATCH 05/11] CHROMIUM: drm/i915: parse backlight modulation frequency from the BIOS VBT clinton.a.taylor
2014-07-16 21:49 ` [PATCH 06/11] CHROMIUM: drm/i915: Provide valleyview backlight fallback value clinton.a.taylor
2014-07-16 21:49 ` [PATCH 07/11] CHROMIUM: drm/i915/vlv: Scale backlight to min duty ratio clinton.a.taylor
2014-07-16 21:49 ` [PATCH 08/11] CHROMIUM: drm/i915/vlv: Check BLC enable for pwm invariant clinton.a.taylor
2014-07-16 21:49 ` [PATCH 09/11] CHROMIUM: drm/i915: change order of PWM enable vs BLC enable clinton.a.taylor
2014-07-16 21:49 ` [PATCH 10/11] CHROMIUM: drm/i915/vlv: Fix BLM_PWM_ENABLE check in pwm invariant clinton.a.taylor
2014-07-16 21:49 ` [PATCH 11/11] CHROMIUM: drm/i915/vlv: Prefer VBT to set PWM clinton.a.taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405547387-14051-3-git-send-email-clinton.a.taylor@intel.com \
    --to=clinton.a.taylor@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.