All of lore.kernel.org
 help / color / mirror / Atom feed
From: prakash.burla@smartplayin.com
To: srinivas.kandagatla@linaro.org
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linus.walleij@linaro.org
Subject: RE: Fwd: [PATCH v6 12/12] mmc: mmci: Add Qualcomm Id to amba id table
Date: Thu, 17 Jul 2014 04:31:32 -0400 (EDT)	[thread overview]
Message-ID: <1405585892.574323701@apps.rackspace.com> (raw)
In-Reply-To: <CA+neC=PRkUqcL63yNkvJNgRQqvQ+c+1g+qptM7vXH5c9-b5UDw@mail.gmail.com>

tested-by: Prakash Burla <prakash.burla@smartplayin.com>
This driver tested on AP806X with mmc Driver.
--------------------------------------------------------------------
From:  <srinivas.kandagatla@linaro.org>
Date: Mon, Jun 2, 2014 at 2:40 PM
Subject: [PATCH v6 12/12] mmc: mmci: Add Qualcomm Id to amba id table
To: Russell King <linux@arm.linux.org.uk>, Ulf Hansson
<ulf.hansson@linaro.org>, linux-mmc@vger.kernel.org
Cc: Chris Ball <chris@printf.net>, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linus.walleij@linaro.org, Srinivas
Kandagatla <srinivas.kandagatla@linaro.org>


From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

This patch adds a fake Qualcomm ID 0x00051180 to the amba_ids, as Qualcomm
SDCC controller is pl180, but amba id registers read 0x0's.
The plan is to remove SDCC driver totally and use mmci as the main SD
controller driver for Qualcomm SOCs.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/mmc/host/mmci.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 08ff8d2..fa851d5 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -190,6 +190,23 @@ static struct variant_data variant_ux500v2 = {
        .pwrreg_nopower         = true,
 };

+static struct variant_data variant_qcom = {
+       .fifosize               = 16 * 4,
+       .fifohalfsize           = 8 * 4,
+       .clkreg                 = MCI_CLK_ENABLE,
+       .clkreg_enable          = MCI_QCOM_CLK_FLOWENA |
+                                 MCI_QCOM_CLK_SELECT_IN_FBCLK,
+       .clkreg_8bit_bus_enable = MCI_QCOM_CLK_WIDEBUS_8,
+       .datactrl_mask_ddrmode  = MCI_QCOM_CLK_SELECT_IN_DDR_MODE,
+       .data_cmd_enable        = MCI_QCOM_CSPM_DATCMD,
+       .blksz_datactrl4        = true,
+       .datalength_bits        = 24,
+       .pwrreg_powerup         = MCI_PWR_UP,
+       .f_max                  = 208000000,
+       .explicit_mclk_control  = true,
+       .qcom_fifo              = true,
+};
+
 static int mmci_card_busy(struct mmc_host *mmc)
 {
        struct mmci_host *host = mmc_priv(mmc);
@@ -1831,6 +1848,12 @@ static struct amba_id mmci_ids[] = {
                .mask   = 0xf0ffffff,
                .data   = &variant_ux500v2,
        },
+       /* Qualcomm variants */
+       {
+               .id     = 0x00051180,
+               .mask   = 0x000fffff,
+               .data   = &variant_qcom,
+       },
        { 0, 0 },
 };

--
1.9.1


  parent reply	other threads:[~2014-07-17  8:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02  9:03 [PATCH v6 00/12] Qualcomm SD Card Controller support srinivas.kandagatla
2014-06-02  9:08 ` [PATCH v6 01/12] mmc: mmci: use NSEC_PER_SEC macro srinivas.kandagatla
2014-06-02  9:08 ` [PATCH v6 02/12] mmc: mmci: Add Qualcomm specific register defines srinivas.kandagatla
2014-06-11 12:45   ` Linus Walleij
2014-06-02  9:08 ` [PATCH v6 03/12] mmc: mmci: Add enough delay between writes to CMD register srinivas.kandagatla
2014-06-11 12:46   ` Linus Walleij
2014-06-02  9:09 ` [PATCH v6 04/12] mmc: mmci: Add Qcom datactrl register variant srinivas.kandagatla
     [not found]   ` <CA+neC=Of9Ua5OxUiezmTHfzq9zkXVRCFei3xKMbXi3OGV84EHw@mail.gmail.com>
2014-07-17 10:26     ` Fwd: " prakash.burla
2014-07-17 10:26       ` prakash.burla
2014-06-02  9:09 ` [PATCH v6 05/12] mmc: mmci: add ddrmode mask to variant data srinivas.kandagatla
2014-06-02  9:09 ` [PATCH v6 06/12] mmc: mmci: add 8bit bus support in " srinivas.kandagatla
2014-06-02  9:09 ` [PATCH v6 07/12] mmc: mmci: add edge support to data and command out " srinivas.kandagatla
2014-06-02  9:09 ` [PATCH v6 08/12] mmc: mmci: Add support to data commands via variant structure srinivas.kandagatla
2014-06-02  9:09 ` [PATCH v6 09/12] mmc: mmci: add f_max to " srinivas.kandagatla
2014-06-11 12:47   ` Linus Walleij
2014-06-02  9:09 ` [PATCH v6 10/12] mmc: mmci: add explicit clk control srinivas.kandagatla
2014-06-11 12:50   ` Linus Walleij
2014-06-02  9:10 ` [PATCH v6 11/12] mmc: mmci: Add Qcom specific rx_fifocnt logic srinivas.kandagatla
2014-06-11 12:52   ` Linus Walleij
2014-06-02  9:10 ` [PATCH v6 12/12] mmc: mmci: Add Qualcomm Id to amba id table srinivas.kandagatla
2014-06-11 12:52   ` Linus Walleij
     [not found]   ` <CA+neC=PRkUqcL63yNkvJNgRQqvQ+c+1g+qptM7vXH5c9-b5UDw@mail.gmail.com>
2014-07-17  8:31     ` prakash.burla [this message]
2014-06-11 17:35 ` [PATCH v6 00/12] Qualcomm SD Card Controller support Ulf Hansson
2014-06-11 17:37   ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405585892.574323701@apps.rackspace.com \
    --to=prakash.burla@smartplayin.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.