All of lore.kernel.org
 help / color / mirror / Atom feed
From: Punit Agrawal <punit.agrawal@arm.com>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Punit Agrawal <punit.agrawal@arm.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>
Subject: [PATCH 2/3] thermal: trace: Trace when a cooling device's state is updated
Date: Tue, 29 Jul 2014 11:50:49 +0100	[thread overview]
Message-ID: <1406631050-14975-3-git-send-email-punit.agrawal@arm.com> (raw)
In-Reply-To: <1406631050-14975-1-git-send-email-punit.agrawal@arm.com>

Introduce and use an event to trace when a cooling device's state is
updated. This is useful to follow the effect of governor decisions on
cooling devices.

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
---
 drivers/thermal/thermal_core.c |    1 +
 include/trace/events/thermal.h |   19 +++++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 6b32391..c74c78d 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1291,6 +1291,7 @@ void thermal_cdev_update(struct thermal_cooling_device *cdev)
 	mutex_unlock(&cdev->lock);
 	cdev->ops->set_cur_state(cdev, target);
 	cdev->updated = true;
+	trace_cdev_update(cdev, target);
 	dev_dbg(&cdev->device, "set to state %lu\n", target);
 }
 EXPORT_SYMBOL(thermal_cdev_update);
diff --git a/include/trace/events/thermal.h b/include/trace/events/thermal.h
index 8c5ca96..894a79e 100644
--- a/include/trace/events/thermal.h
+++ b/include/trace/events/thermal.h
@@ -32,6 +32,25 @@ TRACE_EVENT(thermal_temperature,
 		__entry->temp)
 );
 
+TRACE_EVENT(cdev_update,
+
+	TP_PROTO(struct thermal_cooling_device *cdev, unsigned long target),
+
+	TP_ARGS(cdev, target),
+
+	TP_STRUCT__entry(
+		__string(type, cdev->type)
+		__field(unsigned long, target)
+	),
+
+	TP_fast_assign(
+		__assign_str(type, cdev->type);
+		__entry->target = target;
+	),
+
+	TP_printk("type=%s target=%lu", __get_str(type), __entry->target)
+);
+
 #endif /* _TRACE_THERMAL_H */
 
 /* This part must be outside protection */
-- 
1.7.10.4


  parent reply	other threads:[~2014-07-29 10:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 11:31 [RFC PATCH 0/3] Add trace to thermal framework Punit Agrawal
2014-06-11 11:31 ` [RFC PATCH 1/3] thermal: trace: Trace temperature changes Punit Agrawal
2014-06-11 11:31 ` [RFC PATCH 2/3] thermal: trace: Trace when a cooling device's state is updated Punit Agrawal
2014-06-11 11:31 ` [RFC PATCH 3/3] thermal: trace: Trace when temperature is above a trip point Punit Agrawal
2014-06-11 12:49   ` Steven Rostedt
2014-06-11 14:11     ` Punit Agrawal
2014-06-11 14:11       ` Punit Agrawal
2014-06-11 14:20       ` Steven Rostedt
2014-06-11 14:20         ` Steven Rostedt
2014-06-11 14:53         ` Punit Agrawal
2014-06-11 14:53           ` Punit Agrawal
2014-06-11 15:08           ` Steven Rostedt
2014-06-11 15:08             ` Steven Rostedt
2014-06-12 16:16             ` Punit Agrawal
2014-06-12 16:16               ` Punit Agrawal
2014-06-20 17:24   ` Javi Merino
2014-06-24 10:41     ` Punit Agrawal
2014-06-24 10:41       ` Punit Agrawal
2014-06-25 13:26       ` Javi Merino
2014-07-25 14:11       ` edubezval
2014-07-29 10:50 ` [PATCH 0/3] Add trace to thermal framework Punit Agrawal
2014-07-29 10:50   ` [PATCH 1/3] thermal: trace: Trace temperature changes Punit Agrawal
2014-07-29 10:50   ` Punit Agrawal [this message]
2014-07-29 10:50   ` [PATCH 3/3] thermal: trace: Trace when temperature is above a trip point Punit Agrawal
2014-07-29 13:33   ` [PATCH 0/3] Add trace to thermal framework Eduardo Valentin
2014-07-30 11:40     ` Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406631050-14975-3-git-send-email-punit.agrawal@arm.com \
    --to=punit.agrawal@arm.com \
    --cc=edubezval@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.