From: Humberto Silva Naves <hsnaves@gmail.com>
To: linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>,
Tomasz Figa <t.figa@samsung.com>,
Thomas Abraham <ta.omasab@gmail.com>,
Andreas Farber <afaerber@suse.de>,
Randy Dunlap <rdunlap@infradead.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Humberto Silva Naves <hsnaves@gmail.com>
Subject: [PATCHv2 2/5] clk: samsung: exynos5410: Organize register offset constants
Date: Thu, 31 Jul 2014 13:22:09 +0200 [thread overview]
Message-ID: <1406805732-17372-3-git-send-email-hsnaves@gmail.com> (raw)
In-Reply-To: <1406805732-17372-1-git-send-email-hsnaves@gmail.com>
The different register groups (SRC, DIV, PLL, GATE, etc) are
now separated by a blank line, and within the same group, the
definitions are ordered by address. This is done to reduce the
chances of potential conflicts when adding new entries, and
to improve the readability of code. While at it, replaced some
spaces with tabs to keep consistency.
Signed-off-by: Humberto Silva Naves <hsnaves@gmail.com>
---
drivers/clk/samsung/clk-exynos5410.c | 42 +++++++++++++++++++---------------
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5410.c b/drivers/clk/samsung/clk-exynos5410.c
index bf57c80..92c56b7 100644
--- a/drivers/clk/samsung/clk-exynos5410.c
+++ b/drivers/clk/samsung/clk-exynos5410.c
@@ -19,39 +19,43 @@
#include "clk.h"
-#define APLL_LOCK 0x0
-#define APLL_CON0 0x100
-#define CPLL_LOCK 0x10020
-#define CPLL_CON0 0x10120
-#define MPLL_LOCK 0x4000
-#define MPLL_CON0 0x4100
-#define BPLL_LOCK 0x20010
-#define BPLL_CON0 0x20110
-#define KPLL_LOCK 0x28000
-#define KPLL_CON0 0x28100
+#define APLL_LOCK 0x0
+#define APLL_CON0 0x100
+#define MPLL_LOCK 0x4000
+#define MPLL_CON0 0x4100
+#define CPLL_LOCK 0x10020
+#define CPLL_CON0 0x10120
+#define BPLL_LOCK 0x20010
+#define BPLL_CON0 0x20110
+#define KPLL_LOCK 0x28000
+#define KPLL_CON0 0x28100
#define SRC_CPU 0x200
-#define DIV_CPU0 0x500
#define SRC_CPERI1 0x4204
-#define DIV_TOP0 0x10510
-#define DIV_TOP1 0x10514
-#define DIV_FSYS1 0x1054c
-#define DIV_FSYS2 0x10550
-#define DIV_PERIC0 0x10558
#define SRC_TOP0 0x10210
#define SRC_TOP1 0x10214
#define SRC_TOP2 0x10218
#define SRC_FSYS 0x10244
#define SRC_PERIC0 0x10250
+#define SRC_CDREX 0x20200
+#define SRC_KFC 0x28200
+
#define SRC_MASK_FSYS 0x10340
#define SRC_MASK_PERIC0 0x10350
+
+#define DIV_CPU0 0x500
+#define DIV_TOP0 0x10510
+#define DIV_TOP1 0x10514
+#define DIV_FSYS1 0x1054c
+#define DIV_FSYS2 0x10550
+#define DIV_PERIC0 0x10558
+#define DIV_KFC0 0x28500
+
#define GATE_BUS_FSYS0 0x10740
+
#define GATE_IP_FSYS 0x10944
#define GATE_IP_PERIC 0x10950
#define GATE_IP_PERIS 0x10960
-#define SRC_CDREX 0x20200
-#define SRC_KFC 0x28200
-#define DIV_KFC0 0x28500
/* list of PLLs */
enum exynos5410_plls {
--
1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Humberto Silva Naves <hsnaves@gmail.com>
To: linux-samsung-soc@vger.kernel.org
Cc: Humberto Silva Naves <hsnaves@gmail.com>,
devicetree@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kukjin Kim <kgene.kim@samsung.com>,
Thomas Abraham <ta.omasab@gmail.com>,
linux-doc@vger.kernel.org, Tomasz Figa <t.figa@samsung.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, Andreas Farber <afaerber@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/5] clk: samsung: exynos5410: Organize register offset constants
Date: Thu, 31 Jul 2014 13:22:09 +0200 [thread overview]
Message-ID: <1406805732-17372-3-git-send-email-hsnaves@gmail.com> (raw)
In-Reply-To: <1406805732-17372-1-git-send-email-hsnaves@gmail.com>
The different register groups (SRC, DIV, PLL, GATE, etc) are
now separated by a blank line, and within the same group, the
definitions are ordered by address. This is done to reduce the
chances of potential conflicts when adding new entries, and
to improve the readability of code. While at it, replaced some
spaces with tabs to keep consistency.
Signed-off-by: Humberto Silva Naves <hsnaves@gmail.com>
---
drivers/clk/samsung/clk-exynos5410.c | 42 +++++++++++++++++++---------------
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5410.c b/drivers/clk/samsung/clk-exynos5410.c
index bf57c80..92c56b7 100644
--- a/drivers/clk/samsung/clk-exynos5410.c
+++ b/drivers/clk/samsung/clk-exynos5410.c
@@ -19,39 +19,43 @@
#include "clk.h"
-#define APLL_LOCK 0x0
-#define APLL_CON0 0x100
-#define CPLL_LOCK 0x10020
-#define CPLL_CON0 0x10120
-#define MPLL_LOCK 0x4000
-#define MPLL_CON0 0x4100
-#define BPLL_LOCK 0x20010
-#define BPLL_CON0 0x20110
-#define KPLL_LOCK 0x28000
-#define KPLL_CON0 0x28100
+#define APLL_LOCK 0x0
+#define APLL_CON0 0x100
+#define MPLL_LOCK 0x4000
+#define MPLL_CON0 0x4100
+#define CPLL_LOCK 0x10020
+#define CPLL_CON0 0x10120
+#define BPLL_LOCK 0x20010
+#define BPLL_CON0 0x20110
+#define KPLL_LOCK 0x28000
+#define KPLL_CON0 0x28100
#define SRC_CPU 0x200
-#define DIV_CPU0 0x500
#define SRC_CPERI1 0x4204
-#define DIV_TOP0 0x10510
-#define DIV_TOP1 0x10514
-#define DIV_FSYS1 0x1054c
-#define DIV_FSYS2 0x10550
-#define DIV_PERIC0 0x10558
#define SRC_TOP0 0x10210
#define SRC_TOP1 0x10214
#define SRC_TOP2 0x10218
#define SRC_FSYS 0x10244
#define SRC_PERIC0 0x10250
+#define SRC_CDREX 0x20200
+#define SRC_KFC 0x28200
+
#define SRC_MASK_FSYS 0x10340
#define SRC_MASK_PERIC0 0x10350
+
+#define DIV_CPU0 0x500
+#define DIV_TOP0 0x10510
+#define DIV_TOP1 0x10514
+#define DIV_FSYS1 0x1054c
+#define DIV_FSYS2 0x10550
+#define DIV_PERIC0 0x10558
+#define DIV_KFC0 0x28500
+
#define GATE_BUS_FSYS0 0x10740
+
#define GATE_IP_FSYS 0x10944
#define GATE_IP_PERIC 0x10950
#define GATE_IP_PERIS 0x10960
-#define SRC_CDREX 0x20200
-#define SRC_KFC 0x28200
-#define DIV_KFC0 0x28500
/* list of PLLs */
enum exynos5410_plls {
--
1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: hsnaves@gmail.com (Humberto Silva Naves)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/5] clk: samsung: exynos5410: Organize register offset constants
Date: Thu, 31 Jul 2014 13:22:09 +0200 [thread overview]
Message-ID: <1406805732-17372-3-git-send-email-hsnaves@gmail.com> (raw)
In-Reply-To: <1406805732-17372-1-git-send-email-hsnaves@gmail.com>
The different register groups (SRC, DIV, PLL, GATE, etc) are
now separated by a blank line, and within the same group, the
definitions are ordered by address. This is done to reduce the
chances of potential conflicts when adding new entries, and
to improve the readability of code. While at it, replaced some
spaces with tabs to keep consistency.
Signed-off-by: Humberto Silva Naves <hsnaves@gmail.com>
---
drivers/clk/samsung/clk-exynos5410.c | 42 +++++++++++++++++++---------------
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5410.c b/drivers/clk/samsung/clk-exynos5410.c
index bf57c80..92c56b7 100644
--- a/drivers/clk/samsung/clk-exynos5410.c
+++ b/drivers/clk/samsung/clk-exynos5410.c
@@ -19,39 +19,43 @@
#include "clk.h"
-#define APLL_LOCK 0x0
-#define APLL_CON0 0x100
-#define CPLL_LOCK 0x10020
-#define CPLL_CON0 0x10120
-#define MPLL_LOCK 0x4000
-#define MPLL_CON0 0x4100
-#define BPLL_LOCK 0x20010
-#define BPLL_CON0 0x20110
-#define KPLL_LOCK 0x28000
-#define KPLL_CON0 0x28100
+#define APLL_LOCK 0x0
+#define APLL_CON0 0x100
+#define MPLL_LOCK 0x4000
+#define MPLL_CON0 0x4100
+#define CPLL_LOCK 0x10020
+#define CPLL_CON0 0x10120
+#define BPLL_LOCK 0x20010
+#define BPLL_CON0 0x20110
+#define KPLL_LOCK 0x28000
+#define KPLL_CON0 0x28100
#define SRC_CPU 0x200
-#define DIV_CPU0 0x500
#define SRC_CPERI1 0x4204
-#define DIV_TOP0 0x10510
-#define DIV_TOP1 0x10514
-#define DIV_FSYS1 0x1054c
-#define DIV_FSYS2 0x10550
-#define DIV_PERIC0 0x10558
#define SRC_TOP0 0x10210
#define SRC_TOP1 0x10214
#define SRC_TOP2 0x10218
#define SRC_FSYS 0x10244
#define SRC_PERIC0 0x10250
+#define SRC_CDREX 0x20200
+#define SRC_KFC 0x28200
+
#define SRC_MASK_FSYS 0x10340
#define SRC_MASK_PERIC0 0x10350
+
+#define DIV_CPU0 0x500
+#define DIV_TOP0 0x10510
+#define DIV_TOP1 0x10514
+#define DIV_FSYS1 0x1054c
+#define DIV_FSYS2 0x10550
+#define DIV_PERIC0 0x10558
+#define DIV_KFC0 0x28500
+
#define GATE_BUS_FSYS0 0x10740
+
#define GATE_IP_FSYS 0x10944
#define GATE_IP_PERIC 0x10950
#define GATE_IP_PERIS 0x10960
-#define SRC_CDREX 0x20200
-#define SRC_KFC 0x28200
-#define DIV_KFC0 0x28500
/* list of PLLs */
enum exynos5410_plls {
--
1.7.10.4
next prev parent reply other threads:[~2014-07-31 11:23 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 11:22 [PATCHv2 0/5] clk: samsung: exynos5410: Implementation of the PLL clocks Humberto Silva Naves
2014-07-31 11:22 ` Humberto Silva Naves
2014-07-31 11:22 ` [PATCHv2 1/5] clk: samsung: exynos5410: Add NULL pointer checks in clock init Humberto Silva Naves
2014-07-31 11:22 ` Humberto Silva Naves
2014-07-31 11:22 ` Humberto Silva Naves
2014-07-31 12:34 ` Tomasz Figa
2014-07-31 12:34 ` Tomasz Figa
2014-07-31 13:13 ` Humberto Naves
2014-07-31 13:13 ` Humberto Naves
2014-07-31 13:13 ` Humberto Naves
2014-07-31 13:20 ` Tomasz Figa
2014-07-31 13:20 ` Tomasz Figa
2014-07-31 11:22 ` Humberto Silva Naves [this message]
2014-07-31 11:22 ` [PATCHv2 2/5] clk: samsung: exynos5410: Organize register offset constants Humberto Silva Naves
2014-07-31 11:22 ` Humberto Silva Naves
2014-07-31 12:49 ` Tomasz Figa
2014-07-31 12:49 ` Tomasz Figa
2014-07-31 11:22 ` [PATCHv2 3/5] clk: samsung: exynos5410: Add suspend/resume handling Humberto Silva Naves
2014-07-31 11:22 ` Humberto Silva Naves
2014-07-31 13:09 ` Tomasz Figa
2014-07-31 13:09 ` Tomasz Figa
2014-07-31 11:22 ` [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks Humberto Silva Naves
2014-07-31 11:22 ` Humberto Silva Naves
2014-07-31 11:45 ` Sylwester Nawrocki
2014-07-31 11:45 ` Sylwester Nawrocki
2014-07-31 11:45 ` Sylwester Nawrocki
2014-07-31 21:01 ` Humberto Naves
2014-07-31 21:01 ` Humberto Naves
2014-07-31 21:08 ` Tomasz Figa
2014-07-31 21:08 ` Tomasz Figa
2014-07-31 12:53 ` Tomasz Figa
2014-07-31 12:53 ` Tomasz Figa
2014-07-31 13:23 ` Humberto Naves
2014-07-31 13:23 ` Humberto Naves
2014-07-31 13:37 ` Tomasz Figa
2014-07-31 13:37 ` Tomasz Figa
2014-07-31 11:22 ` [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL Humberto Silva Naves
2014-07-31 11:22 ` Humberto Silva Naves
2014-07-31 13:07 ` Tomasz Figa
2014-07-31 13:07 ` Tomasz Figa
2014-07-31 13:37 ` Humberto Naves
2014-07-31 13:37 ` Humberto Naves
2014-07-31 15:19 ` Tomasz Figa
2014-07-31 15:19 ` Tomasz Figa
2014-07-31 21:19 ` Humberto Naves
2014-07-31 21:19 ` Humberto Naves
2014-07-31 22:17 ` Tomasz Figa
2014-07-31 22:17 ` Tomasz Figa
2014-07-31 22:51 ` Mike Turquette
2014-07-31 22:51 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406805732-17372-3-git-send-email-hsnaves@gmail.com \
--to=hsnaves@gmail.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=t.figa@samsung.com \
--cc=ta.omasab@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.