All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 09/17] pnfs/blocklayout: improve GETDEVICEINFO error reporting
Date: Thu,  7 Aug 2014 09:23:41 +0200	[thread overview]
Message-ID: <1407396229-4785-10-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1407396229-4785-1-git-send-email-hch@lst.de>

Tell userspace what stage of GETDEVICEINFO failed so that there is a chance
to debug it, especially with the userspace daemon clusterf***k in the block
layout driver.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/nfs/blocklayout/blocklayoutdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/blocklayout/blocklayoutdev.c b/fs/nfs/blocklayout/blocklayoutdev.c
index 04303b5..63f77925 100644
--- a/fs/nfs/blocklayout/blocklayoutdev.c
+++ b/fs/nfs/blocklayout/blocklayoutdev.c
@@ -150,7 +150,7 @@ nfs4_blk_decode_device(struct nfs_server *server,
 	remove_wait_queue(&nn->bl_wq, &wq);
 
 	if (reply->status != BL_DEVICE_REQUEST_PROC) {
-		dprintk("%s failed to open device: %d\n",
+		printk(KERN_WARNING "%s failed to decode device: %d\n",
 			__func__, reply->status);
 		rv = ERR_PTR(-EINVAL);
 		goto out;
@@ -159,7 +159,8 @@ nfs4_blk_decode_device(struct nfs_server *server,
 	bd = blkdev_get_by_dev(MKDEV(reply->major, reply->minor),
 			       FMODE_READ, NULL);
 	if (IS_ERR(bd)) {
-		dprintk("%s failed to open device : %ld\n", __func__,
+		printk(KERN_WARNING "%s failed to open device %d:%d (%ld)\n",
+			__func__, reply->major, reply->minor,
 			PTR_ERR(bd));
 		rv = ERR_CAST(bd);
 		goto out;
-- 
1.9.1


  parent reply	other threads:[~2014-08-07  7:21 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07  7:23 pnfs block layout driver fixes Christoph Hellwig
2014-08-07  7:23 ` [PATCH 01/17] nfs: cap request size to fit a kmalloced page array Christoph Hellwig
2014-08-07  7:23 ` [PATCH 02/17] pnfs: do not pass uninitialized lsegs to ->free_lseg Christoph Hellwig
2014-08-07  7:23 ` [PATCH 03/17] pnfs: force a layout commit when encountering busy segments during recall Christoph Hellwig
2014-08-07  7:23 ` [PATCH 04/17] pnfs: don't check sequence on new stateids in layoutget Christoph Hellwig
2014-08-07  7:23 ` [PATCH 05/17] pnfs: add flag to force read-modify-write in ->write_begin Christoph Hellwig
2014-08-07  7:23 ` [PATCH 06/17] pnfs: add return_range method Christoph Hellwig
2014-08-07  7:23 ` [PATCH 07/17] pnfs: allow splicing pre-encoded pages into the layoutcommit args Christoph Hellwig
2014-08-07  7:23 ` [PATCH 08/17] pnfs/blocklayout: reject pnfs blocksize larger than page size Christoph Hellwig
2014-08-07 10:43   ` Peng Tao
2014-08-07 11:25     ` Christoph Hellwig
2014-08-07 11:51       ` Peng Tao
2014-08-07 12:10         ` Christoph Hellwig
2014-08-07 13:43           ` Peng Tao
2014-08-07 16:20             ` Christoph Hellwig
2014-08-08 10:28               ` Peng Tao
2014-08-07 12:56         ` faibish, sorin
2014-08-07 13:45           ` Peng Tao
2014-08-07 16:10           ` Christoph Hellwig
2014-08-07 16:18             ` faibish, sorin
2014-08-07 13:13       ` Steve Dickson
2014-08-07 13:17         ` Steve Dickson
2014-08-07  7:23 ` Christoph Hellwig [this message]
2014-08-07  7:23 ` [PATCH 10/17] pnfs/blocklayout: plug block queues Christoph Hellwig
2014-08-07  7:23 ` [PATCH 11/17] pnfs/blocklayout: correctly decrement extent length Christoph Hellwig
2014-08-07  7:23 ` [PATCH 12/17] pnfs/blocklayout: remove read-modify-write handling in bl_write_pagelist Christoph Hellwig
2014-08-07  7:23 ` [PATCH 13/17] pnfs/blocklayout: don't set pages uptodate Christoph Hellwig
2014-08-07  7:23 ` [PATCH 14/17] pnfs/blocklayout: rewrite extent tracking Christoph Hellwig
2014-08-07  7:23 ` [PATCH 15/17] pnfs/blocklayout: implement the return_range method Christoph Hellwig
2014-08-07  7:23 ` [PATCH 16/17] pnfs/blocklayout: return layouts on setattr Christoph Hellwig
2014-08-07  7:23 ` [PATCH 17/17] pnfs/blocklayout: allocate separate pages for the layoutcommit payload Christoph Hellwig
2014-08-07 11:05   ` Peng Tao
2014-08-07 11:27     ` Christoph Hellwig
2014-08-07 11:57       ` Peng Tao
2014-08-20 18:43 ` pnfs block layout driver fixes Jeff Layton
2014-08-20 22:14   ` Christoph Hellwig
2014-09-07 15:39 ` Christoph Hellwig
2014-09-07 16:44   ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407396229-4785-10-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.