All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
	Amit Daniel Kachhap <amit.daniel@samsung.com>,
	Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
	Lukasz Majewski <l.majewski@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com
Subject: [PATCH 13/33] thermal: exynos: replace threshold_falling check by Exynos SoC type one
Date: Thu, 18 Sep 2014 17:27:30 +0200	[thread overview]
Message-ID: <1411054070-25757-14-git-send-email-b.zolnierkie@samsung.com> (raw)
In-Reply-To: <1411054070-25757-1-git-send-email-b.zolnierkie@samsung.com>

Replace pdata->threshold_falling check for non-zero value in
exynos_tmu_initialize() by an explicit check for a SoC type
(all SoC types except Exynos5440 have pdata->threshold_falling
assigned to non-zero value in their struct exynos_tmu_registers
instances).

This is a preparation for introducing per-SoC type tmu_initialize
method.

There should be no functional changes caused by this patch.

Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Amit Daniel Kachhap <amit.daniel@samsung.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/thermal/samsung/exynos_tmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index f02e65d..641a77a 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -214,7 +214,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
 						pdata->trigger_levels[i]);
 			rising_threshold &= ~(0xff << 8 * i);
 			rising_threshold |= threshold_code << 8 * i;
-			if (pdata->threshold_falling) {
+			if (data->soc != SOC_ARCH_EXYNOS5440) {
 				threshold_code = temp_to_code(data,
 						pdata->trigger_levels[i] -
 						pdata->threshold_falling);
-- 
1.8.2.3


  parent reply	other threads:[~2014-09-18 15:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 15:27 [PATCH 00/33] thermal: exynos: convert the driver to use per-SoC type operations Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 01/33] thermal: exynos: remove needless triminfo_data abstraction Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 02/33] thermal: exynos: remove needless tmu_status abstraction Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 03/33] thermal: exynos: remove needless threshold_temp abstraction Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 04/33] thermal: exynos: remove needless triminfo_ctrl abstraction Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 05/33] thermal: exynos: remove needless test_mux_addr_shift abstraction Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 06/33] thermal: exynos: remove needless therm_trip_[mode,mask]_shift abstractions Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 07/33] thermal: exynos: remove needless therm_trip_en_shift abstraction Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 08/33] thermal: exynos: remove needless emul_temp_shift abstraction Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 09/33] thermal: exynos: remove needless emul_time_shift abstraction Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 10/33] thermal: exynos: replace tmu_irqstatus check by Exynos5440 one Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 11/33] thermal: exynos: replace tmu_pmin " Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 12/33] thermal: exynos: simplify HW_TRIP level setting Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` Bartlomiej Zolnierkiewicz [this message]
2014-09-18 15:27 ` [PATCH 14/33] thermal: exynos: remove TMU_SUPPORT_READY_STATUS flag Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 15/33] thermal: exynos: remove TMU_SUPPORT_TRIM_RELOAD flag Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 16/33] thermal: exynos: add sanitize_temp_error() helper Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 17/33] thermal: exynos: add get_th_reg() helper Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 18/33] thermal: exynos: add ->tmu_initialize method Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 19/33] thermal: exynos: add get_con_reg() helper Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 20/33] thermal: exynos: add ->tmu_control method Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 21/33] thermal: exynos: add ->tmu_read method Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 22/33] thermal: exynos: add get_emul_con_reg() helper Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 23/33] thermal: exynos: add ->tmu_set_emulation method Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 24/33] thermal: exynos: add ->tmu_clear_irqs method Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 25/33] thermal: exynos: remove TMU_SUPPORT_FALLING_TRIP flag Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 26/33] thermal: exynos: remove TMU_SUPPORT_EMUL_TIME flag Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 27/33] thermal: exynos: remove TMU_SUPPORT_EMULATION flag Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 28/33] thermal: exynos: remove TMU_SUPPORT_ADDRESS_MULTIPLE flag Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 29/33] thermal: exynos: remove TMU_SUPPORT_MULTI_INST flag Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 30/33] thermal: exynos: remove test_mux pdata field Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 31/33] thermal: exynos: remove SoC type ifdefs Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 32/33] thermal: exynos: remove __EXYNOS5420_TMU_DATA macro Bartlomiej Zolnierkiewicz
2014-09-18 15:27 ` [PATCH 33/33] thermal: exynos: remove exynos_tmu_data.h include Bartlomiej Zolnierkiewicz
2014-10-20 12:47 ` [PATCH 00/33] thermal: exynos: convert the driver to use per-SoC type operations Bartlomiej Zolnierkiewicz
2014-10-30  2:44 ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411054070-25757-14-git-send-email-b.zolnierkie@samsung.com \
    --to=b.zolnierkie@samsung.com \
    --cc=amit.daniel@samsung.com \
    --cc=ch.naveen@samsung.com \
    --cc=edubezval@gmail.com \
    --cc=kyungmin.park@samsung.com \
    --cc=l.majewski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.