All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olga Kornievskaia <kolga@netapp.com>
To: <Trond.Myklebust@primarydata.com>
Cc: <linux-nfs@vger.kernel.org>
Subject: [PATCH 1/1] Fixing lease renewal
Date: Wed, 24 Sep 2014 18:11:28 -0400	[thread overview]
Message-ID: <1411596688-21347-1-git-send-email-kolga@netapp.com> (raw)

Commit c9fdeb28 removed a 'continue' after checking if the lease needs
to be renewed. However, if client hasn't moved, the code falls down to
starting reboot recovery erroneously (ie., sends open reclaim and gets
back stale_clientid error) before recovering from getting stale_clientid
on the renew operation.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
 fs/nfs/nfs4state.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 22fe351..6678769 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -2345,6 +2345,7 @@ static void nfs4_state_manager(struct nfs_client *clp)
 			status = nfs4_check_lease(clp);
 			if (status < 0)
 				goto out_error;
+			continue;
 		}
 
 		if (test_and_clear_bit(NFS4CLNT_MOVED, &clp->cl_state)) {
-- 
1.8.5.2 (Apple Git-48)


             reply	other threads:[~2014-09-24 22:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 22:11 Olga Kornievskaia [this message]
2014-09-24 22:24 ` [PATCH 1/1] Fixing lease renewal Trond Myklebust
  -- strict thread matches above, loose matches on Subject: below --
2014-09-24 16:08 Olga Kornievskaia
2014-09-24 18:05 ` Trond Myklebust
2014-09-24 18:21   ` Olga Kornievskaia
2014-09-24 18:29   ` Olga Kornievskaia
2014-09-24 20:11     ` Trond Myklebust
2014-09-24 22:12       ` Olga Kornievskaia
2014-09-24 13:11 Olga Kornievskaia
2014-09-24 13:46 ` Anna Schumaker
2014-09-24 15:08   ` Olga Kornievskaia
2014-09-23 21:36 Olga Kornievskaia
2014-09-23 21:51 ` Trond Myklebust
2014-09-24 13:10   ` Olga Kornievskaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411596688-21347-1-git-send-email-kolga@netapp.com \
    --to=kolga@netapp.com \
    --cc=Trond.Myklebust@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.