All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/6] drm/i915: Use IS_HSW_ULT() in a HSW specific code path
Date: Wed,  1 Oct 2014 20:04:13 +0100	[thread overview]
Message-ID: <1412190258-4152-2-git-send-email-damien.lespiau@intel.com> (raw)
In-Reply-To: <1412190258-4152-1-git-send-email-damien.lespiau@intel.com>

No need to add the BDW pci ULT/ULX checks inside a if (IS_HASWELL(dev))
code path.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 66489fa..9d4bdd6 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -463,7 +463,7 @@ void intel_detect_pch(struct drm_device *dev)
 				dev_priv->pch_type = PCH_LPT;
 				DRM_DEBUG_KMS("Found LynxPoint PCH\n");
 				WARN_ON(!IS_HASWELL(dev));
-				WARN_ON(IS_ULT(dev));
+				WARN_ON(IS_HSW_ULT(dev));
 			} else if (IS_BROADWELL(dev)) {
 				dev_priv->pch_type = PCH_LPT;
 				dev_priv->pch_id =
@@ -474,7 +474,7 @@ void intel_detect_pch(struct drm_device *dev)
 				dev_priv->pch_type = PCH_LPT;
 				DRM_DEBUG_KMS("Found LynxPoint LP PCH\n");
 				WARN_ON(!IS_HASWELL(dev));
-				WARN_ON(!IS_ULT(dev));
+				WARN_ON(!IS_HSW_ULT(dev));
 			} else if (id == INTEL_PCH_SPT_DEVICE_ID_TYPE) {
 				dev_priv->pch_type = PCH_SPT;
 				DRM_DEBUG_KMS("Found SunrisePoint PCH\n");
-- 
1.8.3.1

  reply	other threads:[~2014-10-01 19:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 19:04 [PATCH 0/6] Kill IS_ULT() in favour of the per-product variant Damien Lespiau
2014-10-01 19:04 ` Damien Lespiau [this message]
2014-10-01 19:04 ` [PATCH 2/6] drm/i915: Use IS_HSW_ULT() in HAS_IPS() Damien Lespiau
2014-10-01 19:04 ` [PATCH 3/6] drm/i915: Spell out IS_HSW/BDW_ULT() in intel_crt_present() Damien Lespiau
2014-10-01 19:04 ` [PATCH 4/6] drm/i915: Use IS_HSW_ULT() in HSW CDCLK clock read-out Damien Lespiau
2014-10-01 19:04 ` [PATCH 5/6] drm/i915/skl: Don't check for ULT/ULX when detecting the PCH Damien Lespiau
2014-10-01 19:04 ` [PATCH 6/6] drm/i915: Remove IS_ULT() Damien Lespiau
2014-10-01 20:36 ` [PATCH 0/6] Kill IS_ULT() in favour of the per-product variant Daniel Vetter
2014-10-03 18:40   ` Paulo Zanoni
2014-10-03 18:46     ` Paulo Zanoni
2014-10-03 18:52       ` Paulo Zanoni
2014-10-03 21:34         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412190258-4152-2-git-send-email-damien.lespiau@intel.com \
    --to=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.