All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/6] drm/i915: Spell out IS_HSW/BDW_ULT() in intel_crt_present()
Date: Wed,  1 Oct 2014 20:04:15 +0100	[thread overview]
Message-ID: <1412190258-4152-4-git-send-email-damien.lespiau@intel.com> (raw)
In-Reply-To: <1412190258-4152-1-git-send-email-damien.lespiau@intel.com>

The quality of being a ULT or ULX package doesn't tell anything across
generations and so a global IS_ULT() macro doesn't make much sense, esp.
as we're adding new products.

So, spell out which ULT/ULX SKUs we are talking about here, namely HSW
and BDW.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 87e8c0a..cc55be4 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12160,7 +12160,7 @@ static bool intel_crt_present(struct drm_device *dev)
 	if (INTEL_INFO(dev)->gen >= 9)
 		return false;
 
-	if (IS_ULT(dev))
+	if (IS_HSW_ULT(dev) || IS_BDW_ULT(dev))
 		return false;
 
 	if (IS_CHERRYVIEW(dev))
-- 
1.8.3.1

  parent reply	other threads:[~2014-10-01 19:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 19:04 [PATCH 0/6] Kill IS_ULT() in favour of the per-product variant Damien Lespiau
2014-10-01 19:04 ` [PATCH 1/6] drm/i915: Use IS_HSW_ULT() in a HSW specific code path Damien Lespiau
2014-10-01 19:04 ` [PATCH 2/6] drm/i915: Use IS_HSW_ULT() in HAS_IPS() Damien Lespiau
2014-10-01 19:04 ` Damien Lespiau [this message]
2014-10-01 19:04 ` [PATCH 4/6] drm/i915: Use IS_HSW_ULT() in HSW CDCLK clock read-out Damien Lespiau
2014-10-01 19:04 ` [PATCH 5/6] drm/i915/skl: Don't check for ULT/ULX when detecting the PCH Damien Lespiau
2014-10-01 19:04 ` [PATCH 6/6] drm/i915: Remove IS_ULT() Damien Lespiau
2014-10-01 20:36 ` [PATCH 0/6] Kill IS_ULT() in favour of the per-product variant Daniel Vetter
2014-10-03 18:40   ` Paulo Zanoni
2014-10-03 18:46     ` Paulo Zanoni
2014-10-03 18:52       ` Paulo Zanoni
2014-10-03 21:34         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412190258-4152-4-git-send-email-damien.lespiau@intel.com \
    --to=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.