All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yao Dongdong <yaodongdong@huawei.com>
To: <edubezval@gmail.com>, <rui.zhang@intel.com>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lizefan@huawei.com>
Subject: [PATCH 2/2 resend] Thermal:Remove usless if(!result) before return tz
Date: Tue, 28 Oct 2014 07:40:25 +0000	[thread overview]
Message-ID: <1414482025-4482-2-git-send-email-yaodongdong@huawei.com> (raw)
In-Reply-To: <1414482025-4482-1-git-send-email-yaodongdong@huawei.com>

result is always zero when comes here.

Signed-off-by: Yao Dongdong <yaodongdong@huawei.com>
Acked-by: Eduardo Valentin <edubezval@gmail.com>
---
 drivers/thermal/thermal_core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index d358605..a438c95 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1575,8 +1575,7 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type,
 
 	thermal_zone_device_update(tz);
 
-	if (!result)
-		return tz;
+	return tz;
 
 unregister:
 	release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id);
-- 
1.8.3.4


WARNING: multiple messages have this Message-ID (diff)
From: Yao Dongdong <yaodongdong@huawei.com>
To: edubezval@gmail.com, rui.zhang@intel.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	lizefan@huawei.com
Subject: [PATCH 2/2 resend] Thermal:Remove usless if(!result) before return tz
Date: Tue, 28 Oct 2014 07:40:25 +0000	[thread overview]
Message-ID: <1414482025-4482-2-git-send-email-yaodongdong@huawei.com> (raw)
In-Reply-To: <1414482025-4482-1-git-send-email-yaodongdong@huawei.com>

result is always zero when comes here.

Signed-off-by: Yao Dongdong <yaodongdong@huawei.com>
Acked-by: Eduardo Valentin <edubezval@gmail.com>
---
 drivers/thermal/thermal_core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index d358605..a438c95 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1575,8 +1575,7 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type,
 
 	thermal_zone_device_update(tz);
 
-	if (!result)
-		return tz;
+	return tz;
 
 unregister:
 	release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id);
-- 
1.8.3.4

  reply	other threads:[~2014-10-28  7:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28  7:40 [PATCH 1/2 resend] Thermal:Fix memory leak if occur goto unregister Yao Dongdong
2014-10-28  7:40 ` Yao Dongdong
2014-10-28  7:40 ` Yao Dongdong [this message]
2014-10-28  7:40   ` [PATCH 2/2 resend] Thermal:Remove usless if(!result) before return tz Yao Dongdong
2014-10-28  8:11 ` [PATCH 1/2 resend] Thermal:Fix memory leak if occur goto unregister Yao Dongdong
2014-10-28  8:11   ` Yao Dongdong
2014-10-29  0:48   ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414482025-4482-2-git-send-email-yaodongdong@huawei.com \
    --to=yaodongdong@huawei.com \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.