From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: linux-nfs@vger.kernel.org, Eryu Guan <eguan@redhat.com>
Subject: [PATCH 3/4] common: skip atime related tests on NFS
Date: Tue, 28 Oct 2014 21:16:10 +0800 [thread overview]
Message-ID: <1414502171-10319-4-git-send-email-eguan@redhat.com> (raw)
In-Reply-To: <1414502171-10319-1-git-send-email-eguan@redhat.com>
>From nfs(5) we can know that atime related mount options have no effect
on NFS mounts, so add _require_atime() helper to skip atime tests on NFS
Also change the way how _require_relatime() mount $SCRATCH_DEV, use
_scratch_mount helper so it's mounted with selinux context, to avoid
"same superblock, different selinux context" failure.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
common/rc | 9 ++++++++-
tests/generic/003 | 1 +
tests/generic/192 | 1 +
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 42f00cb..b50577f 100644
--- a/common/rc
+++ b/common/rc
@@ -2379,10 +2379,17 @@ _verify_reflink()
|| echo "$1 and $2 are not reflinks: different extents"
}
+_require_atime()
+{
+ if [ "$FSTYP" == "nfs" ]; then
+ _notrun "atime related mount options have no effect on NFS"
+ fi
+}
+
_require_relatime()
{
_scratch_mkfs > /dev/null 2>&1
- _mount -t $FSTYP -o relatime $SCRATCH_DEV $SCRATCH_MNT || \
+ _scratch_mount -o relatime || \
_notrun "relatime not supported by the current kernel"
_scratch_unmount
}
diff --git a/tests/generic/003 b/tests/generic/003
index 83d6f90..7ffd09a 100755
--- a/tests/generic/003
+++ b/tests/generic/003
@@ -47,6 +47,7 @@ _cleanup()
_supported_fs generic
_supported_os Linux
_require_scratch
+_require_atime
_require_relatime
rm -f $seqres.full
diff --git a/tests/generic/192 b/tests/generic/192
index b2da358..5b6cfbc 100755
--- a/tests/generic/192
+++ b/tests/generic/192
@@ -54,6 +54,7 @@ is_noatime_set() {
_supported_fs generic
_supported_os Linux
_require_test
+_require_atime
#delay=150
#delay=75
#delay=60
--
1.8.3.1
next prev parent reply other threads:[~2014-10-28 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 13:16 [RFC PATCH 0/4] re-enable tests that require scratch dev on NFS Eryu Guan
2014-10-28 13:16 ` [PATCH 1/4] common: " Eryu Guan
2014-10-28 13:22 ` Christoph Hellwig
2014-10-29 6:59 ` Eryu Guan
2014-10-28 13:16 ` [PATCH 2/4] common: add _require_block_device() helper Eryu Guan
2014-10-28 13:24 ` Christoph Hellwig
2014-10-28 13:16 ` Eryu Guan [this message]
2014-10-30 9:03 ` nfs atime semantics, was: Re: [PATCH 3/4] common: skip atime related tests on NFS Christoph Hellwig
2014-10-31 8:13 ` Eryu Guan
2014-10-31 11:31 ` Trond Myklebust
2014-11-02 18:02 ` Boaz Harrosh
2014-11-05 8:29 ` Christoph Hellwig
2014-10-28 13:16 ` [PATCH 4/4] generic/277: add _require_attrs Eryu Guan
2014-10-28 13:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414502171-10319-4-git-send-email-eguan@redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.