All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, Jason Cooper <jason@lakedaemon.net>,
	Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Gregory Clement <gregory.clement@free-electrons.com>
Cc: Lior Amsalem <alior@marvell.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: mvebu: remove conflicting muxing on Armada 370 DB
Date: Tue, 28 Oct 2014 17:08:42 +0100	[thread overview]
Message-ID: <1414512524-24466-5-git-send-email-thomas.petazzoni@free-electrons.com> (raw)
In-Reply-To: <1414512524-24466-1-git-send-email-thomas.petazzoni@free-electrons.com>

Back when audio was enabled, the muxing of some MPP pins was causing
problems. However, since commit fea038ed55ae ("ARM: mvebu: Add proper
pin muxing on the Armada 370 DB board"), those problematic MPP pins
have been assigned a proper muxing for the Ethernet interfaces. This
proper muxing is now conflicting with the hog pins muxing that had
been added as part of 249f3822509b ("ARM: mvebu: add audio support to
Armada 370 DB").

Therefore, this commit simply removes the hog pins muxing, which
solves a warning a boot time due to the conflicting muxing
requirements.

Fixes: fea038ed55ae ("ARM: mvebu: Add proper pin muxing on the Armada 370 DB board")
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/boot/dts/armada-370-db.dts | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/arch/arm/boot/dts/armada-370-db.dts b/arch/arm/boot/dts/armada-370-db.dts
index a495e58..d505135 100644
--- a/arch/arm/boot/dts/armada-370-db.dts
+++ b/arch/arm/boot/dts/armada-370-db.dts
@@ -102,30 +102,6 @@
 				broken-cd;
 			};
 
-			pinctrl {
-				/*
-				 * These pins might be muxed as I2S by
-				 * the bootloader, but it conflicts
-				 * with the real I2S pins that are
-				 * muxed using i2s_pins. We must mux
-				 * those pins to a function other than
-				 * I2S.
-				 */
-				pinctrl-0 = <&hog_pins1 &hog_pins2>;
-				pinctrl-names = "default";
-
-				hog_pins1: hog-pins1 {
-					marvell,pins = "mpp6",  "mpp8", "mpp10",
-						       "mpp12", "mpp13";
-					marvell,function = "gpio";
-				};
-
-				hog_pins2: hog-pins2 {
-					marvell,pins = "mpp5", "mpp7", "mpp9";
-					marvell,function = "gpo";
-				};
-			};
-
 			usb@50000 {
 				status = "okay";
 			};
-- 
2.0.0

WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: mvebu: remove conflicting muxing on Armada 370 DB
Date: Tue, 28 Oct 2014 17:08:42 +0100	[thread overview]
Message-ID: <1414512524-24466-5-git-send-email-thomas.petazzoni@free-electrons.com> (raw)
In-Reply-To: <1414512524-24466-1-git-send-email-thomas.petazzoni@free-electrons.com>

Back when audio was enabled, the muxing of some MPP pins was causing
problems. However, since commit fea038ed55ae ("ARM: mvebu: Add proper
pin muxing on the Armada 370 DB board"), those problematic MPP pins
have been assigned a proper muxing for the Ethernet interfaces. This
proper muxing is now conflicting with the hog pins muxing that had
been added as part of 249f3822509b ("ARM: mvebu: add audio support to
Armada 370 DB").

Therefore, this commit simply removes the hog pins muxing, which
solves a warning a boot time due to the conflicting muxing
requirements.

Fixes: fea038ed55ae ("ARM: mvebu: Add proper pin muxing on the Armada 370 DB board")
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/boot/dts/armada-370-db.dts | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/arch/arm/boot/dts/armada-370-db.dts b/arch/arm/boot/dts/armada-370-db.dts
index a495e58..d505135 100644
--- a/arch/arm/boot/dts/armada-370-db.dts
+++ b/arch/arm/boot/dts/armada-370-db.dts
@@ -102,30 +102,6 @@
 				broken-cd;
 			};
 
-			pinctrl {
-				/*
-				 * These pins might be muxed as I2S by
-				 * the bootloader, but it conflicts
-				 * with the real I2S pins that are
-				 * muxed using i2s_pins. We must mux
-				 * those pins to a function other than
-				 * I2S.
-				 */
-				pinctrl-0 = <&hog_pins1 &hog_pins2>;
-				pinctrl-names = "default";
-
-				hog_pins1: hog-pins1 {
-					marvell,pins = "mpp6",  "mpp8", "mpp10",
-						       "mpp12", "mpp13";
-					marvell,function = "gpio";
-				};
-
-				hog_pins2: hog-pins2 {
-					marvell,pins = "mpp5", "mpp7", "mpp9";
-					marvell,function = "gpo";
-				};
-			};
-
 			usb at 50000 {
 				status = "okay";
 			};
-- 
2.0.0

  parent reply	other threads:[~2014-10-28 16:08 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 16:08 [PATCH 0/6] ASoC/ARM: move Marvell Armada 370 DB to simple-audio-card Thomas Petazzoni
2014-10-28 16:08 ` Thomas Petazzoni
2014-10-28 16:08 ` [PATCH 1/6] ASoC: cs42l51: re-add of_match_table pointer Thomas Petazzoni
2014-10-28 16:08   ` Thomas Petazzoni
2014-10-28 20:09   ` Brian Austin
2014-10-28 20:09     ` Brian Austin
2014-10-28 16:08 ` [PATCH 2/6] ASoC: cs42l51: make driver user-selectable Thomas Petazzoni
2014-10-28 16:08   ` Thomas Petazzoni
2014-10-28 19:50   ` Brian Austin
2014-10-28 19:50     ` Brian Austin
2014-10-28 22:34   ` Mark Brown
2014-10-28 22:34     ` Mark Brown
2014-10-28 16:08 ` [PATCH 3/6] ASoC: kirkwood: get rid of armada-370-db driver Thomas Petazzoni
2014-10-28 16:08   ` Thomas Petazzoni
2014-10-28 22:35   ` Mark Brown
2014-10-28 22:35     ` Mark Brown
2014-10-28 22:54     ` Thomas Petazzoni
2014-10-28 22:54       ` Thomas Petazzoni
2014-10-28 23:07       ` Mark Brown
2014-10-28 23:07         ` Mark Brown
2014-10-29  8:24         ` Thomas Petazzoni
2014-10-29  8:24           ` Thomas Petazzoni
2014-10-29 10:56           ` Mark Brown
2014-10-29 10:56             ` Mark Brown
2014-10-28 16:08 ` Thomas Petazzoni [this message]
2014-10-28 16:08   ` [PATCH 4/6] ARM: mvebu: remove conflicting muxing on Armada 370 DB Thomas Petazzoni
2014-11-07  3:15   ` Jason Cooper
2014-11-07  3:15     ` Jason Cooper
2014-12-18 18:13     ` Gregory CLEMENT
2014-12-18 18:13       ` Gregory CLEMENT
2014-10-28 16:08 ` [PATCH 5/6] ARM: mvebu: use simple-card DT binding for audio " Thomas Petazzoni
2014-10-28 16:08   ` Thomas Petazzoni
2014-10-28 16:08 ` [PATCH 6/6] ARM: mvebu: update mvebu_v7_defconfig for Armada 370 audio Thomas Petazzoni
2014-10-28 16:08   ` Thomas Petazzoni
2014-11-07  3:17   ` Jason Cooper
2014-11-07  3:17     ` Jason Cooper
2014-10-28 16:23 ` [PATCH 0/6] ASoC/ARM: move Marvell Armada 370 DB to simple-audio-card Andrew Lunn
2014-10-28 16:23   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414512524-24466-5-git-send-email-thomas.petazzoni@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=alior@marvell.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=nadavh@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tawfik@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.