All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Vinod Koul <vinod.koul@intel.com>,
	broonie@kernel.org, subhransu.s.prusty@intel.com,
	lgirdwood@gmail.com
Subject: [PATCH v3 1/6] ASoC: Intel: mrfld - remove unnecessary check for pointer
Date: Tue,  4 Nov 2014 16:25:15 +0530	[thread overview]
Message-ID: <1415098520-14113-2-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1415098520-14113-1-git-send-email-vinod.koul@intel.com>

the 'platform' pointer in sst_map_modules_to_pipe() is deref in caller
function so we need to check for it in this function

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/sst-atom-controls.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/intel/sst-atom-controls.c b/sound/soc/intel/sst-atom-controls.c
index 309a8f3..90aa5c0 100644
--- a/sound/soc/intel/sst-atom-controls.c
+++ b/sound/soc/intel/sst-atom-controls.c
@@ -1351,7 +1351,7 @@ static int sst_map_modules_to_pipe(struct snd_soc_platform *platform)
 	int ret = 0;
 
 	list_for_each_entry(w, &platform->component.card->widgets, list) {
-		if (platform && is_sst_dapm_widget(w) && (w->priv)) {
+		if (is_sst_dapm_widget(w) && (w->priv)) {
 			struct sst_ids *ids = w->priv;
 
 			dev_dbg(platform->dev, "widget type=%d name=%s\n",
-- 
1.7.0.4

  reply	other threads:[~2014-11-04 10:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 10:55 [PATCH v3 0/6] ASoC: Intel: ACPI support and machines Vinod Koul
2014-11-04 10:55 ` Vinod Koul [this message]
2014-11-06 12:36   ` [PATCH v3 1/6] ASoC: Intel: mrfld - remove unnecessary check for pointer Mark Brown
2014-11-04 10:55 ` [PATCH v3 2/6] ASoC: Intel: mrfld - create separate module for pci part Vinod Koul
2014-11-06 12:36   ` Mark Brown
2014-11-04 10:55 ` [PATCH v3 3/6] ASoC: Intel: mrfld - add shim save restore Vinod Koul
2014-11-06 12:36   ` Mark Brown
2014-11-04 10:55 ` [PATCH v3 4/6] ASoC: Intel: mrfld- add ACPI module Vinod Koul
2014-11-06 12:43   ` Mark Brown
2014-11-06 13:09     ` Vinod Koul
2014-11-06 13:44       ` Mark Brown
2014-11-10  6:18         ` Vinod Koul
2014-11-04 10:55 ` [PATCH v3 5/6] ASoC: Intel: add BYTCR machine driver with RT5640 Vinod Koul
2014-11-06 12:48   ` Mark Brown
2014-11-06 13:11     ` Vinod Koul
2014-11-06 13:46       ` Mark Brown
2014-11-10  6:20         ` Vinod Koul
2014-11-10 10:03           ` Mark Brown
2014-11-04 10:55 ` [PATCH v3 6/6] ASoC: Intel: Add Merrifield machine driver Vinod Koul
2014-11-06 12:51   ` Mark Brown
2014-11-06 13:18     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415098520-14113-2-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.