All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Yan <andy.yan@rock-chips.com>
To: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com,
	rmk+kernel@arm.linux.org.uk
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Shawn Guo <shawn.guo@linaro.org>,
	Andy yan <andy.yan@rock-chips.com>,
	Josh Boyer <jwboyer@redhat.com>,
	Sean Paul <seanpaul@chromium.org>,
	Inki Dae <inki.dae@samsung.com>, Dave Airlie <airlied@redhat.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Lucas Stach <l.stach@pengutronix.de>,
	Zubair.Kakakhel@imgtec.com, djkurtz@google.com,
	ykk@rock-chips.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
	jay.xu@rock-chips.com
Subject: [PATCH V4 4/6] dw-hdmi: return defer if can't get ddc i2c adapter
Date: Fri,  7 Nov 2014 19:34:28 +0800	[thread overview]
Message-ID: <1415360068-8606-1-git-send-email-andy.yan@rock-chips.com> (raw)
In-Reply-To: <1415360016-8559-1-git-send-email-andy.yan@rock-chips.com>

drm driver may probe before the i2c bus, so the driver should
defer probing untill it is avaliable

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
 drivers/gpu/drm/bridge/dw_hdmi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index 693a379..df76a8c 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -1503,8 +1503,11 @@ static int dw_hdmi_bind(struct device *dev, struct device *master, void *data)
 	ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
 	if (ddc_node) {
 		hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
-		if (!hdmi->ddc)
+		if (!hdmi->ddc) {
 			dev_dbg(hdmi->dev, "failed to read ddc node\n");
+			of_node_put(ddc_node);
+			return -EPROBE_DEFER;
+		}
 
 		of_node_put(ddc_node);
 	} else {
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Andy Yan <andy.yan@rock-chips.com>
To: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com,
	rmk+kernel@arm.linux.org.uk
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	Zubair.Kakakhel@imgtec.com, Arnd Bergmann <arnd@arndb.de>,
	Josh Boyer <jwboyer@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	ykk@rock-chips.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Inki Dae <inki.dae@samsung.com>,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Sean Paul <seanpaul@chromium.org>,
	djkurtz@google.com, Philipp Zabel <p.zabel@pengutronix.de>,
	Dave Airlie <airlied@redhat.com>,
	Grant Likely <grant.likely@linaro.org>,
	Andy yan <andy.yan@rock-chips.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	jay.xu@rock-chips.com, Lucas Stach <l.stach@pengutronix.de>
Subject: [PATCH V4 4/6] dw-hdmi: return defer if can't get ddc i2c adapter
Date: Fri,  7 Nov 2014 19:34:28 +0800	[thread overview]
Message-ID: <1415360068-8606-1-git-send-email-andy.yan@rock-chips.com> (raw)
In-Reply-To: <1415360016-8559-1-git-send-email-andy.yan@rock-chips.com>

drm driver may probe before the i2c bus, so the driver should
defer probing untill it is avaliable

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
 drivers/gpu/drm/bridge/dw_hdmi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index 693a379..df76a8c 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -1503,8 +1503,11 @@ static int dw_hdmi_bind(struct device *dev, struct device *master, void *data)
 	ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
 	if (ddc_node) {
 		hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
-		if (!hdmi->ddc)
+		if (!hdmi->ddc) {
 			dev_dbg(hdmi->dev, "failed to read ddc node\n");
+			of_node_put(ddc_node);
+			return -EPROBE_DEFER;
+		}
 
 		of_node_put(ddc_node);
 	} else {
-- 
1.9.1

  reply	other threads:[~2014-11-07 11:34 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 12:54 [PATCH V2 0/2] make imx hdmi publicly used by dw hdmi compatible platform Andy Yan
2014-11-05 12:54 ` Andy Yan
2014-11-05 12:55 ` [PATCH 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi Andy Yan
2014-11-05 12:55   ` Andy Yan
2014-11-05 13:41   ` Philipp Zabel
2014-11-05 13:41     ` Philipp Zabel
2014-11-07  2:47     ` Andy Yan
2014-11-07  2:47       ` Andy Yan
2014-11-06 11:21 ` [PATCH V3 0/4] dw-hdmi: make imx hdmi publicly used by dw hdmi compatible platform Andy Yan
2014-11-06 11:21   ` Andy Yan
2014-11-06 11:23   ` [PATCH V3 1/4] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi Andy Yan
2014-11-06 11:23     ` Andy Yan
2014-11-06 11:24     ` [PATCH V3 2/4] dw-hdmi: move imx-hdmi to bridge/dw-hdmi Andy Yan
2014-11-06 11:24       ` Andy Yan
2014-11-06 11:25       ` [PATCH V3 3/4] dw-hdmi: add support for multi byte register width access Andy Yan
2014-11-06 11:25         ` Andy Yan
2014-11-06 11:26         ` [PATCH V3 4/4] dw-hdmi: convert dw-hdmi to drm_bridge mode Andy Yan
2014-11-06 11:26           ` Andy Yan
2014-11-06 15:54           ` Greg Kroah-Hartman
2014-11-06 15:54             ` Greg Kroah-Hartman
2014-11-07  2:21             ` Andy Yan
2014-11-07  2:21               ` Andy Yan
2014-11-07 11:27   ` [PATCH V4 0/6] dw-hdmi: make imx hdmi publicly used by dw hdmi compatible platform Andy Yan
2014-11-07 11:27     ` Andy Yan
2014-11-07 11:30     ` [PATCH V4 1/6] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi Andy Yan
2014-11-07 11:30       ` Andy Yan
2014-11-07 11:32       ` [PATCH V4 2/6] dw-hdmi: move imx-hdmi to bridge/dw-hdmi Andy Yan
2014-11-07 11:32         ` Andy Yan
2014-11-07 11:33         ` [PATCH V4 3/6] dw-hdmi: make checkpatch happy Andy Yan
2014-11-07 11:33           ` Andy Yan
2014-11-07 11:34           ` Andy Yan [this message]
2014-11-07 11:34             ` [PATCH V4 4/6] dw-hdmi: return defer if can't get ddc i2c adapter Andy Yan
2014-11-07 11:35             ` [PATCH V4 5/6] dw-hdmi: add support for multi byte register width access Andy Yan
2014-11-07 11:35               ` Andy Yan
2014-11-07 11:36               ` [PATCH V4 6/6] dw-hdmi: convert dw-hdmi to drm_bridge mode Andy Yan
2014-11-07 11:36                 ` Andy Yan
2014-11-07 11:45               ` [PATCH V4 5/6] dw-hdmi: add support for multi byte register width access Lucas Stach
2014-11-07 11:45                 ` Lucas Stach
2014-11-08  3:19                 ` Andy Yan
2014-11-08  3:19                   ` Andy Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415360068-8606-1-git-send-email-andy.yan@rock-chips.com \
    --to=andy.yan@rock-chips.com \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djkurtz@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@freescale.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=inki.dae@samsung.com \
    --cc=jay.xu@rock-chips.com \
    --cc=jwboyer@redhat.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=robh+dt@kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=shawn.guo@linaro.org \
    --cc=ykk@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.