All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: linux-fsdevel@vger.kernel.org
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	xfs@oss.sgi.com, linux-btrfs@vger.kernel.org,
	"Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH 3/4] vfs: don't let the dirty time inodes get more than a day stale
Date: Fri, 21 Nov 2014 14:59:23 -0500	[thread overview]
Message-ID: <1416599964-21892-4-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1416599964-21892-1-git-send-email-tytso@mit.edu>

Guarantee that the on-disk timestamps will be no more than 24 hours
stale.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 fs/fs-writeback.c  | 1 +
 fs/inode.c         | 7 ++++++-
 include/linux/fs.h | 1 +
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index ce7de22..eb04277 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1141,6 +1141,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
 	if (flags & (I_DIRTY_SYNC | I_DIRTY_DATASYNC)) {
 		trace_writeback_dirty_inode_start(inode, flags);
 
+		inode->i_ts_dirty_day = 0;
 		if (sb->s_op->dirty_inode)
 			sb->s_op->dirty_inode(inode, flags);
 
diff --git a/fs/inode.c b/fs/inode.c
index 6e91aca..f0d6232 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1511,6 +1511,7 @@ static int relatime_need_update(struct vfsmount *mnt, struct inode *inode,
  */
 static int update_time(struct inode *inode, struct timespec *time, int flags)
 {
+	int days_since_boot = jiffies / (HZ * 86400);
 	int ret;
 
 	if (inode->i_op->update_time) {
@@ -1527,12 +1528,16 @@ static int update_time(struct inode *inode, struct timespec *time, int flags)
 		if (flags & S_MTIME)
 			inode->i_mtime = *time;
 	}
-	if (inode->i_sb->s_flags & MS_LAZYTIME) {
+	if ((inode->i_sb->s_flags & MS_LAZYTIME) &&
+	    (!inode->i_ts_dirty_day ||
+	     inode->i_ts_dirty_day == days_since_boot)) {
 		spin_lock(&inode->i_lock);
 		inode->i_state |= I_DIRTY_TIME;
 		spin_unlock(&inode->i_lock);
+		inode->i_ts_dirty_day = days_since_boot;
 		return 0;
 	}
+	inode->i_ts_dirty_day = 0;
 	if (inode->i_op->write_time)
 		return inode->i_op->write_time(inode);
 	mark_inode_dirty_sync(inode);
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 489b2f2..e3574cd 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -575,6 +575,7 @@ struct inode {
 	struct timespec		i_ctime;
 	spinlock_t		i_lock;	/* i_blocks, i_bytes, maybe i_size */
 	unsigned short          i_bytes;
+	unsigned short		i_ts_dirty_day;
 	unsigned int		i_blkbits;
 	blkcnt_t		i_blocks;
 
-- 
2.1.0


WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: linux-fsdevel@vger.kernel.org
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	Theodore Ts'o <tytso@mit.edu>,
	linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: [PATCH 3/4] vfs: don't let the dirty time inodes get more than a day stale
Date: Fri, 21 Nov 2014 14:59:23 -0500	[thread overview]
Message-ID: <1416599964-21892-4-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1416599964-21892-1-git-send-email-tytso@mit.edu>

Guarantee that the on-disk timestamps will be no more than 24 hours
stale.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 fs/fs-writeback.c  | 1 +
 fs/inode.c         | 7 ++++++-
 include/linux/fs.h | 1 +
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index ce7de22..eb04277 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1141,6 +1141,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
 	if (flags & (I_DIRTY_SYNC | I_DIRTY_DATASYNC)) {
 		trace_writeback_dirty_inode_start(inode, flags);
 
+		inode->i_ts_dirty_day = 0;
 		if (sb->s_op->dirty_inode)
 			sb->s_op->dirty_inode(inode, flags);
 
diff --git a/fs/inode.c b/fs/inode.c
index 6e91aca..f0d6232 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1511,6 +1511,7 @@ static int relatime_need_update(struct vfsmount *mnt, struct inode *inode,
  */
 static int update_time(struct inode *inode, struct timespec *time, int flags)
 {
+	int days_since_boot = jiffies / (HZ * 86400);
 	int ret;
 
 	if (inode->i_op->update_time) {
@@ -1527,12 +1528,16 @@ static int update_time(struct inode *inode, struct timespec *time, int flags)
 		if (flags & S_MTIME)
 			inode->i_mtime = *time;
 	}
-	if (inode->i_sb->s_flags & MS_LAZYTIME) {
+	if ((inode->i_sb->s_flags & MS_LAZYTIME) &&
+	    (!inode->i_ts_dirty_day ||
+	     inode->i_ts_dirty_day == days_since_boot)) {
 		spin_lock(&inode->i_lock);
 		inode->i_state |= I_DIRTY_TIME;
 		spin_unlock(&inode->i_lock);
+		inode->i_ts_dirty_day = days_since_boot;
 		return 0;
 	}
+	inode->i_ts_dirty_day = 0;
 	if (inode->i_op->write_time)
 		return inode->i_op->write_time(inode);
 	mark_inode_dirty_sync(inode);
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 489b2f2..e3574cd 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -575,6 +575,7 @@ struct inode {
 	struct timespec		i_ctime;
 	spinlock_t		i_lock;	/* i_blocks, i_bytes, maybe i_size */
 	unsigned short          i_bytes;
+	unsigned short		i_ts_dirty_day;
 	unsigned int		i_blkbits;
 	blkcnt_t		i_blocks;
 
-- 
2.1.0

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2014-11-21 19:59 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21 19:59 [PATCH 0/4] add support for a lazytime mount option Theodore Ts'o
2014-11-21 19:59 ` Theodore Ts'o
2014-11-21 19:59 ` [PATCH 1/4] fs: split update_time() into update_time() and write_time() Theodore Ts'o
2014-11-21 19:59   ` Theodore Ts'o
2014-11-21 20:08   ` Chris Mason
2014-11-21 20:08     ` Chris Mason
2014-11-21 21:42     ` Theodore Ts'o
2014-11-21 21:42       ` Theodore Ts'o
2014-11-24 16:38       ` David Sterba
2014-11-24 16:38         ` David Sterba
2014-11-24 17:22         ` Theodore Ts'o
2014-11-24 17:22           ` Theodore Ts'o
2014-11-24 18:09           ` David Sterba
2014-11-24 18:09             ` David Sterba
2014-11-24 15:21   ` Christoph Hellwig
2014-11-24 15:21     ` Christoph Hellwig
2014-11-24 15:56     ` Theodore Ts'o
2014-11-24 15:56       ` Theodore Ts'o
2014-11-24 17:34     ` David Sterba
2014-11-24 17:34       ` David Sterba
2014-11-25 15:51       ` David Sterba
2014-11-25 15:51         ` David Sterba
2014-11-25 17:01         ` Christoph Hellwig
2014-11-21 19:59 ` [PATCH 2/4] vfs: add support for a lazytime mount option Theodore Ts'o
2014-11-21 19:59   ` Theodore Ts'o
2014-11-25  1:52   ` Dave Chinner
2014-11-25  1:52     ` Dave Chinner
2014-11-25  4:33     ` Theodore Ts'o
2014-11-25  4:33       ` Theodore Ts'o
2014-11-25 15:32       ` Boaz Harrosh
2014-11-25 15:32         ` Boaz Harrosh
2014-11-25 17:19       ` Jan Kara
2014-11-25 17:19         ` Jan Kara
2014-11-25 17:57         ` Theodore Ts'o
2014-11-25 17:57           ` Theodore Ts'o
2014-11-25 20:18           ` Jan Kara
2014-11-25 20:18             ` Jan Kara
2014-11-25 17:30       ` Jan Kara
2014-11-25 17:30         ` Jan Kara
2014-11-25 19:26         ` Theodore Ts'o
2014-11-25 19:26           ` Theodore Ts'o
2014-11-26  0:24       ` Dave Chinner
2014-11-26  0:24         ` Dave Chinner
2014-11-21 19:59 ` Theodore Ts'o [this message]
2014-11-21 19:59   ` [PATCH 3/4] vfs: don't let the dirty time inodes get more than a day stale Theodore Ts'o
2014-11-21 20:19   ` Andreas Dilger
2014-11-21 20:19     ` Andreas Dilger
2014-11-21 21:36     ` Theodore Ts'o
2014-11-21 21:36       ` Theodore Ts'o
2014-11-21 23:09       ` Andreas Dilger
2014-11-25  1:53   ` Dave Chinner
2014-11-25  1:53     ` Dave Chinner
2014-11-25  4:45     ` Theodore Ts'o
2014-11-25  4:45       ` Theodore Ts'o
2014-11-25 23:48       ` Dave Chinner
2014-11-25 23:48         ` Dave Chinner
2014-11-26 10:20         ` Theodore Ts'o
2014-11-26 10:20           ` Theodore Ts'o
2014-11-26 22:39           ` Dave Chinner
2014-11-26 22:39             ` Dave Chinner
2014-11-25 17:31   ` Jan Kara
2014-11-25 17:31     ` Jan Kara
2014-11-21 19:59 ` [PATCH 4/4] ext4: add support for a lazytime mount option Theodore Ts'o
2014-11-21 19:59   ` Theodore Ts'o
2014-11-25 17:34   ` Jan Kara
2014-11-25 17:34     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416599964-21892-4-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.