All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Gleb Natapov <gleb@kernel.org>,
	Nadav Amit <namit@cs.technion.ac.il>
Subject: [PATCH 2/4] KVM: x86: fix APIC physical destination wrapping
Date: Thu, 27 Nov 2014 20:03:12 +0100	[thread overview]
Message-ID: <1417114994-25235-3-git-send-email-rkrcmar@redhat.com> (raw)
In-Reply-To: <1417114994-25235-1-git-send-email-rkrcmar@redhat.com>

x2apic allows destinations > 0xff and we don't want them delivered to
lower APICs.  They are correctly handled by doing nothing.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
 arch/x86/kvm/lapic.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index e8ad09d..049d30f 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -691,7 +691,10 @@ bool kvm_irq_delivery_to_apic_fast(struct kvm *kvm, struct kvm_lapic *src,
 		goto out;
 
 	if (irq->dest_mode == 0) { /* physical mode */
-		dst = &map->phys_map[irq->dest_id & 0xff];
+		if (irq->dest_id >= ARRAY_SIZE(map->phys_map))
+			goto out;
+
+		dst = &map->phys_map[irq->dest_id];
 	} else {
 		u32 mda = irq->dest_id << (32 - map->ldr_bits);
 
-- 
2.1.0


  parent reply	other threads:[~2014-11-27 19:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 19:03 [PATCH 0/4] KVM: x86: APIC fixes Radim Krčmář
2014-11-27 19:03 ` [PATCH 1/4] KVM: x86: deliver phys lowest-prio Radim Krčmář
2014-11-27 19:03 ` Radim Krčmář [this message]
2014-11-27 19:03 ` [PATCH 3/4] KVM: x86: allow 256 logical x2APICs again Radim Krčmář
2014-11-27 19:53   ` Nadav Amit
2014-11-27 19:53     ` Nadav Amit
2014-11-27 20:16     ` Radim Krčmář
2014-11-27 20:39       ` Nadav Amit
2014-11-27 20:39         ` Nadav Amit
2014-11-27 21:03         ` Radim Krčmář
2014-11-27 19:03 ` [PATCH 4/4] KVM: x86: don't retry hopeless APIC delivery Radim Krčmář
2014-11-27 22:30 ` [PATCH 5/4] KVM: x86: check bounds of APIC maps Radim Krčmář
2014-12-01 16:22 ` [PATCH 0/4] KVM: x86: APIC fixes Paolo Bonzini
2014-12-01 17:55   ` Radim Krčmář
2014-12-01 17:56     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417114994-25235-3-git-send-email-rkrcmar@redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namit@cs.technion.ac.il \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.