From: Andy Yan <andy.yan@rock-chips.com> To: airlied@linux.ie, Philipp Zabel <p.zabel@pengutronix.de>, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Grant Likely <grant.likely@linaro.org>, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawn.guo@linaro.org>, Josh Boyer <jwboyer@redhat.com>, Sean Paul <seanpaul@chromium.org>, Inki Dae <inki.dae@samsung.com>, Dave Airlie <airlied@redhat.com>, Arnd Bergmann <arnd@arndb.de>, Lucas Stach <l.stach@pengutronix.de>, Zubair.Kakakhel@imgtec.com, djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, Pawel Moll <pawel.moll@arm.com>, mark.yao@rock-chips.com, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Andy Yan <andy.yan@rock-chips.com> Subject: [PATCH v14 02/12] drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter Date: Mon, 1 Dec 2014 19:22:08 +0800 [thread overview] Message-ID: <1417432928-12819-1-git-send-email-andy.yan@rock-chips.com> (raw) In-Reply-To: <1417432770-12719-1-git-send-email-andy.yan@rock-chips.com> drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan <andy.yan@rock-chips.com> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> --- Changes in v14: None Changes in v13: None Changes in v12: - refactor of_node_put(ddc_node) Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - defer probe ddc i2c adapter Changes in v3: None drivers/gpu/drm/imx/imx-hdmi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-hdmi.c b/drivers/gpu/drm/imx/imx-hdmi.c index 79daec4..8029a07 100644 --- a/drivers/gpu/drm/imx/imx-hdmi.c +++ b/drivers/gpu/drm/imx/imx-hdmi.c @@ -1611,10 +1611,12 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data) ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0); if (ddc_node) { hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node); - if (!hdmi->ddc) + of_node_put(ddc_node); + if (!hdmi->ddc) { dev_dbg(hdmi->dev, "failed to read ddc node\n"); + return -EPROBE_DEFER; + } - of_node_put(ddc_node); } else { dev_dbg(hdmi->dev, "no ddc property found\n"); } -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Andy Yan <andy.yan@rock-chips.com> To: airlied@linux.ie, Philipp Zabel <p.zabel@pengutronix.de>, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: Mark Rutland <mark.rutland@arm.com>, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann <arnd@arndb.de>, linux-rockchip@lists.infradead.org, Grant Likely <grant.likely@linaro.org>, Dave Airlie <airlied@redhat.com>, jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Inki Dae <inki.dae@samsung.com>, Rob Herring <robh+dt@kernel.org>, Sean Paul <seanpaul@chromium.org>, mark.yao@rock-chips.com, Josh Boyer <jwboyer@redhat.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala <galak@codeaurora.org>, Andy Yan <andy.yan@rock-chips.com>, Shawn Guo <shawn.guo@linaro.org>, Lucas Stach <l.stach@pengutronix.de> Subject: [PATCH v14 02/12] drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter Date: Mon, 1 Dec 2014 19:22:08 +0800 [thread overview] Message-ID: <1417432928-12819-1-git-send-email-andy.yan@rock-chips.com> (raw) In-Reply-To: <1417432770-12719-1-git-send-email-andy.yan@rock-chips.com> drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan <andy.yan@rock-chips.com> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> --- Changes in v14: None Changes in v13: None Changes in v12: - refactor of_node_put(ddc_node) Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - defer probe ddc i2c adapter Changes in v3: None drivers/gpu/drm/imx/imx-hdmi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-hdmi.c b/drivers/gpu/drm/imx/imx-hdmi.c index 79daec4..8029a07 100644 --- a/drivers/gpu/drm/imx/imx-hdmi.c +++ b/drivers/gpu/drm/imx/imx-hdmi.c @@ -1611,10 +1611,12 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data) ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0); if (ddc_node) { hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node); - if (!hdmi->ddc) + of_node_put(ddc_node); + if (!hdmi->ddc) { dev_dbg(hdmi->dev, "failed to read ddc node\n"); + return -EPROBE_DEFER; + } - of_node_put(ddc_node); } else { dev_dbg(hdmi->dev, "no ddc property found\n"); } -- 1.9.1
next prev parent reply other threads:[~2014-12-01 11:22 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-01 11:19 [PATCH v14 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan 2014-12-01 11:19 ` Andy Yan 2014-12-01 11:21 ` [PATCH v14 01/12] drm: imx: imx-hdmi: make checkpatch happy Andy Yan 2014-12-01 11:21 ` Andy Yan 2014-12-01 11:22 ` Andy Yan [this message] 2014-12-01 11:22 ` [PATCH v14 02/12] drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter Andy Yan 2014-12-01 11:23 ` [PATCH v14 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode Andy Yan 2014-12-01 11:23 ` Andy Yan 2014-12-01 11:23 ` [PATCH v14 04/12] drm: imx: imx-hdmi: split phy configuration to platform driver Andy Yan 2014-12-01 11:23 ` Andy Yan 2014-12-01 11:24 ` [PATCH v14 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi Andy Yan 2014-12-01 11:24 ` Andy Yan 2014-12-01 11:42 ` Philipp Zabel 2014-12-01 11:42 ` Philipp Zabel 2014-12-01 11:53 ` Andy Yan 2014-12-01 11:53 ` Andy Yan 2014-12-01 11:25 ` [PATCH v14 06/12] dt-bindings: add document for dw_hdmi Andy Yan 2014-12-01 11:25 ` Andy Yan 2014-12-01 11:26 ` [PATCH v14 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access Andy Yan 2014-12-01 11:26 ` Andy Yan 2014-12-01 11:26 ` [PATCH v14 08/12] drm: bridge/dw_hdmi: add mode_valid support Andy Yan 2014-12-01 11:26 ` Andy Yan 2014-12-01 11:27 ` [PATCH v14 09/12] drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done Andy Yan 2014-12-01 11:27 ` Andy Yan 2014-12-01 11:28 ` [PATCH v14 10/12] drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare Andy Yan 2014-12-01 11:28 ` Andy Yan 2014-12-01 11:28 ` [PATCH v14 11/12] dt-bindings: Add documentation for rockchip dw hdmi Andy Yan 2014-12-01 11:28 ` Andy Yan 2014-12-01 11:29 ` [PATCH v14 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support Andy Yan 2014-12-01 11:29 ` Andy Yan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1417432928-12819-1-git-send-email-andy.yan@rock-chips.com \ --to=andy.yan@rock-chips.com \ --cc=Zubair.Kakakhel@imgtec.com \ --cc=airlied@linux.ie \ --cc=airlied@redhat.com \ --cc=arnd@arndb.de \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=djkurtz@google.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=fabio.estevam@freescale.com \ --cc=galak@codeaurora.org \ --cc=grant.likely@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=inki.dae@samsung.com \ --cc=jay.xu@rock-chips.com \ --cc=jwboyer@redhat.com \ --cc=l.stach@pengutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=mark.yao@rock-chips.com \ --cc=p.zabel@pengutronix.de \ --cc=pawel.moll@arm.com \ --cc=rmk+kernel@arm.linux.org.uk \ --cc=robh+dt@kernel.org \ --cc=seanpaul@chromium.org \ --cc=shawn.guo@linaro.org \ --cc=ykk@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.