All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: virtualization@lists.linux-foundation.org, rusty@rustcorp.com.au
Cc: kvm@vger.kernel.org, m@bues.ch, mpm@selenic.com,
	amit.shah@redhat.com, linux-kernel@vger.kernel.org,
	herbert@gondor.apana.org.au
Subject: [PATCH v5 5/6] hw_random: don't double-check old_rng.
Date: Sat,  6 Dec 2014 12:16:41 +0800	[thread overview]
Message-ID: <1417839402-13490-6-git-send-email-akong@redhat.com> (raw)
In-Reply-To: <1417839402-13490-1-git-send-email-akong@redhat.com>

From: Rusty Russell <rusty@rustcorp.com.au>

Interesting anti-pattern.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 drivers/char/hw_random/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 067270b..a9286bf 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -476,14 +476,13 @@ int hwrng_register(struct hwrng *rng)
 	}
 
 	old_rng = current_rng;
+	err = 0;
 	if (!old_rng) {
 		err = hwrng_init(rng);
 		if (err)
 			goto out_unlock;
 		set_current_rng(rng);
-	}
-	err = 0;
-	if (!old_rng) {
+
 		err = register_miscdev();
 		if (err) {
 			drop_current_rng();
-- 
1.9.3


  parent reply	other threads:[~2014-12-06  4:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-06  4:16 [PATCH v5 0/6] fix hw_random stuck Amos Kong
2014-12-06  4:16 ` Amos Kong
2014-12-06  4:16 ` [PATCH v5 1/6] hw_random: place mutex around read functions and buffers Amos Kong
2014-12-06  4:16   ` Amos Kong
2014-12-06  4:16 ` [PATCH v5 2/6] hw_random: move some code out mutex_lock for avoiding underlying deadlock Amos Kong
2014-12-06  4:16   ` Amos Kong
2014-12-06  4:16 ` [PATCH v5 3/6] hw_random: use reference counts on each struct hwrng Amos Kong
2014-12-06  4:16   ` Amos Kong
2014-12-06  4:16 ` [PATCH v5 4/6] hw_random: fix unregister race Amos Kong
2014-12-06  4:16   ` Amos Kong
2014-12-06  4:16 ` Amos Kong [this message]
2014-12-06  4:16 ` [PATCH v5 5/6] hw_random: don't double-check old_rng Amos Kong
2014-12-06  4:16 ` [PATCH v5 6/6] hw_random: don't init list element we're about to add to list Amos Kong
2014-12-06  4:16 ` Amos Kong
2014-12-06  6:59 ` [PATCH v5 0/6] fix hw_random stuck Herbert Xu
2014-12-06  6:59   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417839402-13490-6-git-send-email-akong@redhat.com \
    --to=akong@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=mpm@selenic.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.