From: Olof Johansson <olof@lixom.net> To: mturquette@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, f.fainelli@gmail.com, Olof Johansson <olof@lixom.net> Subject: [PATCH 1/2] clk: bcm: kona: don't return -EFOO as bool Date: Mon, 8 Dec 2014 13:54:04 -0800 [thread overview] Message-ID: <1418075645-14571-1-git-send-email-olof@lixom.net> (raw) Found with sparse: drivers/clk/bcm/clk-kona.c:1255:16: warning: odd constant _Bool cast (ffffffffffffffea becomes 1) Signed-off-by: Olof Johansson <olof@lixom.net> --- drivers/clk/bcm/clk-kona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index 95af2e6..53fca77 100644 --- a/drivers/clk/bcm/clk-kona.c +++ b/drivers/clk/bcm/clk-kona.c @@ -1252,7 +1252,7 @@ static bool __kona_clk_init(struct kona_clk *bcm_clk) default: BUG(); } - return -EINVAL; + return false; } /* Set a CCU and all its clocks into their desired initial state */ -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] clk: bcm: kona: don't return -EFOO as bool Date: Mon, 8 Dec 2014 13:54:04 -0800 [thread overview] Message-ID: <1418075645-14571-1-git-send-email-olof@lixom.net> (raw) Found with sparse: drivers/clk/bcm/clk-kona.c:1255:16: warning: odd constant _Bool cast (ffffffffffffffea becomes 1) Signed-off-by: Olof Johansson <olof@lixom.net> --- drivers/clk/bcm/clk-kona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index 95af2e6..53fca77 100644 --- a/drivers/clk/bcm/clk-kona.c +++ b/drivers/clk/bcm/clk-kona.c @@ -1252,7 +1252,7 @@ static bool __kona_clk_init(struct kona_clk *bcm_clk) default: BUG(); } - return -EINVAL; + return false; } /* Set a CCU and all its clocks into their desired initial state */ -- 1.7.10.4
next reply other threads:[~2014-12-08 21:51 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-08 21:54 Olof Johansson [this message] 2014-12-08 21:54 ` [PATCH 1/2] clk: bcm: kona: don't return -EFOO as bool Olof Johansson 2014-12-08 21:54 ` [PATCH 2/2] clk: bcm: kona: make a variable static Olof Johansson 2014-12-08 21:54 ` Olof Johansson 2014-12-09 8:59 ` [PATCH 1/2] clk: bcm: kona: don't return -EFOO as bool Arnd Bergmann 2014-12-09 8:59 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1418075645-14571-1-git-send-email-olof@lixom.net \ --to=olof@lixom.net \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.