All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-sh@vger.kernel.org
Subject: [PATCH 07/15] drm: rcar-du: Output HSYNC instead of CSYNC
Date: Wed, 10 Dec 2014 23:42:07 +0000	[thread overview]
Message-ID: <1418254935-13536-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <1418254935-13536-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

The DU outputs by default a composite sync signal (XOR of the horizontal
and vertical sync signals) on the HSYNC output pin. As this can confuse
devices and isn't needed by any of the supported encoders, configure the
HSYNC pin to output the horizontal sync signal.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index ce280bd390a9..25b762b58765 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -144,7 +144,7 @@ static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc)
 	/* Signal polarities */
 	value = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? 0 : DSMR_VSL)
 	      | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? 0 : DSMR_HSL)
-	      | DSMR_DIPM_DE;
+	      | DSMR_DIPM_DE | DSMR_CSPM;
 	rcar_du_crtc_write(rcrtc, DSMR, value);
 
 	/* Display timings */
-- 
2.0.4


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-sh@vger.kernel.org
Subject: [PATCH 07/15] drm: rcar-du: Output HSYNC instead of CSYNC
Date: Thu, 11 Dec 2014 01:42:07 +0200	[thread overview]
Message-ID: <1418254935-13536-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <1418254935-13536-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

The DU outputs by default a composite sync signal (XOR of the horizontal
and vertical sync signals) on the HSYNC output pin. As this can confuse
devices and isn't needed by any of the supported encoders, configure the
HSYNC pin to output the horizontal sync signal.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index ce280bd390a9..25b762b58765 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -144,7 +144,7 @@ static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc)
 	/* Signal polarities */
 	value = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? 0 : DSMR_VSL)
 	      | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? 0 : DSMR_HSL)
-	      | DSMR_DIPM_DE;
+	      | DSMR_DIPM_DE | DSMR_CSPM;
 	rcar_du_crtc_write(rcrtc, DSMR, value);
 
 	/* Display timings */
-- 
2.0.4


  parent reply	other threads:[~2014-12-10 23:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10 23:42 [PATCH 00/15] R-Car DU fixes and enhancements (including interlaced support) Laurent Pinchart
2014-12-10 23:42 ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 01/15] drm: adv7511: Remove interlaced mode check Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 02/15] drm: rcar-du: Don't fail probe in case of partial encoder init error Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 03/15] drm: rcar-du: Configure pitch for chroma plane of multiplanar formats Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 04/15] drm: rcar-du: Remove LVDS and HDMI encoders chaining restriction Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 05/15] drm: rcar-du: Refactor DEFR8 feature Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 06/15] drm: rcar-du: Add support for external pixel clock Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` Laurent Pinchart [this message]
2014-12-10 23:42   ` [PATCH 07/15] drm: rcar-du: Output HSYNC instead of CSYNC Laurent Pinchart
2014-12-10 23:42 ` [PATCH 08/15] drm: rcar-du: Enable hotplug detection on HDMI connector Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 09/15] drm: rcar-du: Clamp DPMS states to on and off Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 10/15] drm: rcar-du: Implement support for interlaced modes Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 11/15] ARM: shmobile: lager: Add DU HDMI output support Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2015-02-26  1:29   ` Simon Horman
2015-02-26  1:29     ` Simon Horman
2014-12-10 23:42 ` [PATCH 12/15] ARM: shmobile: koelsch: " Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 13/15] ARM: shmobile: marzen: Add DU external pixel clock to DT Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 14/15] ARM: shmobile: lager: Add DU external pixel clocks " Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart
2014-12-10 23:42 ` [PATCH 15/15] ARM: shmobile: koelsch: " Laurent Pinchart
2014-12-10 23:42   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418254935-13536-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com \
    --to=laurent.pinchart+renesas@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.