All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: xfs@oss.sgi.com, cluster-devel@redhat.com,
	ocfs2-devel@oss.oracle.com, Jan Kara <jack@suse.cz>
Subject: [PATCH 01/25] xfs: Remove useless test
Date: Thu, 18 Dec 2014 16:37:15 +0100	[thread overview]
Message-ID: <1418917059-23870-2-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1418917059-23870-1-git-send-email-jack@suse.cz>

Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/xfs/xfs_quotaops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
index 7542bbeca6a1..8fcd20dbf89a 100644
--- a/fs/xfs/xfs_quotaops.c
+++ b/fs/xfs/xfs_quotaops.c
@@ -75,7 +75,7 @@ xfs_fs_set_xstate(
 
 	if (sb->s_flags & MS_RDONLY)
 		return -EROFS;
-	if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp))
+	if (!XFS_IS_QUOTA_RUNNING(mp))
 		return -ENOSYS;
 
 	if (uflags & FS_QUOTA_UDQ_ACCT)
-- 
1.8.4.5


WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: cluster-devel@redhat.com, Jan Kara <jack@suse.cz>,
	ocfs2-devel@oss.oracle.com, xfs@oss.sgi.com
Subject: [PATCH 01/25] xfs: Remove useless test
Date: Thu, 18 Dec 2014 16:37:15 +0100	[thread overview]
Message-ID: <1418917059-23870-2-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1418917059-23870-1-git-send-email-jack@suse.cz>

Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/xfs/xfs_quotaops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
index 7542bbeca6a1..8fcd20dbf89a 100644
--- a/fs/xfs/xfs_quotaops.c
+++ b/fs/xfs/xfs_quotaops.c
@@ -75,7 +75,7 @@ xfs_fs_set_xstate(
 
 	if (sb->s_flags & MS_RDONLY)
 		return -EROFS;
-	if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp))
+	if (!XFS_IS_QUOTA_RUNNING(mp))
 		return -ENOSYS;
 
 	if (uflags & FS_QUOTA_UDQ_ACCT)
-- 
1.8.4.5

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: xfs@oss.sgi.com, cluster-devel@redhat.com,
	ocfs2-devel@oss.oracle.com, Jan Kara <jack@suse.cz>
Subject: [Ocfs2-devel] [PATCH 01/25] xfs: Remove useless test
Date: Thu, 18 Dec 2014 16:37:15 +0100	[thread overview]
Message-ID: <1418917059-23870-2-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1418917059-23870-1-git-send-email-jack@suse.cz>

Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/xfs/xfs_quotaops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
index 7542bbeca6a1..8fcd20dbf89a 100644
--- a/fs/xfs/xfs_quotaops.c
+++ b/fs/xfs/xfs_quotaops.c
@@ -75,7 +75,7 @@ xfs_fs_set_xstate(
 
 	if (sb->s_flags & MS_RDONLY)
 		return -EROFS;
-	if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp))
+	if (!XFS_IS_QUOTA_RUNNING(mp))
 		return -ENOSYS;
 
 	if (uflags & FS_QUOTA_UDQ_ACCT)
-- 
1.8.4.5

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 01/25] xfs: Remove useless test
Date: Thu, 18 Dec 2014 16:37:15 +0100	[thread overview]
Message-ID: <1418917059-23870-2-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1418917059-23870-1-git-send-email-jack@suse.cz>

Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/xfs/xfs_quotaops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
index 7542bbeca6a1..8fcd20dbf89a 100644
--- a/fs/xfs/xfs_quotaops.c
+++ b/fs/xfs/xfs_quotaops.c
@@ -75,7 +75,7 @@ xfs_fs_set_xstate(
 
 	if (sb->s_flags & MS_RDONLY)
 		return -EROFS;
-	if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp))
+	if (!XFS_IS_QUOTA_RUNNING(mp))
 		return -ENOSYS;
 
 	if (uflags & FS_QUOTA_UDQ_ACCT)
-- 
1.8.4.5



  reply	other threads:[~2014-12-18 15:37 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 15:37 [PATCH 0/25 RFC v2] quota: Unify VFS and XFS quota interfaces Jan Kara
2014-12-18 15:37 ` [Cluster-devel] " Jan Kara
2014-12-18 15:37 ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37 ` Jan Kara
2014-12-18 15:37 ` Jan Kara [this message]
2014-12-18 15:37   ` [Cluster-devel] [PATCH 01/25] xfs: Remove useless test Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 02/25] xfs: Remove unused variable in xfs_qm_scall_quotaon() Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 03/25] xfs: Remove some useless flags tests Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 04/25] quota: Split ->set_xstate callback into two Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37 ` [PATCH 05/25] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Jan Kara
2014-12-18 15:37   ` [Cluster-devel] [PATCH 05/25] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 06/25] quota: Add ->quota_{enable,disable} callbacks for VFS quotas Jan Kara
2014-12-18 15:37   ` [Cluster-devel] [PATCH 06/25] quota: Add ->quota_{enable, disable} " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 07/25] ext4: Use generic helpers for quotaon and quotaoff Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 08/25] ocfs2: " Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 09/25] quota: Remove quota_on_meta callback Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 10/25] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 11/25] quota: Store maximum space limit in bytes Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 12/25] quota: Make Q_XQUOTASYNC support VFS quota syncing Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 13/25] quota: Don't store flags for v2 quota format Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 14/25] ocfs2: Move OLQF_CLEAN flag out of generic quota flags Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 15/25] quota: Cleanup flags definitions Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 16/25] quota: Verify flags passed to Q_SETINFO Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 17/25] quota: Make VFS quotas use new interface for getting quota info Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 18/25] quota: Wire up Q_GETXSTATE and Q_GETXSTATV calls to work with ->get_state Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 19/25] xfs: Remove some pointless quota checks Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 20/25] xfs: Convert to using ->get_state callback Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 21/25] gfs2: " Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 22/25] quota: Remove ->get_xstate and ->get_xstatev callbacks Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 23/25] quota: Make ->set_info use structure with neccesary info to VFS and XFS Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 24/25] xfs: Add support for Q_SETINFO Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara
2014-12-18 15:37 ` [PATCH 25/25] quota: Hook up Q_XSETQLIM for id 0 to ->set_info Jan Kara
2014-12-18 15:37   ` [Cluster-devel] " Jan Kara
2014-12-18 15:37   ` [Ocfs2-devel] " Jan Kara
2014-12-18 15:37   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418917059-23870-2-git-send-email-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=cluster-devel@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.