All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Olga Kornievskaia <aglo@umich.edu>
Cc: linux-nfs <linux-nfs@vger.kernel.org>
Subject: [PATCH v3 2/2] NFSv4: Remove incorrect check in can_open_delegated()
Date: Fri, 19 Dec 2014 15:44:05 -0500	[thread overview]
Message-ID: <1419021845-96747-2-git-send-email-trond.myklebust@primarydata.com> (raw)
In-Reply-To: <1419021845-96747-1-git-send-email-trond.myklebust@primarydata.com>
In-Reply-To: <CAHQdGtTqO02BWwTOsXn2s641_KBdawBexG5+kGwmJKWaAmewtA@mail.gmail.com>

Remove an incorrect check for NFS_DELEGATION_NEED_RECLAIM in
can_open_delegated(). We are allowed to cache opens even in
a situation where we're doing reboot recovery.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
---
 fs/nfs/nfs4proc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 8514b59a8c30..002c7dfedb08 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -1119,8 +1119,6 @@ static int can_open_delegated(struct nfs_delegation *delegation, fmode_t fmode)
 		return 0;
 	if ((delegation->type & fmode) != fmode)
 		return 0;
-	if (test_bit(NFS_DELEGATION_NEED_RECLAIM, &delegation->flags))
-		return 0;
 	if (test_bit(NFS_DELEGATION_RETURNING, &delegation->flags))
 		return 0;
 	nfs_mark_delegation_referenced(delegation);
-- 
2.1.0


  parent reply	other threads:[~2014-12-19 20:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 15:11 question about code in delegation.c Olga Kornievskaia
2014-12-19 15:37 ` Trond Myklebust
2014-12-19 16:01   ` Olga Kornievskaia
2014-12-19 18:10     ` [PATCH 1/2] NFSv4: Deal with atomic upgrades of an existing delegation Trond Myklebust
2014-12-19 18:51       ` Trond Myklebust
2014-12-19 18:52         ` [PATCH v2 " Trond Myklebust
2014-12-19 20:16           ` Olga Kornievskaia
2014-12-19 20:31           ` Trond Myklebust
2014-12-19 20:39             ` Olga Kornievskaia
2014-12-19 20:46               ` Trond Myklebust
2014-12-19 20:44             ` [PATCH v3 " Trond Myklebust
2014-12-19 20:44             ` Trond Myklebust [this message]
2015-08-18 20:38               ` [PATCH v3 2/2] NFSv4: Remove incorrect check in can_open_delegated() Olga Kornievskaia
2015-08-18 21:07                 ` Trond Myklebust
2015-08-18 21:13                   ` Olga Kornievskaia
2015-08-18 21:18                     ` Trond Myklebust
2014-12-19 18:52         ` [PATCH v2 " Trond Myklebust
2014-12-19 18:10     ` [PATCH " Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419021845-96747-2-git-send-email-trond.myklebust@primarydata.com \
    --to=trond.myklebust@primarydata.com \
    --cc=aglo@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.