All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhilash Kesavan <a.kesavan@samsung.com>
To: kgene.kim@samsung.com, linux-arm-kernel@lists.infradead.org,
	arm@kernel.org, arnd@arndb.de, khilman@kernel.org,
	olof@lixom.net
Cc: linux-samsung-soc@vger.kernel.org, kesavan.abhilash@gmail.com,
	sudeep.holla@arm.com, nicolas.pitre@linaro.org,
	Punit.Agrawal@arm.com, Will.Deacon@arm.com, Mark.Rutland@arm.com,
	k.kozlowski@samsung.com
Subject: [PATCH 1/2] drivers: bus: check cci device tree node status
Date: Sat, 10 Jan 2015 08:41:35 +0530	[thread overview]
Message-ID: <1420859496-27533-1-git-send-email-a.kesavan@samsung.com> (raw)

The arm-cci driver completes the probe sequence even if the cci node is
marked as disabled. Add a check in the driver to honour the cci status
in the device tree.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Kevin Hilman <khilman@linaro.org>
---
Changes:
	- Re-sending without the RFT tags

 drivers/bus/arm-cci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 860da40..0ce5e2d 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -1312,6 +1312,9 @@ static int cci_probe(void)
 	if (!np)
 		return -ENODEV;
 
+	if (!of_device_is_available(np))
+		return -ENODEV;
+
 	cci_config = of_match_node(arm_cci_matches, np)->data;
 	if (!cci_config)
 		return -ENODEV;
-- 
2.2.0

WARNING: multiple messages have this Message-ID (diff)
From: a.kesavan@samsung.com (Abhilash Kesavan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] drivers: bus: check cci device tree node status
Date: Sat, 10 Jan 2015 08:41:35 +0530	[thread overview]
Message-ID: <1420859496-27533-1-git-send-email-a.kesavan@samsung.com> (raw)

The arm-cci driver completes the probe sequence even if the cci node is
marked as disabled. Add a check in the driver to honour the cci status
in the device tree.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Kevin Hilman <khilman@linaro.org>
---
Changes:
	- Re-sending without the RFT tags

 drivers/bus/arm-cci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 860da40..0ce5e2d 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -1312,6 +1312,9 @@ static int cci_probe(void)
 	if (!np)
 		return -ENODEV;
 
+	if (!of_device_is_available(np))
+		return -ENODEV;
+
 	cci_config = of_match_node(arm_cci_matches, np)->data;
 	if (!cci_config)
 		return -ENODEV;
-- 
2.2.0

             reply	other threads:[~2015-01-10  3:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-10  3:11 Abhilash Kesavan [this message]
2015-01-10  3:11 ` [PATCH 1/2] drivers: bus: check cci device tree node status Abhilash Kesavan
2015-01-10  3:11 ` [PATCH 2/2] arm: dts: disable CCI on exynos420 based arndale-octa Abhilash Kesavan
2015-01-10  3:11   ` Abhilash Kesavan
2015-01-13  2:05   ` Olof Johansson
2015-01-13  2:05     ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420859496-27533-1-git-send-email-a.kesavan@samsung.com \
    --to=a.kesavan@samsung.com \
    --cc=Mark.Rutland@arm.com \
    --cc=Punit.Agrawal@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=k.kozlowski@samsung.com \
    --cc=kesavan.abhilash@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=olof@lixom.net \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.