From: Xing Gu <gux.fnst@cn.fujitsu.com> To: <fstests@vger.kernel.org> Cc: <linux-btrfs@vger.kernel.org>, <david@fromorbit.com>, <eguan@redhat.com>, <quwenruo@cn.fujitsu.com>, Xing Gu <gux.fnst@cn.fujitsu.com> Subject: [PATCH v6] btrfs: add regression test for remount with thread_pool resized Date: Thu, 29 Jan 2015 08:46:00 +0800 [thread overview] Message-ID: <1422492360-12243-1-git-send-email-gux.fnst@cn.fujitsu.com> (raw) Regression test for a btrfs issue of resizing 'thread_pool' when remount the fs. This regression was introduced by the following linux kernel commit: btrfs: Added btrfs_workqueue_struct implemented ordered execution based on kernel workqueue 08a9ff3264181986d1d692a4e6fce3669700c9f8 And it was fixed by the following linux kernel commit: btrfs: fix crash in remount(thread_pool=) case 800ee2247f483b6d05ed47ef3bbc90b56451746c Signed-off-by: Xing Gu <gux.fnst@cn.fujitsu.com> --- v5->v6: Add a filter to wipe "Performing full device TRIM" and "Turning ON incompat feature" in common/filter:_filter_mkfs. v4->v5: Redirect stderr to /dev/null. v3->v4: Remove the check for a bug message. v2->v3: Add the regresssion commit in description. Remove "dmesg -c > /dev/null". Echo "Silence is golden" to indicate that an empty output file is expected. v1->v2: Add the fix commit in description. Add the check for a bug message. --- common/filter | 4 ++++ tests/btrfs/082 | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/082.out | 2 ++ tests/btrfs/group | 1 + 4 files changed, 72 insertions(+) create mode 100755 tests/btrfs/082 create mode 100644 tests/btrfs/082.out diff --git a/common/filter b/common/filter index 05dbae6..71ef2e2 100644 --- a/common/filter +++ b/common/filter @@ -137,6 +137,10 @@ _filter_mkfs() case $FSTYP in xfs) ;; + btrfs) + sed -e "/Performing full device TRIM/d" \ + -e "/Turning ON incompat feature/d" + return ;; *) cat - >/dev/null perl -e 'print STDERR "dbsize=4096\nisize=256\n"' diff --git a/tests/btrfs/082 b/tests/btrfs/082 new file mode 100755 index 0000000..dd3c87e --- /dev/null +++ b/tests/btrfs/082 @@ -0,0 +1,65 @@ +#!/bin/bash +# FS QA Test No. btrfs/082 +# +# Regression test for a btrfs issue of resizing 'thread_pool' when +# remount the fs. +# +# This regression was introduced by the following linux kernel commit: +# btrfs: Added btrfs_workqueue_struct implemented ordered +# execution based on kernel workqueue +# 08a9ff3264181986d1d692a4e6fce3669700c9f8 +# And it was fixed by the following linux kernel commit: +# btrfs: fix crash in remount(thread_pool=) case +# 800ee2247f483b6d05ed47ef3bbc90b56451746c +# +#----------------------------------------------------------------------- +# Copyright (c) 2015 Fujitsu. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + rm -f $tmp.* +} + +trap "_cleanup ; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs btrfs +_supported_os Linux +_require_scratch + +_scratch_mkfs |& _filter_mkfs + +_scratch_mount "-o thread_pool=6" +_scratch_mount "-o remount,thread_pool=10" + +echo "Silence is golden" +status=0 +exit diff --git a/tests/btrfs/082.out b/tests/btrfs/082.out new file mode 100644 index 0000000..2977f14 --- /dev/null +++ b/tests/btrfs/082.out @@ -0,0 +1,2 @@ +QA output created by 082 +Silence is golden diff --git a/tests/btrfs/group b/tests/btrfs/group index e29999b..fd2fa76 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -84,3 +84,4 @@ 079 auto rw metadata 080 auto snapshot 081 auto quick clone +082 auto quick remount -- 1.9.3
WARNING: multiple messages have this Message-ID (diff)
From: Xing Gu <gux.fnst@cn.fujitsu.com> To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, david@fromorbit.com, eguan@redhat.com, quwenruo@cn.fujitsu.com, Xing Gu <gux.fnst@cn.fujitsu.com> Subject: [PATCH v6] btrfs: add regression test for remount with thread_pool resized Date: Thu, 29 Jan 2015 08:46:00 +0800 [thread overview] Message-ID: <1422492360-12243-1-git-send-email-gux.fnst@cn.fujitsu.com> (raw) Regression test for a btrfs issue of resizing 'thread_pool' when remount the fs. This regression was introduced by the following linux kernel commit: btrfs: Added btrfs_workqueue_struct implemented ordered execution based on kernel workqueue 08a9ff3264181986d1d692a4e6fce3669700c9f8 And it was fixed by the following linux kernel commit: btrfs: fix crash in remount(thread_pool=) case 800ee2247f483b6d05ed47ef3bbc90b56451746c Signed-off-by: Xing Gu <gux.fnst@cn.fujitsu.com> --- v5->v6: Add a filter to wipe "Performing full device TRIM" and "Turning ON incompat feature" in common/filter:_filter_mkfs. v4->v5: Redirect stderr to /dev/null. v3->v4: Remove the check for a bug message. v2->v3: Add the regresssion commit in description. Remove "dmesg -c > /dev/null". Echo "Silence is golden" to indicate that an empty output file is expected. v1->v2: Add the fix commit in description. Add the check for a bug message. --- common/filter | 4 ++++ tests/btrfs/082 | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/082.out | 2 ++ tests/btrfs/group | 1 + 4 files changed, 72 insertions(+) create mode 100755 tests/btrfs/082 create mode 100644 tests/btrfs/082.out diff --git a/common/filter b/common/filter index 05dbae6..71ef2e2 100644 --- a/common/filter +++ b/common/filter @@ -137,6 +137,10 @@ _filter_mkfs() case $FSTYP in xfs) ;; + btrfs) + sed -e "/Performing full device TRIM/d" \ + -e "/Turning ON incompat feature/d" + return ;; *) cat - >/dev/null perl -e 'print STDERR "dbsize=4096\nisize=256\n"' diff --git a/tests/btrfs/082 b/tests/btrfs/082 new file mode 100755 index 0000000..dd3c87e --- /dev/null +++ b/tests/btrfs/082 @@ -0,0 +1,65 @@ +#!/bin/bash +# FS QA Test No. btrfs/082 +# +# Regression test for a btrfs issue of resizing 'thread_pool' when +# remount the fs. +# +# This regression was introduced by the following linux kernel commit: +# btrfs: Added btrfs_workqueue_struct implemented ordered +# execution based on kernel workqueue +# 08a9ff3264181986d1d692a4e6fce3669700c9f8 +# And it was fixed by the following linux kernel commit: +# btrfs: fix crash in remount(thread_pool=) case +# 800ee2247f483b6d05ed47ef3bbc90b56451746c +# +#----------------------------------------------------------------------- +# Copyright (c) 2015 Fujitsu. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + rm -f $tmp.* +} + +trap "_cleanup ; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs btrfs +_supported_os Linux +_require_scratch + +_scratch_mkfs |& _filter_mkfs + +_scratch_mount "-o thread_pool=6" +_scratch_mount "-o remount,thread_pool=10" + +echo "Silence is golden" +status=0 +exit diff --git a/tests/btrfs/082.out b/tests/btrfs/082.out new file mode 100644 index 0000000..2977f14 --- /dev/null +++ b/tests/btrfs/082.out @@ -0,0 +1,2 @@ +QA output created by 082 +Silence is golden diff --git a/tests/btrfs/group b/tests/btrfs/group index e29999b..fd2fa76 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -84,3 +84,4 @@ 079 auto rw metadata 080 auto snapshot 081 auto quick clone +082 auto quick remount -- 1.9.3
next reply other threads:[~2015-01-29 1:30 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-29 0:46 Xing Gu [this message] 2015-01-29 0:46 ` [PATCH v6] btrfs: add regression test for remount with thread_pool resized Xing Gu 2015-02-19 18:19 ` Filipe David Manana
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1422492360-12243-1-git-send-email-gux.fnst@cn.fujitsu.com \ --to=gux.fnst@cn.fujitsu.com \ --cc=david@fromorbit.com \ --cc=eguan@redhat.com \ --cc=fstests@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=quwenruo@cn.fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.