All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Kan <fkan@apm.com>
To: patches@apm.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh@kernel.org,
	linux-arm-kernel@lists.infradead.org, tinamdar@apm.com
Cc: Feng Kan <fkan@apm.com>
Subject: [PATCH] pci: host: xgene: fix incorrectly returned address by map_bus
Date: Tue, 17 Feb 2015 15:14:00 -0800	[thread overview]
Message-ID: <1424214840-26498-1-git-send-email-fkan@apm.com> (raw)

The generic accessor functions for pci-xgene uses map_bus
call that returns the base address but did not add the additional
offset.

Signed-off-by: Feng Kan <fkan@apm.com>
---
 drivers/pci/host/pci-xgene.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
index aab5547..ee082c0 100644
--- a/drivers/pci/host/pci-xgene.c
+++ b/drivers/pci/host/pci-xgene.c
@@ -127,7 +127,7 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
 	return false;
 }
 
-static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
+static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
 			      int offset)
 {
 	struct xgene_pcie_port *port = bus->sysdata;
@@ -137,7 +137,7 @@ static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
 		return NULL;
 
 	xgene_pcie_set_rtdid_reg(bus, devfn);
-	return xgene_pcie_get_cfg_base(bus);
+	return xgene_pcie_get_cfg_base(bus) + offset;
 }
 
 static struct pci_ops xgene_pcie_ops = {
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: fkan@apm.com (Feng Kan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pci: host: xgene: fix incorrectly returned address by map_bus
Date: Tue, 17 Feb 2015 15:14:00 -0800	[thread overview]
Message-ID: <1424214840-26498-1-git-send-email-fkan@apm.com> (raw)

The generic accessor functions for pci-xgene uses map_bus
call that returns the base address but did not add the additional
offset.

Signed-off-by: Feng Kan <fkan@apm.com>
---
 drivers/pci/host/pci-xgene.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
index aab5547..ee082c0 100644
--- a/drivers/pci/host/pci-xgene.c
+++ b/drivers/pci/host/pci-xgene.c
@@ -127,7 +127,7 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
 	return false;
 }
 
-static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
+static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
 			      int offset)
 {
 	struct xgene_pcie_port *port = bus->sysdata;
@@ -137,7 +137,7 @@ static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
 		return NULL;
 
 	xgene_pcie_set_rtdid_reg(bus, devfn);
-	return xgene_pcie_get_cfg_base(bus);
+	return xgene_pcie_get_cfg_base(bus) + offset;
 }
 
 static struct pci_ops xgene_pcie_ops = {
-- 
1.9.1

             reply	other threads:[~2015-02-17 23:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 23:14 Feng Kan [this message]
2015-02-17 23:14 ` [PATCH] pci: host: xgene: fix incorrectly returned address by map_bus Feng Kan
2015-02-19 22:53 ` Tanmay Inamdar
2015-02-19 22:53   ` Tanmay Inamdar
2015-02-20 22:09 ` Rob Herring
2015-02-20 22:09   ` Rob Herring
2015-02-20 22:09   ` Rob Herring
2015-02-27  0:21 ` Bjorn Helgaas
2015-02-27  0:21   ` Bjorn Helgaas
2015-03-05 16:38   ` Bjorn Helgaas
2015-03-05 16:38     ` Bjorn Helgaas
2015-03-05 16:53     ` Feng Kan
2015-03-05 16:53       ` Feng Kan
2015-03-05 16:53       ` Feng Kan
2015-03-06  4:12       ` Bjorn Helgaas
2015-03-06  4:12         ` Bjorn Helgaas
2015-03-06  4:12         ` Bjorn Helgaas
2015-03-05 20:57     ` Rob Herring
2015-03-05 20:57       ` Rob Herring
2015-03-05 20:57       ` Rob Herring
2015-03-06  4:53       ` Bjorn Helgaas
2015-03-06  4:53         ` Bjorn Helgaas
2015-03-06  4:53         ` Bjorn Helgaas
2015-03-06  4:54 ` Bjorn Helgaas
2015-03-06  4:54   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424214840-26498-1-git-send-email-fkan@apm.com \
    --to=fkan@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=patches@apm.com \
    --cc=robh@kernel.org \
    --cc=tinamdar@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.