All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>, Jiri Kosina <jkosina@suse.cz>,
	David Herrmann <dh.herrmann@googlemail.com>,
	Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
	Darren Hart <dvhart@infradead.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Milo Kim <milo.kim@ti.com>,
	Julian Andres Klode <jak@jak-linux.org>,
	Marc Dietrich <marvin24@gmx.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-acpi@vger.kernel.org, linux-input@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	patches@opensource.wolfsonmicro.com, ac100@lists.launchpad.net,
	linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Samuel
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Pavel Machek <pavel@ucw.cz>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v4 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs
Date: Mon, 23 Feb 2015 12:47:25 +0100	[thread overview]
Message-ID: <1424692061-30624-5-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1424692061-30624-1-git-send-email-k.kozlowski@samsung.com>

Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
 - get_property -> power_supply_get_property
 - set_property -> power_supply_set_property
 - property_is_writeable -> power_supply_property_is_writeable

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
---
 drivers/power/power_supply_sysfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index 62653f50a524..f817aab80813 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -76,7 +76,7 @@ static ssize_t power_supply_show_property(struct device *dev,
 	if (off == POWER_SUPPLY_PROP_TYPE) {
 		value.intval = psy->type;
 	} else {
-		ret = psy->get_property(psy, off, &value);
+		ret = power_supply_get_property(psy, off, &value);
 
 		if (ret < 0) {
 			if (ret == -ENODATA)
@@ -125,7 +125,7 @@ static ssize_t power_supply_store_property(struct device *dev,
 
 	value.intval = long_val;
 
-	ret = psy->set_property(psy, off, &value);
+	ret = power_supply_set_property(psy, off, &value);
 	if (ret < 0)
 		return ret;
 
@@ -223,7 +223,7 @@ static umode_t power_supply_attr_is_visible(struct kobject *kobj,
 
 		if (property == attrno) {
 			if (psy->property_is_writeable &&
-			    psy->property_is_writeable(psy, property) > 0)
+			    power_supply_property_is_writeable(psy, property) > 0)
 				mode |= S_IWUSR;
 
 			return mode;
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>, Jiri Kosina <jkosina@suse.cz>,
	David Herrmann <dh.herrmann@googlemail.com>,
	Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
	Darren Hart <dvhart@infradead.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Milo Kim <milo.kim@ti.com>,
	Julian Andres Klode <jak@jak-linux.org>,
	Marc Dietrich <marvin24@gmx.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-acpi@vger.kernel.org, linux-input@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	patches@opensource.wolfsonmicro.com, ac100@lists.launchpad.net,
	linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Thomas Gleixner <tglx@linutronix.de>, Pavel Machek <pavel@ucw.cz>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Subject: [PATCH v4 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs
Date: Mon, 23 Feb 2015 12:47:25 +0100	[thread overview]
Message-ID: <1424692061-30624-5-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1424692061-30624-1-git-send-email-k.kozlowski@samsung.com>

Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
 - get_property -> power_supply_get_property
 - set_property -> power_supply_set_property
 - property_is_writeable -> power_supply_property_is_writeable

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
---
 drivers/power/power_supply_sysfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index 62653f50a524..f817aab80813 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -76,7 +76,7 @@ static ssize_t power_supply_show_property(struct device *dev,
 	if (off == POWER_SUPPLY_PROP_TYPE) {
 		value.intval = psy->type;
 	} else {
-		ret = psy->get_property(psy, off, &value);
+		ret = power_supply_get_property(psy, off, &value);
 
 		if (ret < 0) {
 			if (ret == -ENODATA)
@@ -125,7 +125,7 @@ static ssize_t power_supply_store_property(struct device *dev,
 
 	value.intval = long_val;
 
-	ret = psy->set_property(psy, off, &value);
+	ret = power_supply_set_property(psy, off, &value);
 	if (ret < 0)
 		return ret;
 
@@ -223,7 +223,7 @@ static umode_t power_supply_attr_is_visible(struct kobject *kobj,
 
 		if (property == attrno) {
 			if (psy->property_is_writeable &&
-			    psy->property_is_writeable(psy, property) > 0)
+			    power_supply_property_is_writeable(psy, property) > 0)
 				mode |= S_IWUSR;
 
 			return mode;
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs
Date: Mon, 23 Feb 2015 12:47:25 +0100	[thread overview]
Message-ID: <1424692061-30624-5-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1424692061-30624-1-git-send-email-k.kozlowski@samsung.com>

Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
 - get_property -> power_supply_get_property
 - set_property -> power_supply_set_property
 - property_is_writeable -> power_supply_property_is_writeable

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
---
 drivers/power/power_supply_sysfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index 62653f50a524..f817aab80813 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -76,7 +76,7 @@ static ssize_t power_supply_show_property(struct device *dev,
 	if (off == POWER_SUPPLY_PROP_TYPE) {
 		value.intval = psy->type;
 	} else {
-		ret = psy->get_property(psy, off, &value);
+		ret = power_supply_get_property(psy, off, &value);
 
 		if (ret < 0) {
 			if (ret == -ENODATA)
@@ -125,7 +125,7 @@ static ssize_t power_supply_store_property(struct device *dev,
 
 	value.intval = long_val;
 
-	ret = psy->set_property(psy, off, &value);
+	ret = power_supply_set_property(psy, off, &value);
 	if (ret < 0)
 		return ret;
 
@@ -223,7 +223,7 @@ static umode_t power_supply_attr_is_visible(struct kobject *kobj,
 
 		if (property == attrno) {
 			if (psy->property_is_writeable &&
-			    psy->property_is_writeable(psy, property) > 0)
+			    power_supply_property_is_writeable(psy, property) > 0)
 				mode |= S_IWUSR;
 
 			return mode;
-- 
1.9.1

  parent reply	other threads:[~2015-02-23 11:47 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 11:47 [PATCH v4 00/20] power_supply: Allow safe usage of power supply Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
     [not found] ` <1424692061-30624-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-02-23 11:47   ` [PATCH v4 01/20] power_supply: Add driver private data Krzysztof Kozlowski
2015-02-23 11:47     ` Krzysztof Kozlowski
2015-02-23 11:47     ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 02/20] power_supply: Move run-time configuration to separate structure Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-26  0:34   ` Sebastian Reichel
2015-02-26  1:10     ` Dmitry Torokhov
2015-02-26  1:58       ` Sebastian Reichel
2015-02-23 11:47 ` [PATCH v4 03/20] power_supply: Add API for safe access of power supply function attrs Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski [this message]
2015-02-23 11:47   ` [PATCH v4 04/20] power_supply: sysfs: Use power_supply_*() API for accessing " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 05/20] power_supply: 88pm860x_charger: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 06/20] power_supply: ab8500: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 07/20] mfd: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 08/20] power_supply: apm_power: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 09/20] power_supply: bq2415x_charger: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 10/20] power_supply: charger-manager: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 11/20] power_supply: Change ownership from driver to core Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-26  0:45   ` Sebastian Reichel
2015-02-26  0:45     ` Sebastian Reichel
2015-02-26  0:45     ` Sebastian Reichel
2015-02-26  6:14     ` Darren Hart
2015-02-26  6:14       ` Darren Hart
2015-02-26  6:14       ` Darren Hart
2015-02-26 11:28       ` Krzysztof Kozlowski
2015-02-26 11:31         ` Krzysztof Kozlowski
2015-03-03 16:44           ` Darren Hart
2015-02-26  9:30     ` Krzysztof Kozlowski
2015-02-26  9:30       ` Krzysztof Kozlowski
2015-02-26  9:30       ` Krzysztof Kozlowski
2015-02-26  8:24   ` Lee Jones
2015-02-26  8:24     ` Lee Jones
2015-02-26  8:24     ` Lee Jones
2015-02-23 11:47 ` [PATCH v4 12/20] power_supply: Add power_supply_put for decrementing device reference counter Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 13/20] power_supply: Increment power supply use counter when obtaining references Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 14/20] power_supply: charger-manager: Decrement the power supply's device reference counter Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 15/20] x86/olpc/xo1/sci: Use newly added power_supply_put API Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 16/20] x86/olpc/xo15/sci: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 17/20] power_supply: 88pm860x_charger: Decrement the power supply's device reference counter Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 18/20] power_supply: bq2415x_charger: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 19/20] mfd: ab8500: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 20/20] arm: mach-pxa: " Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 11:47   ` Krzysztof Kozlowski
2015-02-23 22:18 ` [PATCH v4 00/20] power_supply: Allow safe usage of power supply Pavel Machek
2015-02-23 22:18   ` Pavel Machek
2015-02-23 22:18   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424692061-30624-5-git-send-email-k.kozlowski@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=ac100@lists.launchpad.net \
    --cc=cezary.jackiewicz@gmail.com \
    --cc=dbaryshkov@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dh.herrmann@googlemail.com \
    --cc=dvhart@infradead.org \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jak@jak-linux.org \
    --cc=jkosina@suse.cz \
    --cc=kyungmin.park@samsung.com \
    --cc=lenb@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=marvin24@gmx.de \
    --cc=milo.kim@ti.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sre@kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.