All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: emil.l.velikov@gmail.com
Subject: [PATCH libdrm 4/4] autotools: add WARN_CFLAGS to all targets
Date: Mon, 23 Feb 2015 13:57:42 +0000	[thread overview]
Message-ID: <1424699862-4077-5-git-send-email-emil.l.velikov@gmail.com> (raw)
In-Reply-To: <1424699862-4077-1-git-send-email-emil.l.velikov@gmail.com>

... minus test/ttmtest. The latter is not really hooked up with the
actual build.

This will give us 66 warnings on a distribution build of which
 - 12 -Wunused-variable
 - 11 -Wunused-function
 - 19 -Wmissing-prototypes
and a few -Wswitch-enum, -Wtype-limits etc.

Adding the CFLAGS gives some exposure to these so that we can fix them.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
---
 Makefile.am                 | 1 +
 tests/Makefile.am           | 3 ++-
 tests/exynos/Makefile.am    | 1 +
 tests/kmstest/Makefile.am   | 1 +
 tests/modeprint/Makefile.am | 1 +
 tests/proptest/Makefile.am  | 1 +
 tests/radeon/Makefile.am    | 1 +
 tests/tegra/Makefile.am     | 2 +-
 tests/vbltest/Makefile.am   | 2 ++
 9 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 062feb4..9514cc5 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -82,6 +82,7 @@ libdrm_la_LIBADD = @CLOCK_LIB@
 
 libdrm_la_CPPFLAGS = -I$(top_srcdir)/include/drm
 AM_CFLAGS = \
+	$(WARN_CFLAGS) \
 	$(VALGRIND_CFLAGS)
 
 libdrm_la_SOURCES = $(LIBDRM_FILES)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 37b8d3a..f989d8e 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1,6 +1,7 @@
 NULL:=#
 
-AM_CPPFLAGS = \
+AM_CFLAGS = \
+	$(WARN_CFLAGS)\
 	-I $(top_srcdir)/include/drm \
 	-I $(top_srcdir)
 
diff --git a/tests/exynos/Makefile.am b/tests/exynos/Makefile.am
index 92de4e4..b21d016 100644
--- a/tests/exynos/Makefile.am
+++ b/tests/exynos/Makefile.am
@@ -1,4 +1,5 @@
 AM_CFLAGS = \
+	$(WARN_CFLAGS)\
 	-I $(top_srcdir)/include/drm \
 	-I $(top_srcdir)/libkms/ \
 	-I $(top_srcdir)/exynos \
diff --git a/tests/kmstest/Makefile.am b/tests/kmstest/Makefile.am
index 7903a26..fd21e61 100644
--- a/tests/kmstest/Makefile.am
+++ b/tests/kmstest/Makefile.am
@@ -1,4 +1,5 @@
 AM_CFLAGS = \
+	$(WARN_CFLAGS)\
 	-I$(top_srcdir)/include/drm \
 	-I$(top_srcdir)/libkms/ \
 	-I$(top_srcdir)
diff --git a/tests/modeprint/Makefile.am b/tests/modeprint/Makefile.am
index 6420ef3..895805f 100644
--- a/tests/modeprint/Makefile.am
+++ b/tests/modeprint/Makefile.am
@@ -1,4 +1,5 @@
 AM_CFLAGS = \
+	$(WARN_CFLAGS)\
 	-I$(top_srcdir)/include/drm \
 	-I$(top_srcdir)
 
diff --git a/tests/proptest/Makefile.am b/tests/proptest/Makefile.am
index f81a3c0..48a84c1 100644
--- a/tests/proptest/Makefile.am
+++ b/tests/proptest/Makefile.am
@@ -1,4 +1,5 @@
 AM_CFLAGS = \
+	$(WARN_CFLAGS)\
 	-I$(top_srcdir)/include/drm \
 	-I$(top_srcdir)
 
diff --git a/tests/radeon/Makefile.am b/tests/radeon/Makefile.am
index 1775669..d18620d 100644
--- a/tests/radeon/Makefile.am
+++ b/tests/radeon/Makefile.am
@@ -1,4 +1,5 @@
 AM_CFLAGS = \
+	$(WARN_CFLAGS)\
 	-I $(top_srcdir)/include/drm \
 	-I $(top_srcdir)
 
diff --git a/tests/tegra/Makefile.am b/tests/tegra/Makefile.am
index ca63d92..8e625c8 100644
--- a/tests/tegra/Makefile.am
+++ b/tests/tegra/Makefile.am
@@ -3,7 +3,7 @@ AM_CPPFLAGS = \
 	-I$(top_srcdir)/tegra \
 	-I$(top_srcdir)
 
-AM_CFLAGS = -Wall -Werror
+AM_CFLAGS = $(WARN_CFLAGS)
 
 LDADD = \
 	../../tegra/libdrm_tegra.la \
diff --git a/tests/vbltest/Makefile.am b/tests/vbltest/Makefile.am
index 34a35e7..4d87887 100644
--- a/tests/vbltest/Makefile.am
+++ b/tests/vbltest/Makefile.am
@@ -1,6 +1,8 @@
 AM_CFLAGS = \
+	$(WARN_CFLAGS)\
 	-I$(top_srcdir)/include/drm \
 	-I$(top_srcdir)
+
 if HAVE_INSTALL_TESTS
 bin_PROGRAMS = \
 	vbltest
-- 
2.3.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-02-23 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 13:57 [PATCH 00/04 libdrm] The rocky road to building with -Wextra Emil Velikov
2015-02-23 13:57 ` [PATCH libdrm 1/4] autotools: add AM_DISTCHECK_CONFIGURE_FLAGS Emil Velikov
2015-02-23 13:57 ` [PATCH libdrm 2/4] exynos_fimg2d_test: fix implicit funciton declaration errors Emil Velikov
2015-02-23 13:57 ` [PATCH libdrm 3/4] tests: " Emil Velikov
2015-02-23 13:57 ` Emil Velikov [this message]
2015-02-25 15:25 ` [PATCH 00/04 libdrm] The rocky road to building with -Wextra Emil Velikov
2015-02-25 17:02   ` Jan Vesely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424699862-4077-5-git-send-email-emil.l.velikov@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.