All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Russell King <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: [PATCH] clkdev: clk_add_alias don't put origin clock
Date: Sun,  1 Mar 2015 16:43:35 +0900	[thread overview]
Message-ID: <1425195815-14895-1-git-send-email-ysato@users.sourceforge.jp> (raw)

Refer to 'r' later.
So don't put in clk_add_alias.

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
 drivers/clk/clkdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index 043fd36..fddb999 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -318,7 +318,6 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
 		return PTR_ERR(r);
 
 	l = clkdev_alloc(r, alias, alias_dev_name);
-	clk_put(r);
 	if (!l)
 		return -ENODEV;
 	clkdev_add(l);
@@ -334,6 +333,7 @@ void clkdev_drop(struct clk_lookup *cl)
 	mutex_lock(&clocks_mutex);
 	list_del(&cl->node);
 	mutex_unlock(&clocks_mutex);
+	clk_put(cl->clk);
 	kfree(cl);
 }
 EXPORT_SYMBOL(clkdev_drop);
-- 
2.1.4


WARNING: multiple messages have this Message-ID (diff)
From: ysato@users.sourceforge.jp (Yoshinori Sato)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clkdev: clk_add_alias don't put origin clock
Date: Sun,  1 Mar 2015 16:43:35 +0900	[thread overview]
Message-ID: <1425195815-14895-1-git-send-email-ysato@users.sourceforge.jp> (raw)

Refer to 'r' later.
So don't put in clk_add_alias.

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
 drivers/clk/clkdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index 043fd36..fddb999 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -318,7 +318,6 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
 		return PTR_ERR(r);
 
 	l = clkdev_alloc(r, alias, alias_dev_name);
-	clk_put(r);
 	if (!l)
 		return -ENODEV;
 	clkdev_add(l);
@@ -334,6 +333,7 @@ void clkdev_drop(struct clk_lookup *cl)
 	mutex_lock(&clocks_mutex);
 	list_del(&cl->node);
 	mutex_unlock(&clocks_mutex);
+	clk_put(cl->clk);
 	kfree(cl);
 }
 EXPORT_SYMBOL(clkdev_drop);
-- 
2.1.4

             reply	other threads:[~2015-03-01  7:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-01  7:43 Yoshinori Sato [this message]
2015-03-01  7:43 ` [PATCH] clkdev: clk_add_alias don't put origin clock Yoshinori Sato
2015-03-01 14:51 ` Russell King - ARM Linux
2015-03-01 14:51   ` Russell King - ARM Linux
2015-03-03  6:40   ` Yoshinori Sato
2015-03-03  6:40     ` Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425195815-14895-1-git-send-email-ysato@users.sourceforge.jp \
    --to=ysato@users.sourceforge.jp \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.