All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Peter Zijlstra <peterz@infradead.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	linux-pm@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
	linux-watchdog@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>,
	linux-serial@vger.kernel.org,
	Mike Turquette <mturquette@linaro.org>,
	linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
Date: Mon,  2 Mar 2015 10:18:17 +0100	[thread overview]
Message-ID: <1425287898-15093-6-git-send-email-boris.brezillon@free-electrons.com> (raw)
In-Reply-To: <1425287898-15093-1-git-send-email-boris.brezillon@free-electrons.com>

The watchdog interrupt (only used when activating software watchdog)
shouldn't be suspended when entering suspend mode, because it is shared
with a timer device (which request the line with IRQF_NO_SUSPEND) and once
the watchdog "Mode Register" has been written, it cannot be changed (which
means we cannot disable the watchdog interrupt when entering suspend).

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 drivers/watchdog/at91sam9_wdt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
index 6df9405..1443b3c 100644
--- a/drivers/watchdog/at91sam9_wdt.c
+++ b/drivers/watchdog/at91sam9_wdt.c
@@ -208,7 +208,8 @@ static int at91_wdt_init(struct platform_device *pdev, struct at91wdt *wdt)
 
 	if ((tmp & AT91_WDT_WDFIEN) && wdt->irq) {
 		err = request_irq(wdt->irq, wdt_interrupt,
-				  IRQF_SHARED | IRQF_IRQPOLL,
+				  IRQF_SHARED | IRQF_IRQPOLL |
+				  IRQF_NO_SUSPEND,
 				  pdev->name, wdt);
 		if (err)
 			return err;
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>
Cc: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
	linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Jiri Slaby <jslaby-AlSwsSmVLrQ@public.gmane.org>,
	linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mike Turquette
	<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Nicolas Ferre
	<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
	Jean-Christophe Plagniol-Villard
	<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
	Alexandre Belloni
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Boris Brezillon
	<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
Date: Mon,  2 Mar 2015 10:18:17 +0100	[thread overview]
Message-ID: <1425287898-15093-6-git-send-email-boris.brezillon@free-electrons.com> (raw)
In-Reply-To: <1425287898-15093-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

The watchdog interrupt (only used when activating software watchdog)
shouldn't be suspended when entering suspend mode, because it is shared
with a timer device (which request the line with IRQF_NO_SUSPEND) and once
the watchdog "Mode Register" has been written, it cannot be changed (which
means we cannot disable the watchdog interrupt when entering suspend).

Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
---
 drivers/watchdog/at91sam9_wdt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
index 6df9405..1443b3c 100644
--- a/drivers/watchdog/at91sam9_wdt.c
+++ b/drivers/watchdog/at91sam9_wdt.c
@@ -208,7 +208,8 @@ static int at91_wdt_init(struct platform_device *pdev, struct at91wdt *wdt)
 
 	if ((tmp & AT91_WDT_WDFIEN) && wdt->irq) {
 		err = request_irq(wdt->irq, wdt_interrupt,
-				  IRQF_SHARED | IRQF_IRQPOLL,
+				  IRQF_SHARED | IRQF_IRQPOLL |
+				  IRQF_NO_SUSPEND,
 				  pdev->name, wdt);
 		if (err)
 			return err;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
Date: Mon,  2 Mar 2015 10:18:17 +0100	[thread overview]
Message-ID: <1425287898-15093-6-git-send-email-boris.brezillon@free-electrons.com> (raw)
In-Reply-To: <1425287898-15093-1-git-send-email-boris.brezillon@free-electrons.com>

The watchdog interrupt (only used when activating software watchdog)
shouldn't be suspended when entering suspend mode, because it is shared
with a timer device (which request the line with IRQF_NO_SUSPEND) and once
the watchdog "Mode Register" has been written, it cannot be changed (which
means we cannot disable the watchdog interrupt when entering suspend).

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 drivers/watchdog/at91sam9_wdt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
index 6df9405..1443b3c 100644
--- a/drivers/watchdog/at91sam9_wdt.c
+++ b/drivers/watchdog/at91sam9_wdt.c
@@ -208,7 +208,8 @@ static int at91_wdt_init(struct platform_device *pdev, struct at91wdt *wdt)
 
 	if ((tmp & AT91_WDT_WDFIEN) && wdt->irq) {
 		err = request_irq(wdt->irq, wdt_interrupt,
-				  IRQF_SHARED | IRQF_IRQPOLL,
+				  IRQF_SHARED | IRQF_IRQPOLL |
+				  IRQF_NO_SUSPEND,
 				  pdev->name, wdt);
 		if (err)
 			return err;
-- 
1.9.1

  parent reply	other threads:[~2015-03-02  9:19 UTC|newest]

Thread overview: 180+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02  9:18 [PATCH v2 0/6] ARM: at91: fix irq_pm_install_action WARNING Boris Brezillon
2015-03-02  9:18 ` Boris Brezillon
2015-03-02  9:18 ` Boris Brezillon
2015-03-02  9:18 ` [PATCH v2 1/6] PM / wakeup: export pm_system_wakeup symbol Boris Brezillon
2015-03-02  9:18   ` Boris Brezillon
2015-03-02  9:18 ` [PATCH v2 2/6] rtc: at91sam9: rework wakeup and interrupt handling Boris Brezillon
2015-03-02  9:18   ` Boris Brezillon
2015-03-02  9:18   ` Boris Brezillon
2015-03-04 18:23   ` Mark Rutland
2015-03-04 18:23     ` Mark Rutland
2015-03-04 18:23     ` Mark Rutland
2015-03-04 18:23     ` Mark Rutland
2015-03-02  9:18 ` [PATCH v2 3/6] rtc: at91rm9200: " Boris Brezillon
2015-03-02  9:18   ` Boris Brezillon
2015-03-02  9:18 ` [PATCH v2 4/6] clk: at91: implement suspend/resume for the PMC irqchip Boris Brezillon
2015-03-02  9:18   ` Boris Brezillon
2015-03-02  9:18   ` Boris Brezillon
2015-03-09 22:34   ` Mike Turquette
2015-03-09 22:34     ` Mike Turquette
2015-03-09 22:34     ` Mike Turquette
2015-03-09 22:34     ` Mike Turquette
2015-03-02  9:18 ` Boris Brezillon [this message]
2015-03-02  9:18   ` [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND Boris Brezillon
2015-03-02  9:18   ` Boris Brezillon
2015-03-02 14:10   ` Guenter Roeck
2015-03-02 14:10     ` Guenter Roeck
2015-03-04 18:38   ` Mark Rutland
2015-03-04 18:38     ` Mark Rutland
2015-03-04 18:38     ` Mark Rutland
2015-03-04 18:38     ` Mark Rutland
2015-03-04 21:41     ` Rafael J. Wysocki
2015-03-04 21:41       ` Rafael J. Wysocki
2015-03-04 21:41       ` Rafael J. Wysocki
2015-03-04 21:41       ` Rafael J. Wysocki
2015-03-05 10:57       ` Mark Rutland
2015-03-05 10:57         ` Mark Rutland
2015-03-05 10:57         ` Mark Rutland
2015-03-05 10:57         ` Mark Rutland
2015-03-05 15:10         ` Rafael J. Wysocki
2015-03-05 15:10           ` Rafael J. Wysocki
2015-03-05 15:10           ` Rafael J. Wysocki
2015-03-05 15:10           ` Rafael J. Wysocki
2015-03-05 16:32           ` Mark Rutland
2015-03-05 16:32             ` Mark Rutland
2015-03-05 16:32             ` Mark Rutland
2015-03-05 16:32             ` Mark Rutland
2015-03-06  0:29             ` Rafael J. Wysocki
2015-03-06  0:29               ` Rafael J. Wysocki
2015-03-06  0:29               ` Rafael J. Wysocki
2015-03-06  0:29               ` Rafael J. Wysocki
2015-03-06 11:06               ` Mark Rutland
2015-03-06 11:06                 ` Mark Rutland
2015-03-06 11:06                 ` Mark Rutland
2015-03-06 11:06                 ` Mark Rutland
2015-03-06 12:39                 ` Rafael J. Wysocki
2015-03-06 12:39                   ` Rafael J. Wysocki
2015-03-06 12:39                   ` Rafael J. Wysocki
2015-03-06 12:39                   ` Rafael J. Wysocki
2015-03-06 13:10                   ` Mark Rutland
2015-03-06 13:10                     ` Mark Rutland
2015-03-06 13:10                     ` Mark Rutland
2015-03-06 13:10                     ` Mark Rutland
2015-03-07  9:12                 ` Peter Zijlstra
2015-03-07  9:12                   ` Peter Zijlstra
2015-03-07  9:12                   ` Peter Zijlstra
2015-03-07  9:12                   ` Peter Zijlstra
2015-03-07  9:06           ` Peter Zijlstra
2015-03-07  9:06             ` Peter Zijlstra
2015-03-07  9:06             ` Peter Zijlstra
2015-03-07  9:06             ` Peter Zijlstra
2015-03-05  8:53     ` Boris Brezillon
2015-03-05  8:53       ` Boris Brezillon
2015-03-05  8:53       ` Boris Brezillon
2015-03-05  8:53       ` Boris Brezillon
2015-03-05 10:53       ` Mark Rutland
2015-03-05 10:53         ` Mark Rutland
2015-03-05 10:53         ` Mark Rutland
2015-03-05 10:53         ` Mark Rutland
2015-03-05 11:17         ` Boris Brezillon
2015-03-05 11:17           ` Boris Brezillon
2015-03-05 11:17           ` Boris Brezillon
2015-03-05 11:17           ` Boris Brezillon
2015-03-05 11:31           ` Boris Brezillon
2015-03-05 11:31             ` Boris Brezillon
2015-03-05 11:31             ` Boris Brezillon
2015-03-05 11:31             ` Boris Brezillon
2015-03-05 11:53           ` Mark Rutland
2015-03-05 11:53             ` Mark Rutland
2015-03-05 11:53             ` Mark Rutland
2015-03-05 11:53             ` Mark Rutland
2015-03-07  9:18             ` Peter Zijlstra
2015-03-07  9:18               ` Peter Zijlstra
2015-03-07  9:18               ` Peter Zijlstra
2015-03-07  9:18               ` Peter Zijlstra
2015-03-07 10:20               ` Sylvain Rochet
2015-03-07 10:20                 ` Sylvain Rochet
2015-03-07 10:20                 ` Sylvain Rochet
2015-03-07 10:20                 ` Sylvain Rochet
2015-03-07 10:39                 ` Pavel Machek
2015-03-07 10:39                   ` Pavel Machek
2015-03-07 10:39                   ` Pavel Machek
2015-03-07 10:39                   ` Pavel Machek
2015-03-07 10:59                   ` Sylvain Rochet
2015-03-07 10:59                     ` Sylvain Rochet
2015-03-07 10:59                     ` Sylvain Rochet
2015-03-07 10:59                     ` Sylvain Rochet
2015-03-07 11:06                   ` Alexandre Belloni
2015-03-07 11:06                     ` Alexandre Belloni
2015-03-07 11:06                     ` Alexandre Belloni
2015-03-07 11:06                     ` Alexandre Belloni
2015-03-07 11:29                     ` Pavel Machek
2015-03-07 11:29                       ` Pavel Machek
2015-03-07 11:29                       ` Pavel Machek
2015-03-07 11:29                       ` Pavel Machek
2015-03-07 11:46                       ` Sylvain Rochet
2015-03-07 11:46                         ` Sylvain Rochet
2015-03-07 11:46                         ` Sylvain Rochet
2015-03-07 11:46                         ` Sylvain Rochet
2015-03-08  1:12                       ` Rafael J. Wysocki
2015-03-08  1:12                         ` Rafael J. Wysocki
2015-03-08  1:12                         ` Rafael J. Wysocki
2015-03-08  1:12                         ` Rafael J. Wysocki
2015-03-09  7:55                         ` Alexandre Belloni
2015-03-09  7:55                           ` Alexandre Belloni
2015-03-09  7:55                           ` Alexandre Belloni
2015-03-09  7:55                           ` Alexandre Belloni
2015-03-09 14:30                           ` Rafael J. Wysocki
2015-03-09 14:30                             ` Rafael J. Wysocki
2015-03-09 14:30                             ` Rafael J. Wysocki
2015-03-09 14:30                             ` Rafael J. Wysocki
2015-03-10 21:33                             ` Alexandre Belloni
2015-03-10 21:33                               ` Alexandre Belloni
2015-03-10 21:33                               ` Alexandre Belloni
2015-03-10 21:33                               ` Alexandre Belloni
2015-03-10 22:31                               ` Rafael J. Wysocki
2015-03-10 22:31                                 ` Rafael J. Wysocki
2015-03-10 22:31                                 ` Rafael J. Wysocki
2015-03-10 22:31                                 ` Rafael J. Wysocki
2015-03-10 22:33                                 ` Alexandre Belloni
2015-03-10 22:33                                   ` Alexandre Belloni
2015-03-10 22:33                                   ` Alexandre Belloni
2015-03-10 22:33                                   ` Alexandre Belloni
2015-03-11  1:03                                   ` Rafael J. Wysocki
2015-03-11  1:03                                     ` Rafael J. Wysocki
2015-03-11  1:03                                     ` Rafael J. Wysocki
2015-03-11  1:03                                     ` Rafael J. Wysocki
2015-03-11  7:33                                     ` Boris Brezillon
2015-03-11  7:33                                       ` Boris Brezillon
2015-03-11  7:33                                       ` Boris Brezillon
2015-03-11  7:33                                       ` Boris Brezillon
2015-03-08  1:11                     ` Rafael J. Wysocki
2015-03-08  1:11                       ` Rafael J. Wysocki
2015-03-08  1:11                       ` Rafael J. Wysocki
2015-03-08  1:11                       ` Rafael J. Wysocki
2015-03-11  8:38                       ` Boris Brezillon
2015-03-11  8:38                         ` Boris Brezillon
2015-03-11  8:38                         ` Boris Brezillon
2015-03-11  8:38                         ` Boris Brezillon
2015-03-11 11:17                         ` Nicolas Ferre
2015-03-11 11:17                           ` Nicolas Ferre
2015-03-11 11:17                           ` Nicolas Ferre
2015-03-11 11:17                           ` Nicolas Ferre
2015-03-11 11:17                           ` Nicolas Ferre
2015-03-02  9:18 ` [PATCH v2 6/6] tty: serial: atmel: rework interrupt and wakeup handling Boris Brezillon
2015-03-02  9:18   ` Boris Brezillon
2015-03-03  8:56 ` [PATCH v2 0/6] ARM: at91: fix irq_pm_install_action WARNING Alexandre Belloni
2015-03-03  8:56   ` Alexandre Belloni
2015-03-03  8:56   ` Alexandre Belloni
2015-03-03 15:35 ` Nicolas Ferre
2015-03-03 15:35   ` Nicolas Ferre
2015-03-03 15:35   ` Nicolas Ferre
2015-03-03 15:35   ` Nicolas Ferre
2015-03-04  1:43   ` Rafael J. Wysocki
2015-03-04  1:43     ` Rafael J. Wysocki
2015-03-04  1:43     ` Rafael J. Wysocki
2015-03-04  1:43     ` Rafael J. Wysocki
2015-03-04 18:43 ` Mark Rutland
2015-03-04 18:43   ` Mark Rutland
2015-03-04 18:43   ` Mark Rutland
2015-03-04 18:43   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425287898-15093-6-git-send-email-boris.brezillon@free-electrons.com \
    --to=boris.brezillon@free-electrons.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason@lakedaemon.net \
    --cc=jslaby@suse.cz \
    --cc=len.brown@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@linaro.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=rjw@rjwysocki.net \
    --cc=rtc-linux@googlegroups.com \
    --cc=tglx@linutronix.de \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.